Solved No errors, but a code of the plugin is not working?

Hello,

I'd like you to please check my code:

Code:java

package me.phoenix;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.permissions.Permission;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class BlockListener extends JavaPlugin {
 
    public Permission playerPermissionBedrock = new Permission("place.blockedbedrock");
    public Permission playerPermissionTNT = new Permission("place.blockedtnt");
 
    @Override
    public void onEnable() {
        getLogger().info("Grief protection V. 1.1 by SkyZ Developpers!");
        new antiblock(this);
        PluginManager pm = getServer().getPluginManager();
        pm.addPermission(playerPermissionBedrock);
        pm.addPermission(playerPermissionTNT);
    }
 
    @Override
    public void onDisable() {
        getLogger().info("DISABLING CUSTOM GRIEF PROTECTION");
 
 
    }
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        if (cmd.getName().equalsIgnoreCase("blocklistener") && sender instanceof Player) {
 
            Player player = (Player) sender;
 
            player.sendMessage(ChatColor.GOLD + "Private plugin made by Phoenix566 :)");
 
        }
 
 
 
        if (cmd.getName().equalsIgnoreCase("bannedblocks") && sender instanceof Player) {
 
            Player player = (Player) sender;
 
            player.sendMessage(ChatColor.GREEN + "Banned Blocks:");
            player.sendMessage(ChatColor.RED + "TNT");
            player.sendMessage(ChatColor.RED + "Bedrock");
            return true;
 
        }
 
 
    return false;   
 
 
    }       
 
 
 
 
 
}

Code:java

package me.phoenix;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockPlaceEvent;
 
 
public class antiblock implements Listener {
 
 
 
    public antiblock(BlockListener plugin) {
    plugin.getServer().getPluginManager().registerEvents(this, plugin);
 
 
    }
 
 
 
 
  @EventHandler
  public void onBlockPlace(BlockPlaceEvent e) {
 
      Player player = e.getPlayer();
 
      if (e.getBlock().getType() == Material.BEDROCK) {
          if (!player.hasPermission("place.blockedbedrock")) {
              e.setCancelled(true);
              player.sendMessage(ChatColor.RED + "Sorry, but you lack permission to place " + ChatColor.BLUE + ChatColor.BOLD + e.getBlock().getType().toString());
          }
 
      if (e.getBlock().getType() == Material.TNT) {
          if (!player.hasPermission("place.blockedtnt")) {
              e.setCancelled(true);
          }
      }
 
      }
 
  }
 
}
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

I'd like it to block Bedrocks and TNTs. The Bedrock code seems working, it blocks TNT just like I want it to, but not TNTs. What have I done wrong?

Thanks

 

WingsofPhoenix From looking at your classes, I believe you haven't initialised your listener class properly.
1. In the onEnable method of your main class, add:

Code:java

PluginManager pm = getServer().getPluginManager();
pm.registerEvents(this.antiblock, this);

and remove registerEvents in your antiblock class.
2. Add this in your main class:

Code:java

public static BlockListener getInstance() {
    return instance;
}
 

Add this:

Code:java

public Main plugin;
 
public PlayerListener(Main instance) {
    plugin = instance;
}
 

after 'public class antiblock implements Listener {' in your antiblock class.

That should be good for that, I may have missed something though. Just reply if it doesn't work!

 

I would say you failed at your question xD

besides that, do you want to block tnt-explosion or tnt-placing?

 

bombom3000

The listener is initialized properly. He's saying that it's working but there's something apparently not working right.
Also, what's the point of having a method that returns the instance of the class even though you're not even using it.
He's using a constructor to initialize his listener which will work..

What do you mean by that?
I don't understand.

 

Ahahah.. I was in a rush, apologies. What I meant to say is that the plugin blocks Bedrock (to players who lack the required permission) perfectly just like I expected, however, the same cannot be said for TNTs.

 

WingsofPhoenix so your method listens to a block placed event and if the blockmaterial is tnt you cancel the event. maybe tnt is not the right material? you dont know for sure that it is tnt, so why dont you add a System.out.println(materialname) to your method, reload the plugin and place a tnt? then you can see what material tnt is made of. or send a message to your player if there are more player online while you're tring this and only send the message if you're the player who placed the block. you know what i mean? print out what happens if you place tnt and afterwards you know to what you've to listen

 

Your realise griefers will most likely be op when they grief, so they will have permission to place bedrock and tnt.

 

Cyber_Pigeon but then they also would be able to place bedrock and they couldn't as they said

 

Thanks for the help. I'll try all these methods and see which works best.

The purpose of me making this plugin is to only prevent normal players from placing these banned blocks. The only OPs are my trusted ones, a few of my friends I do know, not the guys I pick randomly online.

I seem to have got it working. I retyped the whole antiblock class and it seemed to work now. Probably some errors with the bodies. Thank you, everyone, for trying to help me solve this!

And if any of you are having the same problem, here's the code:

Code:java

package me.phoenix;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockPlaceEvent;
import org.bukkit.material.MaterialData;
 
 
public class antiblock implements Listener {
 
 
    public antiblock(BlockListener plugin) {
    plugin.getServer().getPluginManager().registerEvents(this, plugin);
 
 
    }
 
 
    @EventHandler
    public void onBlockPlace(BlockPlaceEvent e) {
 
        Player player = e.getPlayer();
 
        if (e.getBlock().getType() == Material.BEDROCK) {
            if (!player.hasPermission("place.blockedbedrock")) {
                e.setCancelled(true);
                player.sendMessage(ChatColor.RED + "You may not place " + ChatColor.BLUE + ChatColor.BOLD + e.getBlock().getType());
                player.sendMessage(ChatColor.GREEN + "Please type in " + ChatColor.BLUE + ChatColor.BOLD + "/bannedblocks " + ChatColor.GREEN + "To see a full list of banned blocks");
 
            }
 
    }
 
        if (e.getBlock().getType() == Material.TNT) {
            if (!player.hasPermission("place.blockedtnt")) {
                e.setCancelled(true);
                player.sendMessage(ChatColor.RED + "You may not place " + ChatColor.BLUE + ChatColor.BOLD + e.getBlock().getType());
                player.sendMessage(ChatColor.GREEN + "Please type in " + ChatColor.BLUE + ChatColor.BOLD + "/bannedblocks " + ChatColor.GREEN + "To see a full list of banned blocks");
 
            }
        }
 
    }
 
 
 
 
}
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Thanks

EDIT by Moderator: merged posts, please use the edit button instead of double posting.