Solved [NMS] Custom Entity Not Working for manually spawned mobs

Hey bukkit! So I have a custom entity that I have already created using NMS code

Code:java

public class CustomEntityPig extends EntityPig{
 
public CustomEntityPig(World world) {
super(world);
}
 
@Override
public void aD(){
double speed = 5.3D;
super.aD();
this.getAttributeInstance(GenericAttributes.d).setValue(speed);
}
@Override
public void e(float sideMot, float forMot) {
if (this.passenger == null || !(this.passenger instanceof EntityHuman)) {
super.e(sideMot, forMot);
this.X = 0.5F;
return;
}
 
EntityHuman human = (EntityHuman) this.passenger;
if (human.getBukkitEntity() != Bukkit.getPlayerExact("MoeMix").getPlayer()) {
// Same as before
super.e(sideMot, forMot);
this.X = 0.5F;
return;
}
 
this.lastYaw = this.yaw = this.passenger.yaw;
this.pitch = this.passenger.pitch * 0.5F;
 
this.b(this.yaw, this.pitch);
this.aP = this.aN = this.yaw;
 
this.X = 1.0F;
 
sideMot = ((EntityLiving) this.passenger).be * 0.5F;
forMot = ((EntityLiving) this.passenger).bf;
 
if (forMot <= 0.0F) {
forMot *= 0.25F;
}
sideMot *= 0.75F;
 
float speed = 0.35F;
this.i(speed);
super.e(sideMot, forMot);
 
}
 
 
}
 

I have also created a method to spawn my entity and I used it in my onEnable(). Therefore, the entities are registered....

Code:java

public static void registerEntities() {
for (CustomMobs entity : values())
a(entity.getCustomClass(), entity.getName(), entity.getID());
 
 
BiomeBase[] biomes;
try {
biomes = (BiomeBase[]) getPrivateStatic(BiomeBase.class, "biomes");
} catch (Exception exc) {
 
return;
}
for (BiomeBase biomeBase : biomes) {
if (biomeBase == null)
break;
 
 
for (String field : new String[] { "as", "at", "au", "av" })
try {
Field list = BiomeBase.class.getDeclaredField(field);
list.setAccessible(true);
@SuppressWarnings("unchecked")
List<BiomeMeta> mobList = (List<BiomeMeta>) list.get(biomeBase);
 
 
for (BiomeMeta meta : mobList)
for (CustomMobs entity : values())
if (entity.getNMSClass().equals(meta.b))
meta.b = entity.getCustomClass();
} catch (Exception e) {
e.printStackTrace();
}
}
}

This code works! However, it only works for naturally spawned entities. If I did /spawnmob pig 1, my custom class would not work for it. I only modified speed for my entity. Someone please HALP!

 

MoeMix Of course if you spawned a chicken it wouldn't work... You extended the custom entity to be a pig. Unless pigs are now chickens, and minecraft just took a major plot twist...

 

ShadowLAX actually I meant to say pig haha. Fixed it.

 

MoeMix Try overriding the spawning of a natural entity with the command and spawn your custom entity instead.

 

What's the NMS code for spawning an entity?

 

MoeMix

Code:java

//p is net.minecraft.server.v1.7_R1.EntityHuman import,
p.getWorld().addEntity(new CustomEntityPig(p.getWorld()).setLocation(x,y,z,yaw,pitch);

 

ShadowLAX would that go in my onEnable or in my registerEntities() method?

 

MoeMix Neither. It's for overriding a command that is supposed to spawn a regular pig. So, back to your example: Say someone did /spawnmob. You would have to make a onCommand() that has the @Override annotation, and spawn the custom entity instead.

 

ShadowLAX I'm having trouble with the last part. The setLocation part. How do I get the location of the EntityHuman?

 

Easy way would be human.getBukkitEntity().getLocation().

 

MoeMix Use this instead, I noticed an error using what I gave you;

Code:java

   //p is net.minecraft.server.v1.7_R1.EntityHuman import,
CustomEntityPig custompig = new CustomEntityPig(p.getWorld());
    p.getWorld().addEntity(custompig);
    customz.setPosition(p.locX, p.locY, p.locZ);

 

lol where did you get that customz?

should it be custompig? seems reasonable

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

MoeMix Sorry, my bad; Forgot to change the variable there. Just change it to custompig.

 

ShadowLAX Garris0n ok last part, is there a possible way to just set all the naturally spawnned mobs to use my custom class?

 

All mobs, or all mobs of the type you register it as? If you mean all mobs, listen to the CreatureSpawnEvent and cancel then spawn your mob.

 

ShadowLAX Garris0n For the variable "p" how did you import it?
I already have this in my imports:

Code:java

import net.minecraft.server.v1_7_R1.EntityHuman;

 

He intended that to be a player EntityHuman. It could be any location and world you like.

 

Ok then how would I get it? Like when I want to add the entity I have to do world.addEntity(blahblahblah) but how do I get that "world"?

 

The world has to be an NMS world. It can be retrieved like this:

Code:java

(nmsworldpackage).World world = ((CraftWorld) bukkitWorld).getHandle();

The 'p' variable he was using was supposed to be an EntityHuman, as he specified. (Ignore my last post).

 

Garris0n is bukkitWorld org.bukkit.World? I'm getting errors with that

 

Yes, bukkitWorld is a bukkit world.

 

Garris0n@ShadowLAX, I'm getting errors in line 4.... it's a red underline under org.bukkit.world

Code:java

 @EventHandler
public void spawn(CreatureSpawnEvent e){
e.setCancelled(true);
net.minecraft.server.v1_7_R1.World world = ((CraftWorld) org.bukkit.World).getHandle();
CustomEntityPig custompig = new CustomEntityPig(world);
world.addEntity(custompig);
custompig.setPosition(e.getLocation().getX(), e.getLocation().getY(), e.getLocation().getZ());
 
}

 

MoeMix org.bukkit.World is not a variable, it is the type. You need an actual world variable there too...

 

oh so what should I set the variable equal to?

Code:java

org.bukkit.World w = ?

 

I don't know, what world are you spawning it in? I can't code the entire plugin for you, if I did it wouldn't be your plugin. You should understand some basic Java before using Bukkit, and quite a bit about Bukkit before using internal server code... will you know what to do next update when everything breaks?

 

Yeah, I'll just look at the classes and see which methods have been changed due to all the obfuscation. So I set the world to the world of the creature spawning. Thanks Garris0n for helping me out through all of this. I know it was long but you put up with all my questions ! Thanks again!

 

Did you find a way to spawn custom entities? I'm currently trying to figure that out after messing around with NMS

 

Yeah I have. Basically, define the bukkit world, then define the nms world using by casting the bukkit world to it. then spawn the entity in that nms world

 

The general "spawn procedure" is something like the following:

Code:

[nms package].World nmsWorld = ((CraftWorld) yourBukkitWorldHere).getHandle();
YourCustomEntityHere entity = new YourCustomEntityHere(nmsWorld, OtherArgumentsHere); //Generally you design your custom entity to accept an nms world to call the superconstructor.
entity.setPosition(PositionGoesHere);
nmsWorld.addEntity(entity, OptionalSpawnReason);