Need a hand with Vault

I'm trying to move a player to the group "Builder" via Vault if they aren't already in that group, but I cannot seem to get it to work. Does anyone have any experience with Vault? I'm puzzled.

Code:java

package com.gmail.mcheadgam3z.commands;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
import com.gmail.mcheadgam3z.misc.Handler;
 
public class Builder implements CommandExecutor {
 
    Handler h = new Handler();
 
    @SuppressWarnings("deprecation")
    public boolean onCommand(CommandSender cs, Command c, String s, String[] a) {
        if (c.getName().equalsIgnoreCase("builder")) {
            if (cs instanceof Player) {
                Player p = (Player) cs;
                if (p.hasPermission("builder.cmd")) {
                    if (a.length == 1) {
                        Player target = Bukkit.getServer().getPlayer(a[0]);
                        if (target.hasPlayedBefore()) {
                            if (!(h.perms.playerInGroup(target, "Builder"))) {
                                h.perms.playerAddGroup(target, "Builder");
                                p.sendMessage("yey");
                                return true;
                            }
                            return false;
                            // already in group.
                        }
                        // never joined the server
                        return false;
                    }
                    // invalid syntax
                    return false;
                }
                // no perms
                return false;
            }
            // not a player
            return false;
        }
        return false;
    }
 
    /*private String getString(String s) {
        return Main.plugin.getConfig().getString(s);
    }*/
 
}
 

Oh, and here's the stack trace:

Code:

org.bukkit.command.CommandException: Unhandled exception executing command 'builder' in plugin Builder v1.0.0
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:180) ~[bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at org.bukkit.craftbukkit.v1_7_R3.CraftServer.dispatchCommand(CraftServer.java:701) ~[bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.PlayerConnection.handleCommand(PlayerConnection.java:956) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.PlayerConnection.a(PlayerConnection.java:817) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.PacketPlayInChat.a(PacketPlayInChat.java:28) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.PacketPlayInChat.handle(PacketPlayInChat.java:47) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.NetworkManager.a(NetworkManager.java:157) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.ServerConnection.c(SourceFile:134) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:667) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
Caused by: java.lang.NullPointerException
    at com.gmail.mcheadgam3z.commands.Builder.onCommand(Builder.java:24) ~[?:?]
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[bukkit.jar:git-Bukkit-1.7.9-R0.1-b3084jnks]
    ... 13 more

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You're getting an NPE at line 24, no idea why. Not experienced with Vault & Permissions.

 

HeadGam3z paste handler class.

 

TheMcScavenger
Yeah, I know, it's weird.

Necrodoom
One sec.

 

HeadGam3z perms is null, because you create a new handler instance, which did not have setupPlugin() called.

Did you want to pass the one from main class instead?

 

Necrodoom
I just noticed that it was null as I was posting it, haha. And yeah, I was gonna pass the one from the main class, but I need to read up on how to do that efficiently.

Also, I rearranged a few things and did some debug messages.
Code:

Code:java

package com.gmail.mcheadgam3z.builder;
 
import net.milkbowl.vault.permission.Permission;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    public static Plugin plugin;
 
    public Permission perms = null;
 
    private boolean setupPermissions() {
        RegisteredServiceProvider<Permission> rsp = Main.plugin.getServer().getServicesManager().getRegistration(Permission.class);
        perms = rsp.getProvider();
        return perms != null;
    }
 
    public void onEnable() {
        plugin = this;
        setupPermissions();   
    }
 
    @SuppressWarnings("deprecation")
    public boolean onCommand(CommandSender cs, Command c, String s, String[] a) {
        if (c.getName().equalsIgnoreCase("builder")) {
            if (cs instanceof Player) {
                d("2");
                Player p = (Player) cs;
                if (p.hasPermission("builder.cmd")) {
                    d("3");
                    if (a.length == 1) {
                        d("4");
                        Player target = Bukkit.getServer().getPlayer(a[0]);
                        if (target.hasPlayedBefore()) {
                            d("5");
                            if (!(perms.playerInGroup(target, "Builder"))) {
                                d("6");
                                perms.playerAddGroup(target, "Builder");
                                d("7");
                                p.sendMessage("yey");
                                return true;
                            }
                            d("-6");
                            return false;
                            // already in group.
                        }
                        d("-5");
                        // never joined the server
                        return false;
                    }
                    d("-4");
                    // invalid syntax
                    return false;
                }
                d("-3");
                // no perms
                return false;
            }
            d("-2");
            // not a player
            return false;
        }
        return false;
    }
 
    private void d(String s) {
        System.out.println(s);
    }
 
}
 

The numbers 2-5 are printing, which is good, but then I got -6 to paste, which isn't good because I am not in the group "Builder". Any suggestions?

 

HeadGam3z seems to venture to vault API territory, but try list permission plugin and make sure you are really not in builder group.

 

Necrodoom
Already have. In no way am I in builder, unfortunately.