Solved MySQL data efficiency?

So right now I have a working MySQL system for a network. The problem is, a player with the highest rank(owner) has a chat delay of about 1.5 seconds due to the plugin having to retrieve the data, parse it, then check it on chat. I'm sure there's a way to make this more efficient. (By the way, this is my first attempt at using MySQL in a real interface.)

Chat:

Code:java

 @EventHandler
public void chatHandler(AsyncPlayerChatEvent e) {
Player p = e.getPlayer();
if(Rank.getRank(p) == Rank.DEFAULT) {
e.setFormat(ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.VIP) {
e.setFormat(ChatColor.GOLD.toString() + ChatColor.BOLD + "VIP " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage() + "");
} else if(Rank.getRank(p) == Rank.BUILDER) {
e.setFormat(ChatColor.BLUE.toString() + ChatColor.BOLD + "BUILDER " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage() + "");
} else if(Rank.getRank(p) == Rank.HELPER) {
e.setFormat(ChatColor.DARK_GRAY.toString() + ChatColor.BOLD + "HELPER " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.MOD) {
e.setFormat(ChatColor.DARK_GREEN.toString() + ChatColor.BOLD + "MOD " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.DEV) {
e.setFormat(ChatColor.DARK_PURPLE.toString() + ChatColor.BOLD + "DEV " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.ADMIN){
e.setFormat(ChatColor.DARK_RED.toString() + ChatColor.BOLD + "ADMIN " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.OWNER){
e.setFormat(ChatColor.RED.toString() + ChatColor.BOLD + "OWNER " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
}

Getting the rank:

Code:java

public static Rank getRank(Player p) {
ResultSet res = null;
try {
res = Main.statement.executeQuery("SELECT rank FROM test WHERE uuid='" + p.getUniqueId() + "';");
res.next();
} catch (SQLException e) {
e.printStackTrace();
}
try {
if(res.getString("rank").equals("DEFAULT")) {
return DEFAULT;
} else if(res.getString("rank").equals("VIP")) {
return VIP;
} else if(res.getString("rank").equals("BUILDER")) {
return BUILDER;
} else if(res.getString("rank").equals("HELPER")) {
return HELPER;
} else if(res.getString("rank").equals("MOD")) {
return MOD;
} else if(res.getString("rank").equals("DEV")) {
return DEV;
} else if(res.getString("rank").equals("ADMIN")) {
return ADMIN;
} else if(res.getString("rank").equals("OWNER")) {
return OWNER;
}
} catch (SQLException e) {
e.printStackTrace();
}
return null;
}

 

Why in Minecraft's sake aren't you caching this data?

 

WesJD Load the data into some kind of Map.

 

*Not really relevant but it kinda bothers me*, Optimizing:

Show Spoiler Hide Spoiler

Code:java

 @EventHandler
public void chatHandler(AsyncPlayerChatEvent e) {
Player p = e.getPlayer();
if(Rank.getRank(p) == Rank.DEFAULT) {
e.setFormat(ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.VIP) {
e.setFormat(ChatColor.GOLD.toString() + ChatColor.BOLD + "VIP " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage() + "");
} else if(Rank.getRank(p) == Rank.BUILDER) {
e.setFormat(ChatColor.BLUE.toString() + ChatColor.BOLD + "BUILDER " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage() + "");
} else if(Rank.getRank(p) == Rank.HELPER) {
e.setFormat(ChatColor.DARK_GRAY.toString() + ChatColor.BOLD + "HELPER " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.MOD) {
e.setFormat(ChatColor.DARK_GREEN.toString() + ChatColor.BOLD + "MOD " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.DEV) {
e.setFormat(ChatColor.DARK_PURPLE.toString() + ChatColor.BOLD + "DEV " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.ADMIN){
e.setFormat(ChatColor.DARK_RED.toString() + ChatColor.BOLD + "ADMIN " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else if(Rank.getRank(p) == Rank.OWNER){
e.setFormat(ChatColor.RED.toString() + ChatColor.BOLD + "OWNER " + ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
}

to

Code:java

 @EventHandler
public void chatHandler(AsyncPlayerChatEvent e) {
Player p = e.getPlayer();
Rank r = Rank.getRank(p);
if(r == Rank.DEFAULT) {
e.setFormat(ChatColor.GRAY + p.getDisplayName() + "" + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
} else {
e.setFormat(ChatColor.GOLD + ChatColor.BOLD + r.name().toUpperCase() + ChatColor.GRAY + p.getDisplayName() + ChatColor.DARK_GRAY + ": " + ChatColor.RESET + e.getMessage());
}

and (I know we shouldn't provide Code as complete thing, but I added a description to every Important part): [/spoiler]
2nd:

Show Spoiler Hide Spoiler

Code:java

public static Rank getRank(Player p) {
Connection connection = null; // Get your Connection here.
String r = "";
try {
PreparedStatement stmt = connection.prepareStatement("SELECT rank FROM test WHERE uuid=?;");
// Use PreparedStatements because they are faster and more efficient than
// when you're using Variables in your Request/Statement
stmt.setString(1, p.getUniqueId().toString());
// "Replaces" the first '?' in the Request with the UUID
// This is made so it works better with Variables
ResultSet res = stmt.executeQuery();
if (!res.next()) { // Welp, there's no Data. Stop dis nao
res.close();
stmt.close();
return null;
}
r = res.getString("rank");
} catch (SQLException e) {
e.printStackTrace();
return null; // Stop here, you got a Error
}
try {
return Rank.valueOf(r);
} catch (Exception e) {
e.printStackTrace();
return null; // Couldn't parse it, because it's not a Rank.
}
}

 

PreFiXAUT the first 'optimalisation' isn't actually correct, he has different ChatColors for different ranks (though, he could store that in the Rank enum, and make that work). Secondly, never catch Exception (unless some noob *cough* Essentials *cough* throws Exception and you have no other option) or when you just want to propagate the error in a wrapper

Code:java

try
{
    // Some exceptional code
} 
catch(Exception ex)
{
    throw new SpecialExceptionWrapper(ex);
}

 

Really? Oh sorry didn't see that

Well catching Exception only, is nice IF you don't want/need to handle certain Exceptions differently. For example you have a Method which throws 5 Exceptions, it's nice to have different ones so you know what happend. But if you just want to stop the Command/(can't/don't want) to handle each Exception then catching only Exception is fine imo.

But anyway, seems that this works since the Title sais Solved.

 

PreFiXAUT quick side note though: it could hide exceptions which are harmful for the code (like a NullPointerException because you forgot to initialize a variable) ;3