Solved [MySQL] Client Crash When Right-Clicking Entity

Discussion in 'Plugin Development' started by krazytraynz, Jun 5, 2014.

Thread Status:
Not open for further replies.
  1. Offline

    krazytraynz

    I'm new to MySQL, so there could easily be a stupid mistake in here. I've been working at fixing this for 2 days, and the only progress I've made is getting less errors, but when I right click a chicken (only entity I'm testing for now) it crashes the client of everyone who's on the server. I'll post all the classes I think are relevant to this, but if I leave anything out let me know (and please ignore the terrible error handling).

    Error: http://pastebin.com/kHBQimXG

    Main:
    Code:java
    1. package com.gmail.oaplugins;
    2.  
    3. import java.lang.reflect.InvocationTargetException;
    4. import java.sql.Connection;
    5. import java.sql.PreparedStatement;
    6. import java.sql.SQLException;
    7. import java.sql.Statement;
    8. import java.util.UUID;
    9.  
    10. import net.minecraft.server.v1_7_R3.EntityInsentient;
    11.  
    12. import org.bukkit.Bukkit;
    13. import org.bukkit.Location;
    14. import org.bukkit.plugin.java.JavaPlugin;
    15.  
    16. public class PetBukkit extends JavaPlugin {
    17.  
    18.     static PetBukkit pb;
    19.  
    20.     private FoodRecipes fr;
    21.     private Tamer tamer;
    22.     MySQLUtils utils;
    23.  
    24.     boolean a = true;
    25.     String b = "";
    26.     String t = "";
    27.  
    28.     MySQL sql = null;
    29.     PreparedStatement ps;   
    30.     Connection c = null;
    31.     Statement s = null;
    32.  
    33.     public void onEnable(){
    34.         pb = this;
    35.         tamer = new Tamer();
    36.         utils = new MySQLUtils();
    37.         fr = new FoodRecipes();
    38.  
    39.         fr.chickenFood();
    40.         fr.cowFood();
    41.         fr.ocelotFood();
    42.         fr.pigFood();
    43.         fr.sheepFood();
    44.  
    45.         CustomEntityType.patch();
    46.  
    47.         ConfigurationLoader.load(this);
    48.  
    49.         getLogger().info("Initializing MySQL...");
    50.         String host = getConfig().getString("mysql.hostname");
    51.         String port = getConfig().getString("mysql.port");
    52.         String database = getConfig().getString("mysql.database");
    53.         String user = getConfig().getString("mysql.username");
    54.         String pass = getConfig().getString("mysql.password");
    55.         t = getConfig().getString("mysql.tablename");
    56.         sql = new MySQL(this, host, port, database, user, pass);
    57.         c = sql.openConnection();
    58.         String sqls = "CREATE TABLE IF NOT EXISTS " + t + " (pUUID VARCHAR(255) not NULL, eUUID VARCHAR(255) not NULL, PRIMARY KEY (pUUID))";
    59.         try {
    60.             s = sql.openConnection().createStatement();
    61.             s.execute(sqls);
    62.             ps = c.prepareStatement("INSERT INTO " + "'" + t + "'" + "('pUUID', 'eUUID') VALUES (?, ?);");
    63.         } catch (SQLException e) {
    64.             b = e.getMessage();
    65.             a = false;
    66.         }
    67.         if(!a){
    68.             getLogger().severe("ERROR INITIALIZING MYSQL: " + b + ". MAKE SURE CONFIG.YML IS PROPERLY CONFIGURED!");
    69.         }else{
    70.             getLogger().info("MySQL initialized!");
    71.         }
    72.  
    73.         Bukkit.getServer().getPluginManager().registerEvents(tamer, this);
    74.  
    75.         getLogger().info("PetBukkit has been enabled!");
    76.     }
    77.  
    78.     public void onDisable(){
    79.         getLogger().warning("PetBukkit has been disabled!");
    80.     }
    81.  
    82.     /**
    83.     * Spawn custom entities, 1 at a time and get their UUID
    84.     * @param entity - Custom entity to spawn
    85.     * @param loc - Location to spawn it at
    86.     * @param world - World to spawn it in
    87.     * @throws InstantiationException
    88.     * @throws IllegalAccessException
    89.     * @throws SecurityException
    90.     * @throws NoSuchMethodException
    91.     * @throws InvocationTargetException
    92.     * @throws IllegalArgumentException
    93.     */
    94.     public UUID spawnCustomEntity(CustomEntityType entity, Location loc, net.minecraft.server.v1_7_R3.World world) throws InstantiationException, IllegalAccessException, NoSuchMethodException, SecurityException, IllegalArgumentException, InvocationTargetException {
    95.         EntityInsentient e = (EntityInsentient)(entity.getCustomClass().getDeclaredConstructor(net.minecraft.server.v1_7_R3.World.class).newInstance(world));
    96.         e.setPosition(loc.getX(), loc.getY(), loc.getZ());
    97.  
    98.         world.addEntity(e);
    99.  
    100.         return e.getUniqueID();
    101.     }
    102. }


    Tamer.java:
    Code:java
    1. package com.gmail.oaplugins;
    2.  
    3. import java.lang.reflect.InvocationTargetException;
    4. import java.sql.SQLException;
    5. import java.util.UUID;
    6.  
    7. import org.bukkit.Bukkit;
    8. import org.bukkit.Location;
    9. import org.bukkit.World;
    10. import org.bukkit.craftbukkit.v1_7_R3.CraftWorld;
    11. import org.bukkit.craftbukkit.v1_7_R3.entity.CraftChicken;
    12. import org.bukkit.craftbukkit.v1_7_R3.entity.CraftCow;
    13. import org.bukkit.craftbukkit.v1_7_R3.entity.CraftOcelot;
    14. import org.bukkit.craftbukkit.v1_7_R3.entity.CraftPig;
    15. import org.bukkit.craftbukkit.v1_7_R3.entity.CraftSheep;
    16. import org.bukkit.entity.Entity;
    17. import org.bukkit.entity.EntityType;
    18. import org.bukkit.entity.Player;
    19. import org.bukkit.event.EventHandler;
    20. import org.bukkit.event.Listener;
    21. import org.bukkit.event.player.PlayerInteractEntityEvent;
    22. import org.bukkit.inventory.ItemStack;
    23.  
    24. public class Tamer implements Listener{
    25.  
    26.     @EventHandler
    27.     public void TameEntity(PlayerInteractEntityEvent e) throws InstantiationException, IllegalAccessException, NoSuchMethodException, SecurityException, IllegalArgumentException, InvocationTargetException{
    28.         Player p = e.getPlayer();
    29.         if(e.getRightClicked() != null){
    30.             if(p.getItemInHand() != null && p.getItemInHand().hasItemMeta()){
    31.                 ItemStack its = p.getItemInHand();
    32.                 String s = "";
    33.                 String name = its.getItemMeta().getDisplayName();
    34.                 if(name != null){
    35.                     s = name;
    36.                 }else{
    37.                     return;
    38.                 }
    39.  
    40.                 switch(s){
    41.                 case "Chicken Food":
    42.                     if(e.getRightClicked().getType() == EntityType.CHICKEN){
    43.                         World world = e.getRightClicked().getWorld();
    44.                         Location l = e.getRightClicked().getLocation();
    45.                         CraftWorld w = (CraftWorld)l.getWorld();
    46.                         e.getRightClicked().setTicksLived(Integer.MAX_VALUE);
    47.                         UUID uuid = PetBukkit.pb.spawnCustomEntity(CustomEntityType.CHICKEN, l, w.getHandle());
    48.                         Entity ent = getFromUUID(uuid, world);
    49.                         ((CraftChicken)ent).getHandle().setHealth(20);
    50.                         System.out.println(((CraftChicken)ent).getHandle().getHealth());
    51.                         Bukkit.getServer().getPluginManager().callEvent(new PlayerTameEntityEvent(p, ent));
    52.                     }       
    53.                     break; //Line 53
    54.                 case "Seeds":
    55.                     if(e.getRightClicked() instanceof CustomEntityChicken){
    56.                         ((CraftChicken)e.getRightClicked()).getHandle().heal(5);
    57.                     }
    58.                     break;
    59.  
    60.                     case "Cow Food":
    61.                         if(e.getRightClicked().getType() == EntityType.COW){
    62.                             Location l = e.getRightClicked().getLocation();
    63.                             CraftWorld w = (CraftWorld)l.getWorld();
    64.                             e.getRightClicked().setTicksLived(Integer.MAX_VALUE);
    65.                             UUID uuid = PetBukkit.pb.spawnCustomEntity(CustomEntityType.COW, l, w.getHandle());
    66.                             Entity ent = getFromUUID(uuid, e.getRightClicked().getWorld());
    67.                             ((CraftCow)ent).getHandle().setHealth(20);
    68.                             System.out.println(((CraftCow)ent).getHandle().getHealth());
    69.                             Bukkit.getServer().getPluginManager().callEvent(new PlayerTameEntityEvent(p, ent));
    70.                         }
    71.                         break;
    72.                     case "Milk":
    73.                         if(e.getRightClicked() instanceof CustomEntityCow){
    74.                             ((CraftCow)e.getRightClicked()).getHandle().heal(5);
    75.                         }
    76.                         break;
    77.  
    78.                     case "Ocelot Food":
    79.                         if(e.getRightClicked().getType() == EntityType.OCELOT){
    80.                             Location l = e.getRightClicked().getLocation();
    81.                             CraftWorld w = (CraftWorld)l.getWorld();
    82.                             e.getRightClicked().setTicksLived(Integer.MAX_VALUE);
    83.                             UUID uuid = PetBukkit.pb.spawnCustomEntity(CustomEntityType.OCELOT, l, w.getHandle());
    84.                             Entity ent = getFromUUID(uuid, e.getRightClicked().getWorld());
    85.                             ((CraftOcelot)ent).getHandle().setHealth(20);
    86.                             System.out.println(((CraftOcelot)ent).getHandle().getHealth());
    87.                             Bukkit.getServer().getPluginManager().callEvent(new PlayerTameEntityEvent(p, ent));
    88.                         }
    89.                         break;
    90.                     case "Cooked Fish":
    91.                         if(e.getRightClicked() instanceof CustomEntityOcelot){
    92.                             ((CraftOcelot)e.getRightClicked()).getHandle().heal(5);
    93.                             System.out.println(((CraftOcelot)e.getRightClicked()).getHandle().getHealth());
    94.                         }
    95.                         break;
    96.                         //
    97.                     case "Pig Food":
    98.                         if(e.getRightClicked().getType() == EntityType.PIG){
    99.                             Location l = e.getRightClicked().getLocation();
    100.                             CraftWorld w = (CraftWorld)l.getWorld();       
    101.                             e.getRightClicked().setTicksLived(Integer.MAX_VALUE);
    102.                             UUID uuid = PetBukkit.pb.spawnCustomEntity(CustomEntityType.PIG, l, w.getHandle());
    103.                             Entity ent = getFromUUID(uuid, e.getRightClicked().getWorld());
    104.                             Bukkit.getServer().getPluginManager().callEvent(new PlayerTameEntityEvent(p, ent));
    105.                         }
    106.                         break;
    107.                     case "Carrot":
    108.                         if(e.getRightClicked() instanceof CustomEntityPig){
    109.                             ((CraftPig)e.getRightClicked()).getHandle().heal(5);
    110.                         }
    111.                         break;
    112.  
    113.                     case "Sheep Food":
    114.                         if(e.getRightClicked().getType() == EntityType.SHEEP){
    115.                             Location l = e.getRightClicked().getLocation();
    116.                             CraftWorld w = (CraftWorld)l.getWorld();
    117.                             e.getRightClicked().setTicksLived(Integer.MAX_VALUE);
    118.                             UUID uuid = PetBukkit.pb.spawnCustomEntity(CustomEntityType.SHEEP, l, w.getHandle());
    119.                             Entity ent = getFromUUID(uuid, e.getRightClicked().getWorld());
    120.                             Bukkit.getServer().getPluginManager().callEvent(new PlayerTameEntityEvent(p, ent));
    121.                         }
    122.                         break;
    123.                     case "Cocoa Beans":
    124.                         if(e.getRightClicked() instanceof CustomEntitySheep){
    125.                             ((CraftSheep)e.getRightClicked()).getHandle().heal(5);
    126.                         }
    127.                         break;
    128.                 }
    129.                 return;
    130.             }
    131.             if(CustomEntityType.isCustomClass(e.getRightClicked().getType())){
    132.                 if(MySQLUtils.isProperPlayer(e.getRightClicked().getUniqueId(), e.getPlayer().getUniqueId())){
    133.                     e.getRightClicked().setPassenger(e.getPlayer());
    134.                 }
    135.             }
    136.         }
    137.     }
    138.  
    139.     @EventHandler
    140.     public void setValues(PlayerTameEntityEvent e){
    141.         try {
    142.             PetBukkit.pb.ps.setString(1, e.getPlayer().getUniqueId().toString());
    143.             PetBukkit.pb.ps.setString(2, e.getTamed().getUniqueId().toString());
    144.             PetBukkit.pb.ps.executeUpdate();
    145.         } catch (SQLException e1) {
    146.             e1.printStackTrace(); //Line 146
    147.         }
    148.     }
    149.  
    150.     public Entity getFromUUID(UUID uuid, World w){
    151.         Entity e = null;
    152.         for(Entity ent : w.getEntities()){
    153.             if(ent.getUniqueId().equals(uuid)){
    154.                 e = ent;
    155.             }
    156.         }
    157.         return e;
    158.     }
    159. }


    MySQLUtils.java:
    Code:java
    1. package com.gmail.oaplugins;
    2.  
    3. import java.sql.ResultSet;
    4. import java.sql.SQLException;
    5. import java.util.UUID;
    6.  
    7. public class MySQLUtils {
    8.  
    9.     /**
    10.     * Checks if UUID of entity belongs to the UUID of the player
    11.     * @param eUUID - UUID of the entity to try and match player with
    12.     * @param pUUId - UUID of the player to try and match entity with
    13.     * @return Whether or not it matches
    14.     */
    15.     public static boolean isProperPlayer(UUID eUUID, UUID pUUID){
    16.         try {
    17.             String db = PetBukkit.pb.getConfig().getString("mysql.database");
    18.             String t = PetBukkit.pb.t;
    19.             ResultSet rs = PetBukkit.pb.s.executeQuery("SELECT * FROM " + db + "WHERE" + t + " = '" + pUUID.toString() + "';");
    20.             rs.next();
    21.  
    22.             if(rs.getString("pUUID") == null){
    23.                 return false;
    24.             }else{
    25.                 String eString = rs.getString("eUUID");
    26.                 if(eUUID.toString().equals(eString)){
    27.                     return true;
    28.                 }else{
    29.                     return false;
    30.                 }
    31.             }
    32.         } catch (SQLException e) {
    33.             e.printStackTrace();
    34.         }
    35.         return false;
    36.     }
    37. }


    Bump

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: Jun 30, 2016
    krazytraynz, Jun 5, 2014
    #1
  2. Offline

    WhatAaCow

    krazytraynz in line 62
    Code:java
    1. ps = c.prepareStatement("INSERT INTO " + "'" + t + "'" + "('pUUID', 'eUUID') VALUES (?, ?);");
    there you use " ' " instead of " ´ " for table names....so try
    Code:java
    1. ps = c.prepareStatement("INSERT INTO " + "´" + t + "´" + "('pUUID', 'eUUID') VALUES (?, ?);");
     
    WhatAaCow, Jun 6, 2014
    #2
  3. Offline

    fireblast709

    krazytraynz you should be using backticks `` instead of apostrophes ''
     
    fireblast709, Jun 6, 2014
    #3
  4. Offline

    krazytraynz

    krazytraynz, Jun 6, 2014
    #4
  5. Offline

    fireblast709

    krazytraynz It's part of the general SQL syntax, thus it counts for every kind of SQL query you create.
     
    fireblast709, Jun 6, 2014
    #5
Thread Status:
Not open for further replies.

Share This Page