Solved My plugin doesn't work

Hi. I did plugin to bann the players who are OP but not in my list so I did
this: http://pastebin.com/iK09dKwW

The problem is that when I tried this plugin there is an error on this line : p.kickPlayer("Vous avez été banni");
It can't kick the player I don't know why, the bann and the deop work both but not the kick so the player can play until he disconnects.

 

Do you mind formatting the code.

 

@EloGamerr
Format your code. It will be easier to read.

This does not look like Bukkit's Scheduler. Unless you run this synchronously with the main thread, You cannot access bukkit's methods in an async thread. If this thread is async, use Bukkit's Scheduler to make it sync.

Instead of checking for something, and the letting it go to an else statement, You should invert the if statement and remove the else.

I can't image that your config would have a path such as "krlmp7EloGamerrfgths", because that looks too unintelligible and would need to be very specific for this to be right. Are you sure this is the correct path?

 

Yes, it's the correct path, I did this for more security, I have to put this letters every time before and after the name.

 

Why the heck would you do a scheduler? Just check on a join that; if a player is op; ban him:

Code:

@EventHandler
public void banJoinOP(PlayerJoinEvent e) {
 
          Player p = e.getPlayer();

           if(p.isOp()) {
           
           p.kickPlayer("Banni");
           
           p.setBanned(true);
     }
}

 

Then he could use PlayerLoginEvent; as shown in the code below:

Code:

    @EventHandler(priority = EventPriority.HIGH)
    public void join(PlayerLoginEvent event) {
                       
                          Player p = event.getPlayer();
                          if(p.isOp()) {

                    event.setKickMessage("Banni!");
                    event.setResult(PlayerLoginEvent.Result.KICK_BANNED);

                    }

        }

 

PlayerLoginEvent will ban every player that has op on joining the server. They won't even spawn.

 

How did that player bypass the login event since he's op in the first place?

 

Then check if he's op or has the permission bukkit.command.op ?

 

For the config :

Code:

Option:
  active: true
OP: krlmp7EloGamerr2fgths
    krlmp7EloGamerrfgths

I used Bukkit.Sheduler and I used if(getConfig().getStringList().contains(pn), now it works.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@ElieTGM
Even if you corss the permission out or even if you override the command entirely there is a way someone can give OP to someone else. For instance through code using player#setOP(true); or even if you overwrite that somehow, you can still access the method addOp in the NMS class Server and add ops.. In other words it is really hard to cross out all the possible ways a player can receive OP rights, thus the scheduler is a suitable solution. On the other hand, if the OP wanted to cross out the surface techniques of giving OP, they could do the PlayerJoinEvent check and also overwrite the Bukkit command class 'OpCommand' (possible through reflection) to perform their checks.