My command is not returning.

Well back with another problem for some reason my command is not returning the way its suppose to. I am making a custom currency plugin and i setup command so i can give and take my tokens.
But when i run the command it does nothing. Not even an error here is my code. Also anyone know how i can make it so i can send and take custom amounts? Example /sendcoins <amount> and it sends the amount or /takecoins <amount> so that it takes the amout of coins/tokens?

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        Player p = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("sendcoins")){
            MyAPI.givecoins(p, 100);
 
 
          }else{
              if(cmd.getName().equalsIgnoreCase("takecoins"));
              MyAPI.takecoins(p, 100);
 
              return true;
          }
        return false;
        }

Also included is my Api

Code:java

package me.ShadowWizard.VirtualShop;
 
import org.bukkit.entity.Player;
 
public class MyAPI{
 
    public static void givecoins(Player p, int i) {
        Main.config.set(p.getName() + ".coins",
                Main.config.getInt(p.getName() + ".coins", 0) + i);
        Main.saveFile();
        p.sendMessage("§6$" + i + " §7coins received!");
    }
 
    public static void takecoins(Player p, int i) {
        Main.config.set(p.getName() + ".coins",
                Main.config.getInt(p.getName() + ".coins", 0) - i);
        Main.saveFile();
        p.sendMessage("§6$" + i + " §7coins taken!");
    }
 
    public static boolean hasEnough(Player p, int i) {
        if (Main.config.getInt(p.getName() + ".coins") >= i)
            return true;
        return false;
    }
}

 

ShadowWizardMC
Are you doing the commands in a different class than the one that extends JavaPlugin?
Proper command structure when doing the command (directly from my plugin):

Code:java

public class CommandCreateCube implements CommandExecutor {
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
        if (!(sender instanceof Player)) {
            return false;
        }
 
        if (sender.isOp()) {
            if (args.length > 1 || args.length == 0) {
                sender.sendMessage(ChatColor.DARK_RED + "Usage: /createcube <map name>");
                return false;
            } else {
                String mapName = args[0];
                if (CubeGameManager.getInstance().getGame(mapName) != null) {
                    sender.sendMessage(ChatColor.DARK_RED + "Cube already Exists");
                    return false;
                } else {
                    CubeGameManager.getInstance().createGame(mapName);
                    sender.sendMessage(ChatColor.DARK_RED + "Created cube");
                    return false;
                }
            }
        } else {
            sender.sendMessage(ChatColor.DARK_RED + "You are not an Administrator.");
            return false;
        }
    }
 
}
 

Then on the onEnable:

Code:java

getCommand("createcube").setExecutor(new CommandCreateCube());

 

SuperOmegaCow
No the command is actually in my EventHandler class for a full code of my plugin go to these links:
My Main http://hastebin.com/bihiparati.avrasm
My Api: http://hastebin.com/fipovufedo.avrasm
My EventHandler: http://hastebin.com/mavemoxuvu.avrasm

Can you help me identify the problem?

 

ShadowWizardMC
Well let me explain how Commands work when using a different class. Firstly, you need to register the command and set the class that will receive the command. onEnable put: getCommand("YourCommand").setExecutor(new YourClass());
So YourClass is now the executor of the command YourCommand. So when a player types /YourCommand it goes to that class, meaning the only command that it will receive is YourCommand. So checking if the command is YourCommand is pointless since it will always be.
Now for multiple command use a different class for a different command.

 

Register your command like SuperOmegaCow said. And maybe you should use his code for the command

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
  Player p = (Player) sender;
 
  if(cmd.getName().equalsIgnoreCase("sendcoins")){
    MyAPI.givecoins(p, 100);   
    return true;
  }else if(cmd.getName().equalsIgnoreCase("takecoins")); // Instead of using } else { if() { use } else if() {
    MyAPI.takecoins(p, 100);
    return true;
  }
return false;
}

 

tomudding
When you set a class as the executor, you can't have multiple commands with the same onCommand executor.

 

SuperOmegaCow Who told you that? That is false.

 

Add in your CommandExecutor class:

PHP:

private PLUGINCLASS plugin;
public THISCLASS(PLUGINCLASS plugin){
  this.plugin = plugin;
}

Then register your command in the main class in the methode onEnable:

PHP:

getCommand("command").setExecutor(new CLASS(this));

 

Rocoty
When only setting one executor to that class it will only receive one command.

 

SuperOmegaCow You can assign multiple commands to the same executor

 

Rocoty SuperOmegaCow HungerCraftNL tomudding
Thank you for your suggestions i will this right now, I just woke up.