My Bungee Server Menu Makes Lag

Discussion in 'Plugin Development' started by Krumb069, Jul 11, 2016.

Thread Status:
Not open for further replies.
  1. Offline

    Krumb069

    I made a plugin that sorts and shows servers in a menu for server. It has around 60 servers in bungee. It sends ping to 15 of them every 2,5 seconds, at 10. second it updates menu. So it completes updating 60 server in 10 seconds but while updating them it creates huge lag. Server freezes for 3-4 seconds. Server is 1.7.10 so I use this class to ping servers. Here is the class:

    Code:
    import java.io.ByteArrayOutputStream;
    import java.io.DataInputStream;
    import java.io.DataOutputStream;
    import java.io.IOException;
    import java.io.InputStream;
    import java.io.InputStreamReader;
    import java.io.OutputStream;
    import java.net.InetSocketAddress;
    import java.net.Socket;
    import java.util.List;
    
    import org.bukkit.craftbukkit.libs.com.google.gson.Gson;
    
    public class ServerListPing17 {
        
    private InetSocketAddress host;
    private int timeout = 7000;
    private Gson gson = new Gson();
    public void setAddress(InetSocketAddress host) {
    this.host = host;
    }
    public InetSocketAddress getAddress() {
    return this.host;
    }
    void setTimeout(int timeout) {
    this.timeout = timeout;
    }
    int getTimeout() {
    return this.timeout;
    }
    public int readVarInt(DataInputStream in) throws IOException {
    int i = 0;
    int j = 0;
    while (true) {
    int k = in.readByte();
    i |= (k & 0x7F) << j++ * 7;
    if (j > 5) throw new RuntimeException("VarInt too big");
    if ((k & 0x80) != 128) break;
    }
    return i;
    }
    public void writeVarInt(DataOutputStream out, int paramInt) throws IOException {
    while (true) {
    if ((paramInt & 0xFFFFFF80) == 0) {
    out.writeByte(paramInt);
    return;
    }
    out.writeByte(paramInt & 0x7F | 0x80);
    paramInt >>>= 7;
    }
    }
    @SuppressWarnings("resource")
    public StatusResponse fetchData() throws IOException {
    Socket socket = new Socket();
    OutputStream outputStream;
    DataOutputStream dataOutputStream;
    InputStream inputStream;
    InputStreamReader inputStreamReader;
    socket.setSoTimeout(this.timeout);
    socket.connect(host, timeout);
    outputStream = socket.getOutputStream();
    dataOutputStream = new DataOutputStream(outputStream);
    inputStream = socket.getInputStream();
    inputStreamReader = new InputStreamReader(inputStream);
    ByteArrayOutputStream b = new ByteArrayOutputStream();
    DataOutputStream handshake = new DataOutputStream(b);
    handshake.writeByte(0x00); //packet id for handshake
    writeVarInt(handshake, 4); //protocol version
    writeVarInt(handshake, this.host.getHostString().length()); //host length
    handshake.writeBytes(this.host.getHostString()); //host string
    handshake.writeShort(host.getPort()); //port
    writeVarInt(handshake, 1); //state (1 for handshake)
    writeVarInt(dataOutputStream, b.size()); //prepend size
    dataOutputStream.write(b.toByteArray()); //write handshake packet
    dataOutputStream.writeByte(0x01); //size is only 1
    dataOutputStream.writeByte(0x00); //packet id for ping
    DataInputStream dataInputStream = new DataInputStream(inputStream);
    @SuppressWarnings("unused")
    int size = readVarInt(dataInputStream); //size of packet
    int id = readVarInt(dataInputStream); //packet id
    if (id == -1) {
    throw new IOException("Premature end of stream.");
    }
    if (id != 0x00) { //we want a status response
    throw new IOException("Invalid packetID");
    }
    int length = readVarInt(dataInputStream); //length of json string
    if (length == -1) {
    throw new IOException("Premature end of stream.");
    }
    if (length == 0) {
    throw new IOException("Invalid string length.");
    }
    byte[] in = new byte[length];
    dataInputStream.readFully(in); //read json string
    String json = new String(in);
    long now = System.currentTimeMillis();
    dataOutputStream.writeByte(0x09); //size of packet
    dataOutputStream.writeByte(0x01); //0x01 for ping
    dataOutputStream.writeLong(now); //time!?
    readVarInt(dataInputStream);
    id = readVarInt(dataInputStream);
    if (id == -1) {
    throw new IOException("Premature end of stream.");
    }
    if (id != 0x01) {
    throw new IOException("Invalid packetID");
    }
    long pingtime = dataInputStream.readLong(); //read response
    StatusResponse response = gson.fromJson(json, StatusResponse.class);
    response.setTime((int) (now - pingtime));
    dataOutputStream.close();
    outputStream.close();
    inputStreamReader.close();
    inputStream.close();
    socket.close();
    return response;
    }
    public class StatusResponse {
    private String description;
    private Players players;
    private Version version;
    private String favicon;
    private int time;
    public String getDescription() {
    return description;
    }
    public Players getPlayers() {
    return players;
    }
    public Version getVersion() {
    return version;
    }
    public String getFavicon() {
    return favicon;
    }
    public int getTime() {
    return time;
    }
    public void setTime(int time) {
    this.time = time;
    }
    }
    public class Players {
    private int max;
    private int online;
    private List<Player> sample;
    public int getMax() {
    return max;
    }
    public int getOnline() {
    return online;
    }
    public List<Player> getSample() {
    return sample;
    }
    }
    public class Player {
    private String name;
    private String id;
    public String getName() {
    return name;
    }
    public String getId() {
    return id;
    }
    }
    public class Version {
    private String name;
    private String protocol;
    public String getName() {
    return name;
    }
    public String getProtocol() {
    return protocol;
    }
    }
    }
    
    
    Do you have a better method for pinging servers and taking motd ?
     
  2. Offline

    bwfcwalshy Retired Staff

    @Krumb069 Bungeecord forces servers into offline mode which is not supported here.
     
    SuperSniper likes this.
  3. Offline

    Krumb069

    @bwfcwalshy
    But this isn't about bungeecord. The laggy part is pinging servers
     
    Last edited: Jul 11, 2016
  4. Offline

    MisterErwin

    @Krumb069 Just don't do it on your main thread? And not all at the same time.

    And you are using BungeeCord, which requires your server(s) to be in offline mode. So it is not supported
     
Thread Status:
Not open for further replies.

Share This Page