Multiple Commands. Need help.

So it seems like it is impossible to find any good tutorials on this or the 7th Wonder Of The World, CommandExecutor. I want to be able to make my commands go into their own, nice little class, but they are bad students. :3 I've got a heal command and a teleport to player command. How, in the name of Notch, do I do this?

P.S. Do I even need the Block and Player Listeners?!

 

Make the class implement CommandExectuor and I'm not sure if it's necessary, but in the onEnable() of your main, do this:
getServer().getPluginCommand("<CommandName>").setExecutor(new <ClassName>());

 

http://wiki.bukkit.org/Plugin_Tutorial#Using_a_separate_CommandExecutor_class

 

What about these errors? They don't recognize args or commandLabel, aswell as other errors.

Here is the SuperpowersCommandExecutor class (Superpowers is the plugin's name :3):

Code:

package me.TheLazeboy.superpowers;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class SuperpowersCommandExecutor implements CommandExecutor {
 
    private Superpowers plugin; // pointer to your main class, unrequired if you don't need methods from the main class
 
    public SuperpowersCommandExecutor(Superpowers plugin) {
        this.plugin = plugin;
    }
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // implementation exactly as before...
    }
        Player player = (Player) sender;
        if(commandLabel.equalsIgnoreCase("heal") | commandLabel.equalsIgnoreCase("spheal")){
            if(args.length == 0){
                player.setHealth(20);
                player.setFireTicks(0);
                player.setFoodLevel(20);
                player.sendMessage(ChatColor.GREEN + "Healed!");
            }else if(args.length == 1){
                if(player.getServer().getPlayer(args [0]) !=null){
                Player targetPlayer = player.getServer().getPlayer(args [0]);
                targetPlayer.setHealth(20);
                targetPlayer.setFireTicks(0);
                targetPlayer.setFoodLevel(20);
                player.sendMessage(ChatColor.GREEN + "Healed!");
                }else{
                    player.sendMessage(ChatColor.RED + "Player is not online!");
                }}else if(commandLabel.equalsIgnoreCase("tp") | commandLabel.equalsIgnoreCase("sptp")){
                if(args.length == 0){
                    player.sendMessage(ChatColor.RED + "Too little arguments!");
                }else if(args.length == 1){
                    Player targetPlayer = player.getServer().getPlayer(args[0]);
                    Location targetPlayerLocation = targetPlayer.getLocation();
                    player.teleport(targetPlayerLocation);
                }else if(args.length == 2){
                    Player targetPlayer = player.getServer().getPlayer(args[0]);
                    Player targetPlayer1 = player.getServer().getPlayer(args[1]);
                    Location targetPlayer1Location = targetPlayer1.getLocation();
                    targetPlayer.teleport(targetPlayer1Location);
                    targetPlayer.sendMessage(ChatColor.GREEN + "You have been to teleported to " + player.getName());
    }
 
}
}
}}

 

In the onCommand, you have it as label, then try to use commandLabel.

Change it to this:

Show Spoiler Hide Spoiler

Code:java

package me.TheLazeboy.superpowers;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class SuperpowersCommandExecutor implements CommandExecutor {
 
private Superpowers plugin; // pointer to your main class, unrequired if you don't need methods from the main class
 
public SuperpowersCommandExecutor(Superpowers plugin) {
this.plugin = plugin;
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
// Fixed to correct implementation
}
Player player = (Player) sender;
if(commandLabel.equalsIgnoreCase("heal") | commandLabel.equalsIgnoreCase("spheal")){
if(args.length == 0){
player.setHealth(20);
player.setFireTicks(0);
player.setFoodLevel(20);
player.sendMessage(ChatColor.GREEN + "Healed!");
}else if(args.length == 1){
if(player.getServer().getPlayer(args [0]) !=null){
Player targetPlayer = player.getServer().getPlayer(args[0]);
targetPlayer.setHealth(20);
targetPlayer.setFireTicks(0);
targetPlayer.setFoodLevel(20);
player.sendMessage(ChatColor.GREEN + "Healed!");
}else{
player.sendMessage(ChatColor.RED + "Player is not online!");
}}else if(commandLabel.equalsIgnoreCase("tp") | commandLabel.equalsIgnoreCase("sptp")){
if(args.length == 0){
player.sendMessage(ChatColor.RED + "Too little arguments!");
}else if(args.length == 1){
Player targetPlayer = player.getServer().getPlayer(args[0]);
Location targetPlayerLocation = targetPlayer.getLocation();
player.teleport(targetPlayerLocation);
}else if(args.length == 2){
Player targetPlayer = player.getServer().getPlayer(args[0]);
Player targetPlayer1 = player.getServer().getPlayer(args[1]);
Location targetPlayer1Location = targetPlayer1.getLocation();
targetPlayer.teleport(targetPlayer1Location);
targetPlayer.sendMessage(ChatColor.GREEN + "You have been to teleported to " + player.getName());
}
 
}
}
}}
 

 

I still have these errors; the args, sender, and the second commandLabel. Using your code. :/

 

You dont have the commands inside the onCommad() method.
Where you have the //implementsion as before, theres the place you need to have the commands in.

 

Oh lol. Thanks, but I sill have the commandLabel issues in each of my command methods.

 

TheLazeboy
Where you check if the command is ("heal") | ("spheal") try use 2 | between them.

 

But I'm trying to alternate what the play can type to achieve the same command. But I will try if I get any errors.

EDIT:
The commandLabel errors are still the same. And I took out the extra | you suggested for the commands.

 

OR gates use || (twice the |). Also, the code gomeow sent contains an error. Change all the 'commandLabel' for 'label'

 

Yes, i know.
|| = or

I dont see any problems that will make this error.

+ itsnot inside the onCommand block

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Okay so what is it exactly I need to do? Here is the current code for the Command Executor class, http://pastebin.com/tCW44qr4 .

 

Well, i dont see any errors. Should work..

 

fireblast709 bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

TheLazeboy

 

So what you are saying is change commandLabel to commandlabel. That is the only thing I think you could be telling me. Elaborate.

 

no change 'commandLabel' to 'label'

 

No errors in the code, but the console does. Does it have to do with the Main class code? http://pastebin.com/DjdFX2WA

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

whats the error in console?

 

you've got something wrong inside your plugin.yml.

 

http://pastebin.com/M4fmGXNY

 

ok so here is the best was i can explain this.

Where it says "main:" everything has to be EXACTLY how it shows in your plugin

Example:

Code:

package testPlugin;
 
public class testMain extends JavaPlugin implements Listener{

from there i see that "testPlugin" is the package i am in, and "testMain" is my class name.

now in my plugin.yml i would put

Code:

main: testPlugin.testMain

see how it says "testPlugin.testMain"?

this is case sensitive so remember that.

now in your plugin.yml you need to put your packagename then your MAIN class name

*EDIT*

your plugin.yml would read like this

Code:

name: Superpowers
main: me.TheLazeboy.superpowers.SuperpowersCommandExecutor
version: 0.3
description: >
             Heroes in Minecraft!
commands:
  heal:
    description: Heals a player.
  spheal:
    description: Heals a player.
  tp:
    description: Teleports to a player.
  sptp:
    description: Teleports to a player.

 

I changed my "main: ... "to what you said, but I still have a console error. And as I also stated in the original post,

I don't have the listener classes, I found them useless and removed them.

 

unless you plan on using these events/classes they are useless.

and what console error do you have now?

 

that is your CommandExecutor class. The plugin.yml's main value should point to the class that extends JavaPlugin (aka the main class)

 

Okay, it all ended well when I changed the plugin.yml's main to what I knew it should have been.