Message sending more than once.

Firstly, listener:

Code:java

@EventHandler
    public void onPlayerDeath(EntityDamageByEntityEvent e) {
        if (e.getEntity() instanceof Player) {
            if (e.getEntity().getLastDamageCause().getEntity() instanceof Player) {
            //    if (e.getDamager() instanceof Player) { (remove later, not needed)
                    Player p = (Player) e.getEntity();
                    if (p.getLastDamageCause().getEntity() instanceof Player) {
                        System.out.println("Entity was a player2");
                        if (p.getHealth() - e.getDamage() <= 0) {
                            p.sendMessage("send once, pl0x");
                            System.out.println("test");
                            return;
                        } else {
                            System.out.println("Player is not dead yet");
                        }
                    } else {
                        System.out.println("The last damage cause is NOT a player!");
                    }
                } else {
                    System.out.println("The damager is NOT a player!");
                }
        //    } else {
            //    System.out.println("The entity damage is NOT a player!"); (remove later, not needed)
        //    }
        } else {
            System.out.println("The entity is NOT a player!");
        }
    }

When the player dies, it sometimes sends the player "send once, pl0x" more than once - but other times it doesn't; mainly just with swords/bows/any-ouchy-weapons.
Is there a different condition I could use besides if (p.getHealth() - e.getDamage() <= 0)? Because I think this isn't the way to go...

Thanks for the help!

 

HeadGam3z Why not just use Player/EntityDeathEvent? Damage events don't account for any damage resistance, so that code isn't very reliable (event could say 10 dmg while armor and resistance could knock it down to like 2)

 

xTigerRebornx
Thanks for the info. I'll mess around with that event when I get home.

xTigerRebornx
Not sure if EntityDeathEvent is the way to go after-all, or maybe I'm misunderstanding this.

So I did some work with the event, got some success, and then of course some failures. I did some debugging and stumbled upon e.getEntity() and e.getEntity().getLastDamageCause().getEntity() are the same when I killed my alt account with my main account.

I.e, if HeadGam3z kills MindGam3z (my alt), the EntityDeathEvent thinks MindGam3z killed MindGam3z, which doesn't make a whole lotta sense to me. I know this because the code under the condition (if p.getUniqueId() != k.getUniqueId()) never has been ran yet, always just goes to the else statement.

Take a look at this:

Code:java

public void onPlayerDeath(EntityDeathEvent e) {
        if (e.getEntity() instanceof Player) {
            if (e.getEntity().getLastDamageCause().getEntity() instanceof Monster) { // pretty sure this isn't doing anything...
                System.out.println("Died by a monster");
                return;
            }
            if (e.getEntity().getLastDamageCause().getEntity() instanceof Player) {
                Player p = (Player) e.getEntity();
                Player k = (Player) e.getEntity().getLastDamageCause().getEntity();
                System.out.println(p);
                System.out.println(k);
                // p and k both print e's name (in this case, CraftPlayer{name=MindGam3z})
                if (p.getUniqueId() != k.getUniqueId()) {
                    System.out.println("test"); // hasn't showed up once.
                    return;
                } else {
                    System.out.print("Entity that died was a player, and killed theirself."); // 99.99% shows up.
                }
            } else {
                System.out.println("Killer is not a player");
            }
        } else {
            System.out.println("Entity that died is not a player, ignore this.");
        }
    }

Shouldn't p's (the player entity that died) UUID be different from k's (the player who killed the player entity, p) UUID?

I have, however, tried to use different events and just use getKiller(), but it returns a player (or null). Which isn't going to work for me, because if HeadGam3z hits MindGam3z, then a zombie gets the kill on MindGam3z, it still thinks HeadGam3z got the kill, even though the zombie got the kill. Different issue, though, lol.

Any light that you can shed on this would be great, thanks.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

HeadGam3z
Tried using equals() method, yet?

 

Gater12
Yes, the UUID condition was once if (!p.getUniqueId().equals(k.getUniqueId())).

 

HeadGam3z EntityDamageEvent#getEntity() returns the damagee, and afaik, that is the Entity that got damaged. not the Entity that damaged. I believe the last damage cause can be an EntityDamageByEntityEvent, which you can get that 'damager' Entity.

 

Okay, got it.

Are you suggesting I change my event to the EntityDamageByEntityEvent?

 

HeadGam3z Not exactly, Entity#getLastDamageCause() returns a EntityDamageEvent, meaning it can be an EntityDamageEvent or any of its subclasses, which means it can possibly be an EntityDamageByEntityEvent, which has a way of getting the attacker.

 

xTigerRebornx
Judging by the JavaDocs, I see I could use getDamager(), right?