[Mapping] avoid Stack Overflowes

Hello once again people.
I have a little problem with my worldmapper plugin and it is what the title says.
Let me describe what I did:
1. I get the size of the loaded world.
2. I made a method with a switch for every material I want to notice in it(I don't want Blocks like shrubs, flowers levers etc.)
3. As default case (i.e. if the Block is from a material I don't need) I call the method again with the block under the last one. (though I knew this is a bad idea )
thats how it's looks like:

Code:java

 
private static String typeToString(Block b) {
  String tname="";
  if(b.getChunk().isLoaded()){
     switch(b.getType()){
     case BEDROCK:
     tname="BEDROCK";
     break;
     case BIRCH_WOOD_STAIRS:
     tname="BIRCH_STAIRS";
     break;
     case BOOKSHELF:
     tname="BOOKSHELF";
     break;
     case BRICK:
     tname="BRICK";
     break;
     case BRICK_STAIRS:
     tname="BRICK_STAIRS";
     break;
     case BURNING_FURNACE:
     tname="FURNACE";
     break;
     case CACTUS:
     tname="CACTUS";
     break;
      //...
     case WOOL:
     DyeColor colorwl=((Wool)b.getState().getData()).getColor();
          switch(colorwl){
               case WHITE:
               tname="WHITE_WOOL";
               break;
               case ORANGE:
               tname="ORANGE_WOOL";
               break;
               case BLACK:
               tname="BLACK_WOOL";
               break;
               case BLUE:
               tname="BLUE_WOOL";
               break;
               case BROWN:
               tname="BROWN_WOOL";
               break;
               case CYAN:
               tname="CYAN_WOOL";
               break;
               case GRAY:
               tname="GRAY_WOOL";
               break;
               case GREEN:
               tname="GREEN_WOOL";
               break;
               case LIGHT_BLUE:
               tname="LIGHT_BLUE_WOOL";
               break;
               case LIME:
               tname="LIME_WOOL";
               break;
               case MAGENTA:
               tname="MAGENTA_WOOL";
               break;
               case PINK:
               tname="PINK_WOOL";
               break;
               case PURPLE:
               tname="PURPLE_WOOL";
               break;
               case SILVER:
               tname="LIGHT_GRAY_WOOL";
               break;
               case YELLOW:
               tname="YELLOW_WOOL";
               break;
               case RED:
               tname="RED_WOOL";
               break;
          }
     break;
     case WORKBENCH:
     tname="WORKBENCH";
     break;
     default:
     tname=typeToString(b.getRelative(BlockFace.DOWN));
     break;
     }
   }
   else{
     tname="nothing";
  }
return tname;
}

Is there another way which don't create a stack overflow?

 

1: Its not a stack overflow, its a stack trace
2: use try/catch statements
like this:

Code:

try {
//stuff
} catch (Exception e){
//do stuff with the exception
}

but, it can be any exception you want!

 

WTF !?
Why not ?

Code:

String tname = block.getType().name();

 

Skyost
because I don't want the name of the material, but my own string for it.
@Datdenkikniet
No, it IS a Stack Overflow:

Code:

 Exception in thread "Mapper"
java.lang.StackOverflowError
        at org.bukkit.craftbukkit.v1_6_R3.util.LongHashSet.remove(LongHashSet.java:132)
        at org.bukkit.craftbukkit.v1_6_R3.util.LongHashSet.remove(LongHashSet.java:128)
        at net.minecraft.server.v1_6_R3.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:88)
        at net.minecraft.server.v1_6_R3.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:84)
        at org.bukkit.craftbukkit.v1_6_R3.CraftWorld.getChunkAt(CraftWorld.java:118)
        at org.bukkit.craftbukkit.v1_6_R3.CraftWorld.getBlockAt(CraftWorld.java:82)
        at org.bukkit.craftbukkit.v1_6_R3.block.CraftBlock.getRelative(CraftBlock.java:161)
        at org.bukkit.craftbukkit.v1_6_R3.block.CraftBlock.getRelative(CraftBlock.java:169)
        at org.bukkit.craftbukkit.v1_6_R3.block.CraftBlock.getRelative(CraftBlock.java:165)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)
        at inc.A13X.SSW.Mapper.typeToString(Mapper.java:602)

 

Well how may blocks are you doing this for?

 

I do it for every goddamn Block, which is loaded.

Edit:
Thats not true. I'm not THAT crazy.
It's just every goddamn surface block, which is in a loaded Chunk.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Your method is being called recursively for every block which you did not list in the outer switch-statement...and over and over again all the way down past the bedrock into the void until the stack overflows...simple as that.

 

Rocoty that COULD be true. But I don't think so.
1. Bedrock is in my caselist and there is ALWAYS bedrock down there.
2. I save the string as a String array in a File and when I read this file back the array looks complete.
Edit: I don't know how it REALLY works, but the plan was that if the block is not in my caselist it read the material from the Block under the last one.
maybe it doesn't work because it would call the default case next time automatically, but I don't think so. It's simply unlogical.

 

Okay. New idea. In the default case block, before the recursive call, log or otherwise print the y position of the block to see how far down it is before the stack overflows.

 

Rocoty
the number don't goes under 62 so it works .
And it looks like the overflow error was there beacause the Notebook I was using was to slow or something like that.
This time I used a server and it worked.
Anyway it would be nice to find a way for this plugin to work on slower devices...

 

In that case I would recommend you loop instead of doing recursive method calls TheA13X

 

What StackOverflow basically means is that your code is trying to schedule more tasks for the processor than it can keep in memory. Basically, you are making the stack of stuff to do overflow with all of your recursive calls.