Solved Making /seen

Hello, I am trying to make a /seen command, but I don't know how to get an offline player's IP, and also how to display the moment when they were last seen in a string (if it is possible), not in a long. The IP address part is throwing errors in the console, line 41. Here is my code:

Code:java

package me.kait18.playercommands.commands;
 
import java.net.InetSocketAddress;
 
import me.kait18.playercommands.Main;
 
import org.bukkit.Bukkit;
import org.bukkit.OfflinePlayer;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class seen implements CommandExecutor{
 
    private Main main;
 
    public seen(Main main)
    {
        this.main = main;
    }
 
    @Override
    public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
        String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
        String prefix = main.getConfig().getString("Prefix").replace("&", "§");
        if(cmd.getName().equalsIgnoreCase("seen")){
            if(Sender.hasPermission("pcommands.seen")){
            if(args.length != 1){
            Sender.sendMessage(prefix + "§3Correct usage: /seen player");
            }if(args.length == 1){
                Player target = Bukkit.getPlayer(args[0]);
                if(target != null){
                    if(target.isOnline()){
                        Sender.sendMessage(prefix + "§3" + args[0] + "is §aOnline!\n§3First joined: " + target.getFirstPlayed() + "\nIP: " + target.getAddress().getAddress().toString() + "\nBanned: " + target.isBanned());
 
                    }
                    }if(target == null){
                OfflinePlayer targetoff = (Player) Bukkit.getServer().getOfflinePlayer(args[0]);
                if(targetoff.hasPlayedBefore()){
                        Sender.sendMessage(prefix + "§3" + args[0] + "is §3Offline since " + targetoff.getLastPlayed() + "\n§3First joined: " + targetoff.getFirstPlayed() + "\nIP: " + targetoff.getAddress().getAddress().toString() + "\nBanned: " + targetoff.isBanned());
                    }else{
                        Sender.sendMessage(prefix + "§cPlayer has not played before. Make sure casing is correct.");
                    }
            }
            }
            }else{
                Sender.sendMessage(prefix + noperm);
            }
        }
        return false;
    }
 
    }
 

Any Idea on how to solve the IP for an offline player?

 

Well, I have not really worked with this before and you are not giving us the errors you are getting but on line 41 you are doing .getAddress().getAddress(). Never mind, it does the same thing just removes the port. People would be able to help better if you gave the error

 

Here is the error http://pastebin.com/2dhCL5au

 

Well as I said I'm haven't worked with this type of stuff in bukkit much so what I say may be wrong, in which case I'm sorry. However, it appears you just can't get an address from someone that is offline so what I would do to bypass this (and I think that essentials and plugins like this work this way) is listen for when a player joins. Then check if they have played before. If they haven't then add them file were you add their name then their address after it is made a string. So that it looks something like:
random_username: 123.123.123.123:22565
then you can get their name from the config and get their address while they are offline. Also it would be a good idea so that not only do you check if they have already joined but if their address is the same. And if it isn't update it.

 

You might wanna use Bukkit.getPlayer(args[0].toLowerCase());

 

Then, any ideas in how to put in a file a player's name, and his IP? This way, as Windy Day said, I will be able to get the player's IP for the /seen command.

 

random_username
the problem is that offline players aren't really supported some methods do but not all.
what I do is saving a file when the player quits with I save his name, ip, also the time when they leaved.
then when I use /seen playername I will check if that file exists with that name and then load up the information.

edit
because I didn't read the post above me you could save files like

Code:

try {
File f = new File(yourplugin.getDataFolder() + File.Seperator + "players" + File.Seperator + p.getName() + ".yml");
if(f.exists()) {
 FileConfiguration con = YamlConfiguration.loadConfiguration(f);
con.set("name", p.getName());
con.set("time", System.timeCurrentMillies());
con.save(f);
} else {
FileConfiguration con = YamlConfiguration.loadConfiguration(f);
con.set("name", p.getName());
con.set("time", System.timeCurrentMillies());
con.save(f);
}
} catch(Exception e) {
e.printStacktrace();
}

loading is almost the same principe but then you would use .get();

you could set a System.currentTimeMillies(); into a date by using Date date = new Date(yourMillies);

 

Yes, I know I can't use those methods with offline players But my question is, how can I add that data you are saying to a file? Maybe in the playerquitevent?

 

Make a yml file for each player.

 

but how would I create those files when a player leaves the game?

 

random_username
ive updated my code on my earlier tag
it could be good to use it in the PlayerQuitEvent and PlayerKickEvent though I know you use likely getConfig() but this only works for config.yml not custom configs

 

You forgot to create the file if it doesn't exist

 

amhokies
it automaticly does, but for folders when using /seen for the first time you really need to check if the dir exists.

 

Then your code seems kind of redundant. You're doing the exact same thing whether the file exists or not.

 

amhokies
xize
So...:

Code:java

    //Quit Messages
    @EventHandler
    public void onPlayerQuit(PlayerQuitEvent event){
        Player player = event.getPlayer();
        if(main.getConfig().getBoolean("enableleavemessages") == true){
        event.setQuitMessage(main.getConfig().getString("onLeave").replace("&", "§").replace("%p", player.getName()));
        }try {
            File f = new File(main.getDataFolder() + File.separator + "players" + File.separator + player.getName() + ".yml");
            if(f.exists()) {
                FileConfiguration con = YamlConfiguration.loadConfiguration(f);
                Date date = new Date(System.currentTimeMillis());
                con.set("name", player.getName());
                con.set("time", date);
                con.save(f);
            } else {
                FileConfiguration con = YamlConfiguration.loadConfiguration(f);
                Date date = new Date(System.currentTimeMillis());
                con.set("name", player.getName());
                con.set("time", date);
                con.save(f);
            }
        } catch(Exception e) {
            e.printStackTrace();
        }
    }

Inside my events class??

 

amhokies
not really, if the file already exists you might want to change the values in it by using newer ones.

 

And how can I do this?

 

random_username
almost good, best way how I would do it is just using con.set("time", System.currentTimeMillies()); but it doesn't make a really big difference though (I hope) if I'm correct the Date object can be saved as a string.

edit
it goes automatic, if the file exists it only changes the values in that file.
if the file doesn't exists it creates a new file which get saved through con.save(f);

 

wait, shouldn't the file be created in the on-enable??

 

random_username
best way is to do it when they get kicked or quited though

 

and on my other class called seen, how do I get the data stored in the events class?

 

random_username

Code:

try {
  File f = new File(yourPlugin.getDataFolder() + File.Seperator + "players" + File.Seperator + args[0] +".yml");
  if(f.exists()) {
      FileConfiguration con = YamlConfiguration.loadConfiguration(f);
      Date date = new Date(con.getLong("time"));
//do something more
  } else {
     sender.sendMessage("no player data found");
  }
} catch(Exception e) {
   e.printStackTrace();
}

edit
though I recommend to save and load files as toLowerCase() so you have less case sensitivity

 

xize
I got the /seen when the player is online to work perfectly, but when I log out, this is what /seen says:
Last seen: 0
IP: 127.0.0.1
Location: 5
The IP is the only thing right, as I am joining with "localhost". Anyway, when I am online, it says:
Last seen: online
IP: 127.0.0.1
Location xxx,xxx,xxx
replace xxx with my current location x,y,z's values. How can I fix the message when I am offline? Here is the code of the Playerquitevent, and my seen class:
PlayerQuitEvent:

Code:java

    @EventHandler
    public void onPlayerQuit(PlayerQuitEvent event){
        Player player = event.getPlayer();
        if(main.getConfig().getBoolean("enableleavemessages") == true){
        event.setQuitMessage(main.getConfig().getString("onLeave").replace("&", "§").replace("%p", player.getName()));
        }try {
            File f = new File(main.getDataFolder() + File.separator + "players" + File.separator + player.getName() + ".yml");
            if(f.exists()) {
                FileConfiguration con = YamlConfiguration.loadConfiguration(f);
                Date date = new Date(System.currentTimeMillis());
                Location loc = player.getLocation();
                con.set("name", player.getName());
                con.set("time", date);
                con.set("ip", player.getAddress().getAddress().toString());
                con.set("loc", loc.getX() + loc.getY() + loc.getZ()) ;
                con.save(f);
            } else {
                FileConfiguration con = YamlConfiguration.loadConfiguration(f);
                Date date = new Date(System.currentTimeMillis());
                Location loc = player.getLocation();
                con.set("name", player.getName());
                con.set("time", date);
                con.set("ip", player.getAddress().getAddress().toString());
                con.set("loc", loc.getX() + loc.getY() + loc.getZ()) ;
                con.save(f);
            }
        } catch(Exception e) {
            e.printStackTrace();
        }
    }

Seen:

Code:java

public class seen implements CommandExecutor {
    private Main main;
 
    public seen(Main main)
    {
        this.main = main;
    }
    DecimalFormat df = new DecimalFormat("#");
    @Override
    public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
        String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
        String prefix = main.getConfig().getString("Prefix").replace("&", "§");
        if(cmd.getName().equalsIgnoreCase("seen")){
            if(Sender.hasPermission("pcommands.seen")){
                if(args.length == 1){
                    Player targeton = Bukkit.getPlayer(args[0]);
                    if(targeton != null){
                        if(targeton.isOnline()){
                            Location loc = targeton.getLocation();
                            Sender.sendMessage(prefix + "§a" + args[0] + " details:\n" + "§3Last Seen: §aOnline!" + "\n§3IP: " + targeton.getAddress().getAddress().toString().replace("/", "") + "\n§3Location: " + df.format(loc.getX()) + "," + df.format(loc.getY()) + "," + df.format(loc.getZ()));
                        }
                    }else{
                    OfflinePlayer target = Bukkit.getOfflinePlayer(args[0]) ;
                    try {
                        File f = new File(main.getDataFolder() + File.separator + "players" + File.separator + args[0] +".yml");
                        if(f.exists()) {
                            FileConfiguration con = YamlConfiguration.loadConfiguration(f);
                            Sender.sendMessage(prefix + "§a" + args[0] + " details:\n" + "§3Last Seen: " + con.getLong("time") + "\n§3IP: " + con.getString("ip").replace("/", "") + "\n§3Location: " + df.format(con.getDouble("loc")));
                        } else {
                            Sender.sendMessage(prefix + "§3no player data found");
                        }
                    } catch(Exception e) {
                        e.printStackTrace();
                    }
                }
                }
            }else{
                Sender.sendMessage(prefix + noperm);
            }
        }
        return false;
    }
}

Any ideas on how to solve it? Thanks for all the help btw

 

I just did a look how the location got saved but why not serialize it? it seems you put everything to one coordinate

edit
also you are saving a Date object in 'time' while you load it as a Long type which is wrong try loading that value as a string.

 

Thanks, making the date a string worked! About the location, I made it a string by using:

Code:java

String location = "§3" + df.format(loc.getX()) + "," + df.format(loc.getY()) + "," + df.format(loc.getZ());

and It worked! Thanks for the help, marking thread as solved