Loading, deleting worlds and spawnlocation.

So I'm developing a plugin that copies a folder and uses it as a world on command. So far I have done the part where it can copy it and use it to teleport to. But deleting it doesn't seem to be working and I don't know what's wrong. I probably forgot to do something or didn't check right.

Here's the code of deleting and copying the world:

Code:java

package me.Dreeass.Play;
 
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.entity.Player;
 
public class CopyWorld {
 
public static Main plugin;
 
public CopyWorld(Main instance) {
plugin = instance;
}
 
public void main(Player player)
   {
String name = player.getName();
   //File srcFolder = new File( new File(plugin.getConfig().getString("Config.CopyFromWorld")).getAbsolutePath());
   //File destFolder = new File( new File(plugin.getConfig().getString("Config.CopyToWorld")).getAbsolutePath());
 
   File srcFolder = new File( plugin.getConfig().getString("Config.CopyFromWorld") + "/");
   File destFolder = new File( plugin.getConfig().getString("Config.CopyToWorld") + "/");
 
   //make sure source exists
   if(!srcFolder.exists()){
          plugin.MessageConvert(player, "Messages.NewWorld.CopyFromWorld_DoesNotExist");
          plugin.ServerMessageConvert(name, "Messages.NewWorld.CopyFromWorld_DoesNotExist");
 
       }
   if(destFolder.exists()) {
   deleteFolder(destFolder, player);
   if(deleteFolder(destFolder, player)) {
   plugin.MessageConvert(player, "Messages.NewWorld.Deleted");
          try{
       copyFolder(srcFolder,destFolder,player);
          }catch(IOException e){
       e.printStackTrace();
       plugin.MessageConvert(player, "Messages.NewWorld.Error");
       plugin.ServerMessageConvert(name, "Messages.NewWorld.Error");
          }
   }
   }
   else{
 
          try{
       copyFolder(srcFolder,destFolder,player);
          }catch(IOException e){
       e.printStackTrace();
       plugin.MessageConvert(player, "Messages.NewWorld.Error");
       plugin.ServerMessageConvert(name, "Messages.NewWorld.Error");
          }
       }
   }
public boolean deleteFolder(File dest, Player player) {
String worldName = plugin.getConfig().getString("Config.CopyFromWorld");
if(Bukkit.getWorld(worldName) != null) {
World world = Bukkit.getWorld(worldName);
List<Player> players = world.getPlayers();
for(Player p : players) {
World dWorld = plugin.getServer().getWorlds().get(0);
Location dLoc = dWorld.getSpawnLocation();
p.teleport(dLoc);
plugin.MessageConvert(player, "Messages.NewWorld.Teleported");
}
Bukkit.unloadWorld(worldName, true);
}
       if (dest.isDirectory()) {
           String[] children = dest.list();
           for (int i=0; i<children.length; i++) {
               boolean success = deleteFolder(new File(dest, children[i]), player);
               if (!success) {
                   return false;
               }
           }
       }
 
       // The directory is now empty so delete it
       return dest.delete();
}
 
   public void copyFolder(File src, File dest, Player player)
   throws IOException{
 
   if(src.isDirectory()){
 
   // If directory not exists, create it
   if(!dest.exists()){
     dest.mkdir();
     plugin.log.info("Directory copied from " 
                             + src + "  to " + dest);
   }
 
   // List all the directory contents
   String files[] = src.list();
 
   for (String file : files) {
     // Construct the src and dest file structure
     File srcFile = new File(src, file);
     File destFile = new File(dest, file);
     // Recursive copy
     copyFolder(srcFile,destFile, player);
   }
 
   }
   else{
   // If file, then copy it
   // Use bytes stream to support all file types
   InputStream in = new FileInputStream(src);
          OutputStream out = new FileOutputStream(dest); 
 
          byte[] buffer = new byte[1024];
 
          int length;
          // Copy the file content in bytes 
          while ((length = in.read(buffer)) > 0){
        out.write(buffer, 0, length);
          }
 
          in.close();
          out.close();
          plugin.log.info("File copied from " + src + " to " + dest);
   }
   plugin.loading = true;
   }
}
[/i]

 

I think you have to completely unload a world before it can be deleted.

 

Well I added a check if the world is null and if not it will teleport the players out and unload the world. Just don't know why it doesn't work.

 

You can't simply check for null as it would only be null if you set the variable to null, which you likely don't. You should simply always teleport the players out of the world before unloading, not only if "world is not null".

BTW: some other people had problems with worlds blocking files even after they were completely unloaded, thus it might not even work if you do everything correctly.

 

I don't really get you because if I have to teleport them out when the world is null then I'll get an error.

 

My point is that 'world' will never be null.

 

Then how do I check if the world exists?

 

So you're not even sure whether the world you're trying to unload exists?
And if you're talking about this null check:

Code:

String worldName = plugin.getConfig().getString("Config.CopyFromWorld");
if(Bukkit.getWorld(worldName) != null) {

if the world doesn't exist you can't copy anything from it, thus you should send an error message and return. Maybe you should change "Config.CopyFromWorld" to "Config.CopyToWorld"?

I didn't even see this part of the code before because the indentation is messed up completely. In eclipse you can simply select the code an press ctrl+I and the indentation will be auto-corrected.

 

Lol what a mistake that I did not see! And I have perfect indentation but apparently it got removed in the syntax, maybe because I only use tabs? And I'll let you know if the code works then, thanks!