listener based on time?

I'm not sure exactly what i'm looking for here so i figured i would come ask. I'm developing a plugin that i want blocks to change at dawn and dusk. what listener do i need to do this? Also i have an arraylist of blocks. is this the best method i should be storing the blocks i mark in? i know everybody talks about hashmaps but its only one field i need stored.

Yeah i'm totally lost on how to save, load a ArrayList of blocks.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

For the timechange:
For the time change there is no event (as far as I know, please correct me someone if I am wrong there ) I would setup a Bukkit Scheduler and let it check the time frequently.

For the arraylist:
You could store the blocks in an ArrayList and save it to file by just saving the blocks coordinates, something like this:

(There may be errors included as I just wrote this down in 5 minutes in Notepad++ but it should at least give you a rough starting point )

Code:java

try {
    BufferedWriter out = new BufferedWriter(new FileWriter("outfilename"));    // Where "outfilename" is the name (and path) of/to your file
    for (Block block : YourArrayList)     // Where YourArrayList is the array list you want to parse
    {
        out.writeln(block.getX().toString() + ";" + block.getZ().toString() + ";" + block.getY().toString());
    }
    out.close();
} catch (IOException e) {
}

And you could from the file something like this:

Code:java

 try {
    BufferedReader br = new BufferedReader(new FileReader("outfilename"));    // Where "outfilename" is the name (and path) of/to your file
    String line;
    String[] data;
    World world;        // The world from which the blocks are - you need to get that from somewhere
    YourArrayList = new List<Block>();    // Where YourArrayList is the array list you want to parse
    while ((line = br.readLine()) != null) {
        data = line.split(";");
        if (data.length == 2)
        {
            YourArrayList.add(world.getBlockAt(Integer.valueOf(data[0]), Integer.valueOf(data[2]), Integer.valueOf(data[1])));
        }
    }
 }
 catch (IOException e) {
   System.out.println("Error: " + e);
 }

 

doh, i can't believe i forgot multiworlds LOL. Plugin was only intended to be used more or less once on my server for a project and that was the only place, however i guess i should add multiworld functionality. Back to the drawing board, gonna use a hashmap i guess with world being key and a arraylist of blocks. would that do it?

 

It should, you could just use a HashMap<World, List<Block>> or something like that, it should work as far as I know.
Then just create one file per world and you should be good to go, or just store the worlds name within the file as another "parameter" per line

 

Yeah i'm working on the hashmap now, i thought i had it all worked out but it goes kaboom when i run it. I will get to the saving aspect here in a bit, need to get the marking working in game again first LOL. Anyways here is the code

Code:java

 
		private void add_block(World world, Block block) {
    // extract the ArrayList from the HashMap
    ArrayList<Block> blockArray =  blockHash.get(world);
    // add the block to the list
    blockArray.add(block);
    // save the array back to the hashmap
    blockHash.put(world, blockArray);
	}

when i view the stack trace in the console it points to the first line in the function

 

Try List<Block> blockArray instead of ArrayList<Block> blockArray

 

same deal

 

Then post the error so I know whats going on / wrong and the code + line numbers of your code so I can see where the error occures. (or even better just the complete class, makes things easier)

 

here is the player listener

Code:java

 
package com.moosemanstudios.NightLight;
 
import java.io.File;
import java.util.ArrayList;
import java.util.HashMap;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerListener;
 
public class NLPlayerListener extends PlayerListener {
	public static NightLight plugin;
	private HashMap<World, ArrayList<Block>> blockHash = new HashMap<World, ArrayList<Block>>();
	static String mainDirectory = "plugins/NightLight";	// set main directory for easy reference
	static File saveFile = new File(mainDirectory + File.separator + "NightLight.dat");
	NLPlayerListener(NightLight instance) {
		plugin = instance;
	}
	public void onPlayerInteract(PlayerInteractEvent event) {
		Player player = event.getPlayer();
		if (event.getAction() == Action.RIGHT_CLICK_BLOCK){
			// see if they are in the hashmap
			if (plugin.enabled(player))
			{
				// get the block that was clicked as well as what world
				Block block = event.getClickedBlock();
				World world = player.getWorld();
 
				// see if the block is glass or glowstone first
				Material blocktype = block.getType();
				if ( (blocktype == Material.GLASS) || (blocktype == Material.GLOWSTONE) ) {
					// see if the block is already in the hashmap
					if (enabled(world, block)) {
						// block is in list already, so remove it
						remove_block(world, block);
						player.sendMessage(ChatColor.YELLOW + world.getName() + " block removed");
					} else {
						// block needs added, so add it haha
						add_block(world, block);
						player.sendMessage(ChatColor.YELLOW + world.getName() + " block added");
					}
				} else {
					player.sendMessage(ChatColor.YELLOW + "wrong block type");
				}
			}
		}
	}
	private Boolean enabled(World world, Block block) {
		// see if the hashmap has a key for the current world
		if (blockHash.containsKey(world)) {
			// hash map contains the world, extract the arraylist
			ArrayList<Block> blockArray= blockHash.get(world);
			// now see if the arraylist contains the block we are asking about
			if (blockArray.contains(block)) {
				// block is there, return true
				return true;
			} else {
				// block isn't in the list, return false
				return false;
			}
		}
		// defaults to false, if the world isn't in the hashmap there is obviously no blocks enabled.
		return false;
	}
	private void add_block(World world, Block block) {
		// extract the ArrayList from the HashMap
		ArrayList<Block> blockArray = blockHash.get(world);
		// add the block to the list
		blockArray.add(block);
		// save the array back to the hashmap
		blockHash.put(world, blockArray);
	}
	private void remove_block(World world, Block block) {
		// extract the array from the hash
		ArrayList<Block> blockArray = blockHash.get(world);
		// remove the block from the list
		blockArray.remove(block);
		// save the array back to the hashmap
		blockHash.put(world,  blockArray);
	}
 
	public static void save() {
	}
	public static void load() {
 
	}
 
}
 

and the error from the console

Code:text

 
18:03:26 [SEVERE] Could not pass event PLAYER_INTERACT to NightLight
java.lang.NullPointerException
        at com.moosemanstudios.NightLight.NLPlayerListener.add_block(NLPlayerLis
tener.java:81)
        at com.moosemanstudios.NightLight.NLPlayerListener.onPlayerInteract(NLPl
ayerListener.java:46)
        at org.bukkit.plugin.java.JavaPluginLoader$11.execute(JavaPluginLoader.j
ava:314)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:58)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:338)
        at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerInteractEven
t(CraftEventFactory.java:168)
        at net.minecraft.server.ItemInWorldManager.interact(ItemInWorldManager.j
ava:210)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:573)
        at net.minecraft.server.Packet15Place.a(SourceFile:57)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:89)
        at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:454)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:363)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
 

line 83 in my code is a comment right before blockHash.put in add_block

 

You never check if world is actually allready in the HashMap but just do a "blockHash.get(world);" which will return null if the world is not in the hashmap. Then you are using the result and try to add something to it, which is not possible when its null. Try something like this (may also apply to the block_remove function):

Code:

private void add_block(World world, Block block) {
    ArrayList<Block> blockArray = blockHash.get(world);
    if (blockArray == null) { blockArray = new ArrayList<Block>(); }    
    blockArray.add(block);
    blockHash.put(world, blockArray);
}

Also I am pretty sure using lists is done like this (I am using them like that in my Plugins and it works like a charm ^^ - though it may be possible that your way also works, I never tried it, but the following is just how I learned it when I learned java at my apprenticeship):

Code:

public List<Player> playersAccepted = new ArrayList<Player>();

 

doh, i should have known that. i really need some sleep today LOL.

EDIT: that did it LOL. i'm doing one helluva facepalm right now. +9001 rep

I'm back one last time for today LOL. In my main class in the onEnable and onDisable functions i call the NLplayerlistener load() and save() methods. however it says cannot make static reference to the non-static method load() from the type NLPlayerListener. I have the NLplayerListener in the main class as a public final. How in the world do i go about this. i know if i make the listener static then it creates errors in the listener itself.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It's not an event, but you can check and manipulate time here. Note that rapidly setting the time can completely mangle redstone, so be careful.

look here.
./Bukkit/src/main/java/org/bukkit/World.java (starting at line 402 as per commit 79ac053ef657886be7c0)

Code:

    /**
     * Gets the relative in-game time of this world.
     *
     * The relative time is analogous to hours * 1000
     *
     * @return The current relative time
     * @see #getFullTime() Returns an absolute time of this world
     */
    public long getTime();

    /**
     * Sets the relative in-game time on the server.
     *
     * The relative time is analogous to hours * 1000
     * <br /><br />
     * Note that setting the relative time below the current relative time will
     * actually move the clock forward a day. If you require to rewind time, please
     * see setFullTime
     *
     * @param time The new relative time to set the in-game time to (in hours*1000)
     * @see #setFullTime(long) Sets the absolute time of this world
     */
    public void setTime(long time);

    /**
     * Gets the full in-game time on this world
     *
     * @return The current absolute time
     * @see #getTime() Returns a relative time of this world
     */
    public long getFullTime();

    /**
     * Sets the in-game time on the server
     * <br /><br />
     * Note that this sets the full time of the world, which may cause adverse
     * effects such as breaking redstone clocks and any scheduled events
     *
     * @param time The new absolute time to set this world to
     * @see #setTime(long) Sets the relative time of this world
     */
    public void setFullTime(long time);

 

If its what I think it is (lol xD) then you need to create a NLPlayerListener Object first, then you can access these methods in that Object, like:

Code:

NLPlayerListener playerListener;

public void onEnable() {
     playerListener = new NLPlayerListener(this);
     playerListener.load();
}

If that doesn't work, then please post the code again so I can take a look

 

FML. i was at work today thinking about what you said, got home and looked at the code and it jumped right too me. I was calling the actual class and not the instance i created. I'm telling ya i was tired yesterday LOL.

Back with another question. I looked into schedulers but see a serious lack on any tutorials on how to use them so i just took a stab at one. I put this in the NLPlayerListener class as i wasn't sure where it should go. it works, but it lags the server out hardcore, i assume its because of the delay and period being set to 0. I plan on upping that of course, no need to check THAT often, maybe every 100 ticks at most. Anyways, is there a better place this should be or is that fine? I thought about splitting it out into its own class more than likely, seems to make sense to me.

Code:java

 
		plugin.getServer().getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable() {
			public void run() {
				// get list of worlds
				List<World> worlds = plugin.getServer().getWorlds();
				for (World world : worlds) {
					// see if the world is in the hashmap
					if (blockHash.containsKey(world)) {
						// get the time in the world
						long time = world.getTime();
						ArrayList<Block> blockArray = blockHash.get(world);
						for (Block block : blockArray) {
							if ((time > 12000) && (time < 22200)) {
								block.setType(Material.GLOWSTONE);
							} else {
								block.setType(Material.GLASS);
							}
						}
					}
				}
			}
		}, 0L, 0L);
 

Also if i can't figure out why my loading code won't work tomorrow evening i'll post that. it compiles, and it "loads" but somethigns not right as blocks that were saved when i first click them are added back in again.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You indeed should increase the delay, as 0 means it will run with EVERY server tick, which is quite a lot, since you loop through all worlds, check a list/hashmap for each world if it contains the world, and parse every block in the blocks array for those world, and also change blocks everytime!

To increase performance a bit:

• You could do a crosscheck if it has to change the block at all, because if the block is allready glass or is allready glowstone there is no need to change it
• Also I'd recommend to set the delay to several seconds (remember 20 ticks equals about a second), so maybe set it to 5 seconds = 5 * 20 = 100 ticks or even better to more, like 30 seconds = 30 * 20 = 600 ticks. The longer the delay the less heavy it will impact your servers performance, there is really no need to call that method that often

Since I don't really know where that code is located I cant really tell you if its placed good or bad ^^ Well you should at least make sure it will only be called once, otherwise you'd end up with many scheduled tasks when you really only need one (Which would be another performance killer xD)
I'd personally put it into its own class, just for the sake of that beeing much more structured and easy to read, but I guess thats just my preference ^^

 

Alright i'm back, had a few days that haven't been good to me. Anyways i split the scheduler out into a new class called NLTimeListener, here is the class

Code:java

 
		package com.moosemanstudios.NightLight;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.block.Block;
 
 
public class NLTimeListener {
	private static int NIGHT_END;
	private static int NIGHT_START;
	private static NightLight plugin;
 
	public NLTimeListener(NightLight instance, int start, int end) {
		plugin = instance;
		NIGHT_END = end;
		NIGHT_START = start;
	}
	public void run() {
		plugin.getServer().getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable() {
			public void run() {
				// get list of worlds
				List<World> worlds = plugin.getServer().getWorlds();
				for (World world : worlds) {
					// see if the world is in the hashmap
					if (plugin.playerlistener.blockHash.containsKey(world)) {
						// get the time in the world
						long time = world.getTime();
						ArrayList<Block> blockArray = plugin.playerlistener.blockHash.get(world);
						for (Block block : blockArray) {
							if ((time > NIGHT_START) && (time < NIGHT_END)) {
								if (block.getType() != Material.GLOWSTONE) {
									block.setType(Material.GLOWSTONE);
								}
							} else {
								if (block.getType() != Material.GLASS){
									block.setType(Material.GLASS);
								}
							}
						}
					}
				}
			}
		}, 100L, 0L);
	}
}
 

Then in the main class i declare at the class level a NLtimeListener instance with the times for dawn and dusk. In onEnable i then call timeListener.run() assuming thats how it should be done. Compiles fine and loads up fine no errors, however i still get a the system cannot keep up popping up real fast and my ram level maxes out in no time flat so i'm assuming its still creating a ton of the schedulers

 

Well you still have set the period to 0 which will cause it run every server tick, you just set the delay to 100 so it will start only after 100 ticks, but after that delay it will run every server tick. Set the period higher, and also please post your current main class so I can take a look at it.

And BTW I meant it somewhat different to split it into a new class, but I'll show you that when you posted the main class too, sometime tomorrow (Though I have to work on my own plugin so it may take some time, depending on how much I've got todo with my own Plugin)

 

Well i finally got it working, no lag, not ram eating, i let the plugin run for an hour or so on my test server to make sure and RAM usage didn't climb like it was. Revamped a lot of code and must have fixed something in the process. Only one last to get working and its ready to be released. Not sure if i wanna release it publicly on here, there is only one plugin thats similar that i know of but i feel like i a noob haha. Anyways, that last issue. Saving works great, i verified that its saving the correct blocks in the file by walking to them in world, but on loading the file it doesn't seem to be correct. I'm including the entire class in case i'm just messing up the logic somewhere but i don't believe so.

Code:java

 
package com.moosemanstudios.NightLight;
 
import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
import java.util.ArrayList;
import java.util.HashMap;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerListener;
 
public class NLPlayerListener extends PlayerListener {
	public static NightLight plugin;
	public HashMap<World, ArrayList<Block>> blockHash = new HashMap<World, ArrayList<Block>>();
	static String mainDirectory = "plugins/NightLight"; // set main directory
														// for easy reference
 
	NLPlayerListener(NightLight instance) {
		plugin = instance;
	}
 
	public void onPlayerInteract(PlayerInteractEvent event) {
		Player player = event.getPlayer();
 
		if (event.getAction() == Action.RIGHT_CLICK_BLOCK) {
			// see if they are in the hashmap
			if (plugin.enabled(player)) {
				// get the block that was clicked as well as what world
				Block block = event.getClickedBlock();
				World world = player.getWorld();
 
				// see if the block is glass or glowstone first
				Material blocktype = block.getType();
				if ((blocktype == Material.GLASS) || (blocktype == Material.GLOWSTONE)) {
					// see if the block is already in the hashmap
					if (enabled(world, block)) {
						// block is in list already, so remove it
						remove_block(world, block);
						player.sendMessage(ChatColor.YELLOW + world.getName() + " block removed");
					} else {
						// block needs added, so add it haha
						add_block(world, block);
						player.sendMessage(ChatColor.YELLOW + world.getName() + " block added");
					}
				} else {
					player.sendMessage(ChatColor.YELLOW + "wrong block type");
				}
			}
		}
	}
 
	private Boolean enabled(World world, Block block) {
		// see if the hashmap has a key for the current world
		if (blockHash.containsKey(world)) {
			// hash map contains the world, extract the arraylist
			ArrayList<Block> blockArray = blockHash.get(world);
 
			// now see if the arraylist contains the block we are asking about
			if (blockArray.contains(block)) {
				// block is there, return true
				return true;
			} else {
				// block isn't in the list, return false
				return false;
			}
		}
 
		// defaults to false, if the world isn't in the hashmap there is
		// obviously no blocks enabled.
		return false;
	}
 
	private void add_block(World world, Block block) {
		// extract the ArrayList from the HashMap
		ArrayList<Block> blockArray = blockHash.get(world);
 
		// see if the blockarray is null
		if (blockArray == null) {
			blockArray = new ArrayList<Block>();
		}
 
		// add the block to the list
		blockArray.add(block);
 
		// save the array back to the hashmap
		blockHash.put(world, blockArray);
	}
 
	private void remove_block(World world, Block block) {
		// extract the array from the hash
		ArrayList<Block> blockArray = blockHash.get(world);
 
		// remove the block from the list
		blockArray.remove(block);
 
		// save the array back to the hashmap
		blockHash.put(world, blockArray);
	}
 
	public void save() {
		ArrayList<World> worlds = new ArrayList<World>(blockHash.keySet());
 
		for (World world : worlds) {
			try {
				BufferedWriter out = new BufferedWriter(new FileWriter(mainDirectory + "/" + world.getName() + ".txt"));
 
				// extract the arraylist from the hashmap
				ArrayList<Block> blockArray = blockHash.get(world);
 
				// iterate through the blockarray and write to the file
				for (Block block : blockArray) {
					out.write(block.getX() + ";" + block.getY() + ";" + block.getZ());
					out.newLine();
				}
				// log the success
				plugin.log.info("[NightLight] world " + world.getName()	+ " saved.");
				out.close();
			} catch (IOException ex) {
				ex.printStackTrace();
			}
		}
	}
 
	public void load() {
		// populate worlds with files read from the directory
		File dir = new File(mainDirectory);
		String[] files = dir.list();
		ArrayList<Block> blockArray = new ArrayList<Block>();
		blockHash.clear();
 
		// iterate throught files to get the filenames and add to list
		for (int i = 0; i < files.length; i++) {
			try {
 
				// see if the name of the file is config.yml, if so skip it ya noob LOL
				if (files[1] != "config.yml") {
 
					// save the name of the world
					String worldName = getFileName(files[i]);
					World world = plugin.getServer().getWorld(worldName);
 
					if (world != null) {
						// open the file to read, file opened will be the name of the world loaded
						BufferedReader in = new BufferedReader(new FileReader(mainDirectory + "/" + files[i]));
						// populate the arraylist with values read from the file
						blockArray.clear();
						// loop through the file to get all the blocks
						String line = null;
						while ((line = in.readLine()) != null) {
							// split the string up
							String[] data = line.split(";");
							// make sure the block isn't malformed
							if (data.length == 2) {
								blockArray.add(world.getBlockAt(Integer.valueOf(data[0]), Integer.valueOf(data[1]), Integer.valueOf(data[2])));
							}
						}
						// at this point, everything has been read in, close the
						// file
						in.close();
						// add the arraylist as well as world to the hashmap
						blockHash.put(world, blockArray);
						// let player know world was loaded
						plugin.log.info("[NightLight] world " + world.getName() + " loaded.");
					} else {
						plugin.log.info("[NightLight] Failed to load world: " + worldName);
					}
				}
			} catch (IOException ex) {
				ex.printStackTrace();
			}
		}
 
	}
 
	private String getFileName(String fullFileName) {
		return fullFileName.substring(0, fullFileName.lastIndexOf('.'));
	}
 
}
[/i][/i]

 

Try to change the line:

Code:

if (files[1] != "config.yml") ...

To:

Code:

if (files[i] != "config.yml") ...

If that doesn't work: Where does it stop? Does it even print the plugin.log.info() stuff you have down there or does it skip the loading completely?

 

it makes it all the way through and says it loaded the data but it apparantly doesn't.

EDIT: LOL i didn't notice the 1 in there, i just added that last night but it still claimed to hvae loaded the world file.

Giggity i got it LOL. It just dawned on me what the problem was after i added a line to show the block that was added in the console not actually showing any blocks added.

Code:java

 
if (data.length == 2)
 

there are 3 coordinates not 2 LOL. It does load fine now. few more touches and i believe i'm ready to put it live . I really appreciate your help bassfader.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.