Light-weight messing around custom items?

Im searching for best way to check if itemstack is custom item and point somehow to it's wrapper class. What would you suggest?

 

Quaro

Code:java

if(player.getInventory().getItemInHand().getItemMeta().hasLore()){
    if(player.getInventory().getItemInHand().getItemMeta().getLore().contains(ChatColor.GOLD + "<LoreName>")){

Is this what you are looking for?

 

DeluXeNationMC Nahh, this is worst way.

 

Quaro But isn't lore just managed by Bukkit (players can't edit their item's lore)? If you want to keep information in lore without letting the player know, you can NMS change the item packet and edit the lore (thats how EnchantmentAPI work)

 

Basically, i need way to get something (ex: id) from itemstack that i could use for getting custom item's wrapper class. But i don't want to put that "something" in public (visible).

 

You could try using metadata.

 

coasterman10 Example?

 

Sorry to keep spamming my thread, but this question seems to be coming up a lot today!

http://forums.bukkit.org/threads/custom-item-data.265410/

I don't think there is a clean lightweight way, unfortunately. There are two suggestions so far I really like from that thread:

1. Use lore, but use ProtocolLib to override or remove the lore when sending the item to the client. That way you can store data the client can't see.

2. Use item attributes- this one I'm not so sure about, you'd have to read desht's post on it, but basically it sounds like you can store some data in an attribute name (not the value).

If you find any other good ideas, please add them to that thread or let me know.

coasterman10 I think Bukkit metadata is only for entities, it won't work on items. Item metadata is something else entirely, basically lore/name/enchants/etc.

 

NathanWolf So, which would you suggest? Which one using you? Examples?

 

I wouldn't suggest doing it the way I'm doing it (raw NBT data storage).

I don't really have a good suggestion, which is why I made that thread

 

Id suggest using the lore, but only color codes, that way it will be saved in the lore and you can check for it later but it wont be seen by the player

 

Metadata tutorial (though weak): http://wiki.bukkit.org/Plugin_Tutorial#Metadata
You can search around on Google or the search box on forums to find more information about metadata.

EDIT: Turns out I overlooked ItemStacks and they don't actually support metadata. I'm really not sure how you could identify an itemstack specifically without either renaming it or adding lore.

 

coasterman10 I believe the author of ProtocolLib (http://forums.bukkit.org/members/comphenix.90687950/ (cant figure out how to tahg)) has put out a library for using NBT to do it, but it gets complex
Wish there was a way of doing this in the BukkitAPI (nudges NathanWolf)

 

Vote here if you want it:

https://bukkit.atlassian.net/browse/BUKKIT-3221

That issue would be the basis for a PR, if I were to submit one. However the lack of traction on that issue and the general resistance to it is making me hesitant ... so vote it up