Solved Join and leave events Showing null?

Okay so I was trying to make a join and leave event that is supposed to display the players name but when I tried the way I am doing It shows null instead of the players name.

Code:java

    @EventHandler
    public void joinEvent(PlayerJoinEvent e) {
        Player p = Bukkit.getPlayer(getName());
        e.setJoinMessage("");
        String JoinEvent = ChatColor.translateAlternateColorCodes('&', (String)Main.this.getConfig().getString("join-message"));
        Bukkit.broadcastMessage(JoinEvent + ChatColor.GREEN + p);
    }
 
    @EventHandler
    public void leaveEvent(PlayerQuitEvent e) {
        Player p = Bukkit.getPlayer(getName());
        e.setQuitMessage("");
        String LeaveEvent = ChatColor.translateAlternateColorCodes('&', (String)Main.this.getConfig().getString("leave-message"));
        Bukkit.broadcastMessage(LeaveEvent + ChatColor.GREEN + p);
    }
}

 

PolarCraft

Okay, for a start, you need to be doing...

String pname = event.getPlayer().getName();

 

valon750 Already did that. Shows null aswell. That is why i am trying bukkit.getPlayer(getName())

 

PolarCraft

Code:

 @EventHandler
    public void joinEvent(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        String pname = p.getName();
        e.setJoinMessage("");
        String JoinEvent = ChatColor.translateAlternateColorCodes('&', this.getConfig().getString("join-message"));
        Bukkit.broadcastMessage(JoinEvent + ChatColor.GREEN + pname);
    }

That would work, assuming the path in your config isn't null.

It would help greatly if you could post the stack-trace, find the line where the error occurs, and let us know

 

valon750 No stack-trace. Their is no stack-trace. Loads fine but displays null instead of example [+] {PLAYER}.

 

PolarCraft
Then all I can assume is that the config is pointing to a null path.

 

PolarCraft

Code:java

@EventHandler
public void onPlayerJoin(PlayerJoinEvent e) {
Player p = e.getPlayer();
e.setJoinMessage(null);
String JoinEvent = ChatColor.translateAlternateColorCodes('&', this.getConfig().getString("join-message"));
Bukkit.broadcastMessage(JoinEvent + ChatColor.GREEN + p.getName());
}

 

valon750 Nope the config is not null. And Max_The_Link_Fan that would show npe.

 

PolarCraft Works for me..

 

PolarCraft
have you made an

Code:java

@Override
public void onEnable()
{
getServer().getPluginManager().registerEvents(this, this);
}

Without that in your main or in the class any Events break!
If that isnt your main change the main to

Code:java

@Override
public void onEnable()
{
getServer().getPluginManager().registerEvents(this, Plugin);
}

ImIm

 

ImImprobable Could you think about it for a second? He gets an output from an event handler and thus the event has to be registered already. Because of that, your statement doesn't affect the issue at all.

PolarCraft When you do 'getName()' just like you did in your fist post, it won't point to the 'getName' of the player, but rather the 'getName' defined in the currently class it is in (which I assume is your main plugin class). Because of that, getting a player with the name of your plugin will almost all the time result in null because there'll be no such player (would be kinda weird having the same name as a plugin).
Next, you cast to string is redundant because you already get a string back (since you're calling getString on the config).

 

kumpelblase2
Didn't read full thread, the title i thought was saying that they were doing nothingno errors or anything.
Sorry bout that
ImIm

 

PolarCraft
Why don't you use e.setJoinMessage() instead of broadcasting? If you broadcast it will show the default join message as well as what you have set it.

Your 'null' is coming from a null path. Post your config.

 

AoH_Ruthless As I said it is not my config -_- Please stop saying it is my config when it is not... And kumpelblase2 Lol my fist post.

[Edit] Also this was solved long ago.