Solved Java wont cooperate with me anymore ^^

Okay, so, this is really pissing me off. I've ripped off a little bit of my hair, and it still wont work. BUT, I SWEAR TO GOD THAT IT WORKED 1-2 MONTHS AGO! It used to take only 10 seconds write this code, but now I've used a few DAYS. Please help me...

Code:java

package me.stripa.NoDrop;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerDropItemEvent;
 
public class noDrop {
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        { //Syntax error, insert "}" to complete MethodBody. If I do that, I have to have a return false here, and then onPlayerDrop wont work.
 
            @EventHandler
            public void onPlayerDrop(PlayerDropItemEvent event) {
                event.setCancelled(true);
            } //Same problem..
 
 
 
 
        return false;
        }
}
 

 

EvilKittyCat123
My brain.. You just put a method, in a method.

Code:java

@Override
public void onCommand(CommandSender cs, Command c, String l, String[] a) {
    return false;
}
 
@EventHandler
public void onDrop(PlayerDropItemEvent e) {
  e.setCancelled(true);
}

Please learn java before you get into the Bukkit API.

 

EvilKittyCat123
... how did that work 2 months ago?

 

memory corruption...

brain cells prone to damage

 

@EvilKittyCat123
Are you 100% sure this worked 2 months ago? This shouldn't have worked at all. I am truly amazed.

 

I think the title of this thread is misleading. It is you who do not cooperate with Java.

 

TGRHavoc
A lot of things wont work now that worked before. I even wrote it down and it doesn't work..
mazentheamazin
Still not working, no error messages anywhere. The items still drops.

 

EvilKittyCat123 I know a foolproof method of making this work. But it won't work unless you follow it exactly. All it is is basically some words of wisdom: "If you wanna code Java, learn Java"

I'm going to bed. This is just depressive.

 

Rocoty
All I want to do, is to make a small bukkit plugin just like this. I have done it beforem but now I want to make another one containing the same features. So how come that it works on my other plugin and not on this one.

 

EvilKittyCat123 I can guarantee you that the code you posted has never worked. It won't even compile, let alone do anything useful. What on earth makes you think that sticking an event handler method inside an onCommand() method makes sense?

If items are still dropping, you probably haven't registered your event handler.

 

Because said pasted code of yours does not fit any possible Java syntax, and hence could've never worked. Pastebin full class of both plugins please.

 

desht
The event handler is registered. I did exactly the same as mazentheamazin, no errors in console or eclipse. But the items still drops..

And you guys complaining about hwo I haven't spent 2-3 years learning java wont really help my small problem for my small plugin that I have made many times before.

 

EvilKittyCat123 Paste full class please.

 

Necrodoom

Main class:

Code:java

package me.stripa.NoDrop;
 
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin
implements Listener
{
public final Logger logger = Logger.getLogger("Minecraft");
public static Main plugin;
 
public void onDisable()
{
PluginDescriptionFile pdfFile = getDescription();
this.logger.info(pdfFile.getName() + " Has been disabled! ");
}
 
public void onEnable()
{
PluginDescriptionFile pdfFile = getDescription();
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has been enabled! ");
getServer().getPluginManager().registerEvents(this, this);
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = (Player) sender;
 
 
{
 
if(cmd.getName().equalsIgnoreCase("nodrop"));
if(player.hasPermission("nodrop.main")) {
player.sendMessage(ChatColor.BLUE +"["
+ ChatColor.GRAY + "NoDrop"
+ ChatColor.BLUE + "] "
+ ChatColor.YELLOW + "============ "
+ ChatColor.GRAY + "NoDrop version "
+ ChatColor.GREEN + "1.0 "
+ ChatColor.YELLOW + "============ "
+ ChatColor.GRAY + "Bukkit version: "
+ ChatColor.GREEN + Bukkit.getVersion() + " "
+ ChatColor.GRAY + "Plugin Developer: "
+ ChatColor.GREEN + "EvilKittyCat123");
 
 
} else {
player.sendMessage(ChatColor.BLUE + "["
+ ChatColor.GRAY + "NoDrop"
+ ChatColor.BLUE + "] "
+ ChatColor.RED + "You do not have permission!");
 
}
 
 
 
 
 
 
 
 
 
 
 
 
 
return false;
 
}
}
}
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
Class noDrop:
 
 
 
 
 

Code:java

package me.stripa.NoDrop;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerDropItemEvent;
 
public class noDrop {
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
return false;
 
}
 
 
@EventHandler
public void onDrop(PlayerDropItemEvent e) {
e.setCancelled(true);
}
 
}

 

EvilKittyCat123 The class you posted did not implement Listener so you either updated a fair amount and not shown us, or you haven't registered it. As requested, please show full and updated code. EDIT: You're registering the main class, not the class that has the event in. Honestly, you might think we're being mean or unhelpful but this sort of thing suggests you're just copying from somewhere without actually understanding what it does.

 

This just hurts in so many ways

 

AdamQpzm

Okay, how do I register the event then?

Mayoz
Then go away, you're not helping!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

EvilKittyCat123
You don't implement Listener or extend CommandExecutor in that class. Neither do you actually register the event and the command. There is not even a command done in the class, whats the point of the onCommand method?

 

mazentheamazin
I had a command there but removed it, forgot to remove the onCommand method

So what would I do in order to get it to work.

 

EvilKittyCat123 See my edited post above. Point is it's difficult to know how to help somebody who doesn't want to accept the simple fact that you have to learn first.

 

Also why aren't you using StringBuilder?

 

Why is there a 'Class noDrop:' on line 95 of main class?

 

Necrodoom
That was a text placement mistake.
EvilKittyCat123
Learn. Java. for. the. love. of. god.
EDIT: By that I mean generally, to register an event getServer().getPluginManager().registerEvents(listener, plugin);

 

Isn't that obvious? It has been stated indirectly. You register events for that class and implement Listener.

 

Mayoz I think that efficiency is the least of his worries right now.

 

Necrodoom
That was suppose to be above the class noDrop.. It's not really in my real class or code.

 

AdamQpzm That's very true ;P

 

I know that I suck, you've all already showed me that. But at least help me.
So I did this:

Code:java

package me.stripa.NoDrop;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerDropItemEvent;
 
public class noDrop implements Listener{
    getServer().getPluginManager().registerEvents(listener, plugin);
 
 
@EventHandler
public void onDrop(PlayerDropItemEvent e) {
  e.setCancelled(true);
}
 
}

Code:java

package me.stripa.NoDrop;
 
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin
{
  public final Logger logger = Logger.getLogger("Minecraft");
  public static Main plugin;
 
  public void onDisable()
  {
    PluginDescriptionFile pdfFile = getDescription();
    this.logger.info(pdfFile.getName() + " Has been disabled! ");
  }
 
  public void onEnable()
  {
    PluginDescriptionFile pdfFile = getDescription();
    this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has been enabled! ");
  }
 
  public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
      Player player = (Player) sender;
 
 
      {
 
          if(cmd.getName().equalsIgnoreCase("nodrop"));
          if(player.hasPermission("nodrop.main")) {
          player.sendMessage(ChatColor.BLUE +"["
                  + ChatColor.GRAY + "NoDrop"
                  + ChatColor.BLUE + "] "
                  + ChatColor.YELLOW + "============ "
                  + ChatColor.GRAY + "NoDrop version "
                  + ChatColor.GREEN + "1.0 "
                  + ChatColor.YELLOW + "============    "
                  + ChatColor.GRAY + "Bukkit version:    "
                  + ChatColor.GREEN + Bukkit.getVersion() + "    "
                  + ChatColor.GRAY + "Plugin Developer: "
                  + ChatColor.GREEN + "EvilKittyCat123");
 
 
          } else {
              player.sendMessage(ChatColor.BLUE + "["
                          + ChatColor.GRAY + "NoDrop"
                          + ChatColor.BLUE + "] "
                          + ChatColor.RED + "You do not have permission!");
 
      }
 
 
 
 
    return false;
 
}
}
}
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 

if(cmd.getName().equalsIgnoreCase("nodrop"));

huh?

 

Necrodoom
It's a command, and it works, so don't worry about it..