Solved ItemStack remove lore issue

Greeting everyone,
i have a issue with item lore. I don't know if i'm missing something, but i think this should work

Code:java

    private void removeLore(ItemStack item, Player player) {
        ItemMeta meta = item.getItemMeta();
        if (meta == null) {
            player.sendMessage("Can't remove lore, no item meta found!");
            return;
        }
        List<String> lore = meta.getLore();
        if (lore == null) {
            player.sendMessage("There is no lore!");
            return;
        }
        meta.setLore(new ArrayList<String>());
        item.setItemMeta(meta);
        player.sendMessage("Item meta was remove. Now gather some of theese and see, if bug will ocure!");
    }

It remove lore of the item, but itemstack itself is not stackable anymore! So my question is - am i doing something wrong or it is bukkit issue? I need that, because i'm using itemlore as price info container in my chest shop plugin

If anybody knows how to remove lore corretly, any advice will be greatly appreciated! Many thanks

I tried it on craftbukkit versions: 2974 (last beta right now) and on 2991
I have made plugin, that is extraction of source, that creating this issue, if anyone will try it, you can download it from here (i can't put it in attachment because it is .jar), just put it in plugin folder and run local server, get some dirt, put it in hand and type /testlore, then type /removelore and you will see, that the item is not stackable and has no lore
source code is here

I hope i put it in the right section and sorry for my english

 

I would replace the itemstack with the same itemstack just without any metadata. By this I mean take the material, amount and durability and create a new itemstack from that instead of trying to remove the lore.

 

bladerik If I have to guess it is neither Bukkit nor Minecraft issue. You remove the lore and giving the item a default meta-value thus it is not the default Item anymore thats why it cannot be stacked anymore [again. It's just a guess from me. Could be wrong though] So I'd say do it the way beastman3226 sugessted

 

thanks for tips, but if i create new itemstack without any metadata, there is a problem with renamed items, firework rockets, maybe some enchanted stuff etc. etc. etc. so handle all of those things you will need to type many more source code in comparison with just remove the lore from metadata

i was creating new itemstack but after some time there was always some issues with more and more items. but if is there no other option, i have no choise

one would think that null lore is default value, maybe some sort of getting default lore value for any itemstack would help to solve this

 

http://jd.bukkit.org/rb/apidocs/org/bukkit/inventory/meta/ItemMeta.html#setLore(java.util.List)

you are not giving null if you give it an empty Stringlist. try setting it actually to null

 

thanks, i was trying it before without any succeed. It doesn't work now with null either.
this is how the removeLore method looks now

Code:java

private void removeLore(ItemStack item, Player player) {
ItemMeta meta = item.getItemMeta();
if (meta == null) {
player.sendMessage("Can't remove lore, no item meta found!");
return;
}
List<String> lore = meta.getLore();
if (lore == null) {
player.sendMessage("There is no lore!");
return;
}
meta.setLore(null);
item.setItemMeta(meta);
player.sendMessage("Item meta was remove. Now gather some of theese and see, if bug will ocure!");
}

commit

 

Try creating a new itemstack instead and replacing the old one with the new one without any meta value.

 

that's not a good solution for my case. please read #4

well, i guess i should share my temporary solution, which i don't like but it clears the lore and the output itemstack is stackable, but some players report some new items that are not. desired solution must preserve item custom name, enchants or any other specific data values like book enchantments or firework rocket effects, custom head skins and so on. And, ofcourse, output item must be stackable, if ItemStack.getMaxStackSize() is > 1
have you any suggestion on how to improve it? createNewItemStack method is called only when the current item stack have some lore.

Code:java

private ItemStack createNewItemStack(ItemStack item) {
ItemStack newItemStack = new ItemStack(item.getType());
newItemStack.setAmount(item.getAmount());
newItemStack.setDurability(item.getDurability());
 
ItemMeta meta = item.getItemMeta();
List<String> lore = null;
meta.setLore(lore);
//preserve enchantments, custom name etc.
newItemStack.setItemMeta(meta);
return newItemStack;
}

i'll just maybe report this whole issue as bug to bukkit bug tracker...

issue resolved https://bukkit.atlassian.net/browse/BUKKIT-5331
anyway, thank for tips guys

EDIT by Moderator: merged posts, please use the edit button instead of double posting.