Item Command

Hi, I need help. Lol. I am using this:

Code:java

 
if (cmd.getName().equalsIgnoreCase("i")) {
 
	        	int idOfItems = Material.matchMaterial(args[0]).getId();
	        	int numberOfItems = Integer.parseInt(args[1]);
 

Now when I do that, if I specify a word for the number of items, I need to get an error. How would I get the error to say something like,

Code:java

 
sender.sendMessage("That is not a valid amount.")
 

???

Also, if I specified an item that doesn't exist, I need to get an error. How would I get the error to say something like,

Code:java

 
sender.sendMessage("That is not a valid item.")
 

 

Code:java

try
{
    Integer.parseInt(args[0]);
}
catch (NumberFormatException nfe)
{
    // Not a valid number
}
 
if (Material.matchMaterial(args[1]) == null)
{
    // Material is not a valid material
}

 

Here is my code....

Code:java

 
 if (cmd.getName().equalsIgnoreCase("i")) {
 
	        	try
	        	{
	        	    Integer.parseInt(args[0]);
	        	}
	        	catch (NumberFormatException nfe)
	        	{
	        		sender.sendMessage("Invalid amount.");
 
	        	}
 
	        	if (Material.matchMaterial(args[1]) == null)
	        	{
	        	    sender.sendMessage("Invalid item.");
 
	        	}
 
	        	int idOfItems = Material.matchMaterial(args[0]).getId();
	        	int numberOfItems = Integer.parseInt(args[1]);
 
	        		 ItemStack ItemToAdd = new ItemStack(idOfItems,numberOfItems);
	 	            PlayerInventory inventory = player.getInventory();
	 	             inventory.addItem(ItemToAdd);
 

Sooo close. It just says invalid amount on everything. Even if its a real integer. But it still gives me the items. But if it is an invalid amount, it says it, it says its an invalid item (even though it isn't), then it says an internal error occurred. And the console gets an error.

Anddd... if it is an invalid item, it says its an invalid amount, and gets a console error.

 

What is your test case?

 

Take a look at this: http://jd.bukkit.org/doxygen/dd/ddd/GiveCommand_8java_source.html

 

???

Well, I'm not using a give command just yet. Im using a /i command. Im confused. Can someone help?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

what did you type to test it?

ex. /i 10 stone

 

no... /i dirt 3

EDIT: Oh, crap. Wrong order. Ill test with correct order.

 

The give command does the same thing. So you can look in their code how they made it

 

Yeah, I've got most of the item command done. I just need to get a Material into a String.
Anyone know how?

 

Material_obj.toString();

 

_obj ???

 

????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????

^ Proves your point better

 

(some object of type Material).toString();

 

Also add a return true after each test to prohibit a NPE in the console

 

Yeah. Thanks. Except what if it fails both tests? EDIT: For example, if I said "/i ice-cream 3b2", meaning both args were not valid.

Ok. Duhhh.

It actually does! (Maybe you could add "???????????????????????????????????????????????????" To the end. That might be better.

New code....

Code:java

 
if (cmd.getName().equalsIgnoreCase("i")) {
 
	        			try
	    	        	{
	    	        		int numberOfItems = Integer.parseInt(args[1]);
	    	        	}
	    	        	catch (NumberFormatException nfe)
	    	        	{
	    	        		sender.sendMessage("§a[iTask] §cInvalid amount.");
	    	        		return true;
 
	    	        	}
 
	    	        	if (Material.matchMaterial(args[0]) == null)
	    	        	{
	    	        	    sender.sendMessage("§a[iTask] §cInvalid item.");
	    	        	    return true;
 
	    	        	}
 
	    	        	int idOfItems = Material.matchMaterial(args[0]).getId();
	    	        	int numberOfItems = Integer.parseInt(args[1]);
 
 
	           		 ItemStack ItemToAdd = new ItemStack(idOfItems,numberOfItems);
	    	            PlayerInventory inventory = player.getInventory();
	    	             inventory.addItem(ItemToAdd);
 
	    	             Material itemGivenMat = Material.getMaterial(idOfItems);
	    	             String itemGiven = itemGivenMat.toString();
	    	             sender.sendMessage("§a[iTask] §cYou have been given §e" + args[1] + "§6 " + itemGiven + "§c.");
 
	        		}
 

Except what if it fails both tests? For example, if I said "/i ice-cream 3b2", meaning both args were not valid.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Just because I can't resist your begging. This stuff is basic; try a bit harder.

Code:

boolean isSuccess = false;
int numberOfItems = 1;
String returnMsg = "";

if (args.length >= 1) {
    Material toGive = Material.matchMaterial(args[0]);
    if (toGive == null)
    {
        returnMsg += ChatColor.PINK + "[iTask] " + ChatColor.WHITE + "Invalid item.");
        isSuccess = false;
    } else if (args.length > 1) {
        try
        {
            numberOfItems = Integer.parseInt(args[1]);
        }
        catch (NumberFormatException nfe)
        {
            returnMsg += ChatColor.PINK + "[iTask] " + ChatColor.WHITE + "Invalid amount.");
            isSuccess = false;
        }
    }
}

if (isSuccess) {
    returnMsg += "There you go";
    // give the amount of the item
}

if (!returnMsg.equals("")) {
    player.sendMessage(returnMsg);
}

return isSuccess;

 

Thank you so much. You are awesome tom. xD. Thats awesome.

EDIT: Except.... How would I get the "toGive" Variable in the " if (isSuccess) "?

*facepalm*