Issue trying to get locations to play effects in cone shape

Hey I can't figure out why this chunk of code isn't working.

First is the Circle Creation method

Code:java

    private static ArrayList<Location> circleBuilder (Location loc, Integer r, Integer h, Boolean hollow, Boolean sphere, int plus_y) {
        ArrayList<Location> circleblocks = new ArrayList();
        int cx = loc.getBlockX();
        int cy = loc.getBlockY();
        int cz = loc.getBlockZ();
        for (int x = cx - r; x <= cx +r; x++)
            for (int z = cz - r; z <= cz +r; z++)
                for (int y = (sphere ? cy - r : cy); y < (sphere ? cy + r : cy + h); y++) {
                    double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
                    if (dist < r*r && !(hollow && dist < (r-1)*(r-1))) {
                        Location l = new Location(loc.getWorld(), x, y + plus_y, z);
                        circleblocks.add(l);
                        }
                    }
 
        return circleblocks;
    }

That one works correctly and playing effects at each location works out rather well. Now when I try using that to get a circle and then only play effects at a certain amount of the locations in a cone like area doesn't work. Here is that code.The circle method basically just calls circle builder with sphere being false and passes the rest normally.

Code:java

    public static ArrayList<Location> getSemiCirlce(Player player, int radius, double arc, int height) {
        ArrayList<Location> targets = new ArrayList();
        if (arc <= 0) return targets;
 
        // Initialize values
        Vector dir = player.getLocation().getDirection();
        dir.setY(0);
        double cos = Math.cos(arc * Math.PI / 180);
        double cosSq = cos * cos;
        double dirSq = dir.lengthSquared();
        ArrayList<Location> list = circle(player.getLocation(), radius, height, true, 1);
        // Get the targets in the cone
        for (Location loc : list) {
 
                // Greater than 360 degrees is all targets
                if (arc >= 360) {
                    targets.add(loc);
                }
                // Otherwise, select targets based on dot product
                else {
                    Vector relative = loc.subtract(player.getLocation()).toVector();
                    relative.setY(0);
                    double dot = relative.dot(dir);
                    double value = dot * dot / (dirSq * relative.lengthSquared());
                    if (arc < 180 && dot > 0 && value >= cosSq) {
                        targets.add(loc);
                    }
                    else if (arc >= 180 && (dot > 0 || dot <= cosSq))  {
                        targets.add(loc);
                    }
                }
 
        }

xTigerRebornx fireblast709 either of you have an idea about this?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ferrago Shouldn't randomly tag people.
What do you expect to happen and what actually happens? Debug your code, print out all your values and see what may not be what you expect outputted.

 

xTigerRebornx Just trying to get a helping hand, didn't mean to upset anyone, y'all both seemed up for a challenge.
But I have debugged it very thoroughly, I am playing a particle effect at the location. The cirlce() method used alone plays a circle of the particles around the center location. That fully works. I then push that circle() method through this semicircle() method, I have tested make sure points are getting added, the size of the array is oddly in 400 range, but even still the effects aren't playing anywhere that I can see. I know my particle method isn't to blame since I use it all over the place and have never had the slightest problem.

 

ferrago See if you are actually playing the particles server-side, and print out the locations in the List, see if their values match up to what is expected.

 

#facepalm. Was an issue with pointers and whatnot. Twas performing calculations on a location then storing that location not a clone, which was making things go whack.