InventoryMoveItemEvent Help!

When the hopper moves the cobblestone to the chest is it meant to get rid of the cobblestone and deposit gravel in its place, but instead it deposits both cobblestone and gravel, any help guys?

Code:java

    @EventHandler
    public void onHopperMove(InventoryMoveItemEvent e){
        if(e.getInitiator().getType() == InventoryType.HOPPER && (e.getDestination().getType() == InventoryType.CHEST)){
            if(e.getItem().getType().equals(Material.COBBLESTONE)){
 
                //Cancels the item being moved
                e.setItem(new ItemStack(Material.AIR));
                //Cancels the item being moved
 
                e.getDestination().addItem(new ItemStack(Material.GRAVEL));
                e.getInitiator().remove(new ItemStack(Material.COBBLESTONE, 1));
            }
        }
    }

timtower Garris0n

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Have you considered cancelling the event...?

 

Garris0n

Yeah and it still doesn't work, it just keeps adding gravel to the chest without taking cobblestone

 

Well, is there a stack of cobblestone with an amount of one and no extra metadata in the hopper?

 

Garris0n

Yeah

 

Well, that's weird, although you should consider a remove method that doesn't require there to be an amount of exactly 1.

 

Garris0n

I did that, and it just removes ALL the cobblestone from the hopper, and deposits 1 cobblestone, 1 gravel into the chest

 

Make your own method that removes one from a stack.

 

Garris0n

I would have no idea where to being :/

 

1. Find an ItemStack of the type you want.
2. Lower the amount of the itemstack.*
3. ???
4. Profit.

*Note that setting the amount to zero doesn't delete an item. If the item's amount is 1, you have to actually set it to null in the inventory.

 

Garris0n Tried something like what you mentioned above but it doesn't seem to be working :/ think you could test some stuff for me? been stuck wit this for over 24 hours xD

 

Kassestral paste current code and explain why it doesn't work.

 

Necrodoom Garris0n I didn't save what i had before since my laptop died while I was sleeping but this is the last thing that was saved.

Code:java

    @EventHandler(priority = EventPriority.HIGHEST)
    public void onHopperMove(InventoryMoveItemEvent e){
        if(e.getInitiator().getType() == InventoryType .HOPPER && (e.getDestination().getType() == InventoryType.CHEST)){
            if(e.getItem().getType().equals(Material.COBBLESTONE)){
                e.getDestination().remove(Material.COBBLESTONE);
            }
        }
    }

 

Well obviously that will remove all of the cobblestone. That's what the method does.

 

Garris0n

But it doesn't, it deposits it, then removes it next time the event is called, meaning their is always a single cobblestone in the chests inventory, however players can take the cobblestone out of the chest therefor getting ALL of their cobblestone back, before the plugin removes it :/

 

Well that's because you remove the cobblestone before the next one is put into the chest.

Which I would've pointed out, except...

 

Garris0n

Could I ask you show me the code needed to fix my problem? and annotate what has been done?

 

something something section for help with code not giving code something

 

Garris0n

Okay, so then can you help me by telling me how to take the item from the initiator's inventory? it seems that if I cancel the event then it doesn't transfer the material, and also wont allow me to take any materials from the initators inventory slots :/

 

Set the item in the event to null and/or cancel the event.

https://github.com/Bukkit/CraftBukk...t/minecraft/server/TileEntityHopper.java#L262

 

Garris0n

Its alright I just made a completely different structure/building http://dev.bukkit.org/bukkit-plugins/trommel/