Incorrect value being returned

I apologize if I come across as vague, but for the past hour I have been trying to solve an extremely annoying problem. I have a function which will get values from a custom config file and set variables in the class to these values. However, when attempting to return these values, they are incorrect / return 0.

I ran a System.out.println() check on the value when setting it, and one when attempting to return it. The first one printed 500, as it should. The second one printed 0:

Code:java

 
private int health, maxHealth, level, experience, bits;
public void load(){
maxHealth = FileManager.getInt("stats.max-health", playerConfig);
health = FileManager.getInt("stats.health", playerConfig);
System.out.println(health); //Prints out 500
experience = FileManager.getInt("stats.experience", playerConfig);
level = FileManager.getInt("stats.level", playerConfig);
bits = FileManager.getInt("stats.bits", playerConfig);
}
public int getHealth(){
System.out.println(health); //Prints out 0
return health;
}
 

Help would be appreciated or the next thing to enter my screen will be my fist.

Thanks.

P.S. this was previously working, however it no longer is.

P.P.S

I've also tried setting the variables to public, private, protected, static, you name it, with no luck.

 

well on your function you never actually get the health from the file?

 

What does the FileManager class do?

 

Is that the exact code you tested ? Because you might have local variables around there that you're asigning instead of the fields.
And does your debug actually print in order, you first call load() then getHealth(), right ? Because calling getHealth() before load() would print 0.

 

FileManager is a custom class I made to retrieve data from files. It's worked perfectly in the past.

This wasn't the issue, but I am calling load() before getHealth().


My issue was in my event, whereby I was making an instance of the class each time - my code has a custom method to store the data in a local arraylist, but it wasn't doing so; instead, it was creating a new instance of it every time.

This is fixed now, however, i've come across another error... In my event for damage, I have this code:

Code:java

BitPlayer Victim = BitPlayer.getBitPlayer((Player)victim);
 
Victim.damage(damage);
 
if (Victim.isDead()){
event.setDamage(((Player)victim).getMaxHealth());
BitPlayer.removeBitPlayer(Victim);
return;
}

And this is the code it runs:

Code:java

 
protected static ArrayList<BitPlayer> bitPlayers = new ArrayList<BitPlayer>();
 
public BitPlayer(Player player){
playerName = player.getName();
entityID = getHandle().getUniqueId();
playerConfig = "/BitPlayers/" + playerName.toLowerCase() + ".yml";
if (FileManager.getKeys(true, playerConfig).size() > 0){
load();
}else{
maxHealth = FileManager.getInt("options.max-health", "config.yml");
health = maxHealth;
experience = 0;
level = 1;
bits = 0;
FileManager.saveFile(playerConfig);
save();
}
}
 
public static BitPlayer getBitPlayer(Player player){
for (BitPlayer bitPlayer : getBitPlayers()){
if (bitPlayer.getUUID() == player.getUniqueId()){
return bitPlayer;
}
}
BitPlayer bitPlayer = new BitPlayer(player);
addBitPlayer(bitPlayer);
return bitPlayer;
}
 
 
public static Player getHandle(){
return Bukkit.getPlayer(playerName);
}
 
 
 
public void setHealth(int health){
if (health < 0){
this.health = 0;
}else{
this.health = health;
int healthBar = Math.round(getHealth()/(getMaxHealth()/getHandle().getMaxHealth()));
if (healthBar > 0) getHandle().setHealth(healthBar);
else getHandle().setHealth(1);
}
}
 
public void damage(int damage){
if (getHealth() - damage <= 0){
setHealth(0);
dead = true;
}else{
setHealth(getHealth()-damage);
}
}
public static ArrayList<BitPlayer> getBitPlayers(){
return bitPlayers;
}

It works on my local server when there are no players on it besides me - all events fire and act as they should. However, when there are multiple players (like on a server) it causes damage from one player to pass to another player when players are being attacked by other players.

Shouldn't getUniqueID() return a Unique id?

 

You said you tried static when you made all those instances the value should've been preserved through the instances because, as the name suggests, it's a static field, as opposed to instanced.

getUniqueID() does return a unique and persistent ID but I don't think you can compare it with ==, use equals().

And why are you using getHandle() to get the player when you have the parsed Player object right there ?
Also, you might want to use getPlayerExact() because it's faster.

 

The problem isn't inside the getBitPlayers section - it /does/ get the unique ID but for some reason its sending player damage to multiple people.

 

Probably because playerName is static. You're using it in a static method it must be static otherwise you couldn't access it there.
You're basically overwriting a single variable, static is the opposite of instanced.
You should read about static fields because you seem to not understand them

If you want getHandle() to remain static then add an argument to it.
And you should really use getPlayerExact() because getPlayer() does partial matching and can also screw your results with certain names

 

I do understand them, I just fail to see the problem when it stares me in the face. I've changed all fields now and completely removed playerName and getHandle since they are completely useless. Thanks for your help though! I really appreciate it!