[INACTIVE][ECON] LocalShops - Please Close this Thread

Discussion in 'Inactive/Unsupported Plugins' started by Jonbas, Mar 1, 2011.

  1. Offline

    Jonbas

    LocalShops has moved to a new thread. Please go here.

    Thank you for all of your support and feedback.

    -Jonbas
     
  2. Offline

    Jonbas


    That's an interesting idea. I'll try to work out something more configurable for allowing custom messages. This could easily be worked into the shop entry message. Probably take me about 2 weeks to work this up.
     
  3. Offline

    Mydnyte

    User's without admin privileges can not use /shop set and retrieve a list of commands.
    Error: You do not have access to that command.

    Edit: Using the full string of /shop set buy dirt 200 etc. does work.

    Permissions settings for users:
    localshops.manage
    localshops.create
    localshops.destroy
    localshops.buysell

    If I use it as an admin, I get the help window normally.
    CB 556 / GroupManager alpha-5
     
  4. Offline

    NEO

    How does the damage check option in the config file work? Could you explain it more in depth? I was wondering if this was a fix for adding almost broken tools and weapons then taking them out fully repaired.
     
  5. Offline

    Jonbas

    Tools acquire damage as you use them. The setting lets you specify the maximum level of damage that a tool may have and still be sold. 0 is off so the setting is not used, otherwise the range is 1 - 100 in percent, where a tool will break at 100.

    Thanks for the great bug report. I'll look into it.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 10, 2016
  6. Offline

    Daveyo

    cb 556, local 1.15b, Something seems to be conflicing with lwc. When the newer localshops is in then lwc cant access it's plugins/lwc/lib/nativ/windows/amd64/sqlitejdbc.dll file.

    i reverted back to the old localshops (still has a problem with repairing tools) I think its 1.13 version of local shops. Runs fine
     
  7. Offline

    Jonbas

    LocalShops doesn't do anything with SQLite. Did you upgrade iConomy as well?

    Also... SQLite crashes sometimes during reloads. If you're getting errors from it, it's usually best to do a complete restart of the minecraft server software. (Stop and start it again) This may clear up whatever bug you were seeing.
     
  8. Offline

    GhostToast

    thanks for making this plugin. it is working beautifully with ServerBank as shop owner. Now I just hope no one registers that player name =)
     
  9. Offline

    Jonbas

    Yah, no kidding. They could buy my entire server... I've got an old gift code laying around here somewhere. Maybe I should register it just to make sure.

    Hmm... Maybe i should just add the name to my ban list?
     
  10. Offline

    puyttre

    Whenever you do a command with the name 'apple' in it, it says matched multiple items: Apple and Golden Apple, and i've tried both redapple and apple again. can you fix this? thanks :) great mod
     
  11. Offline

    Killie01

    just a little heads up, is a plugin :p
     
  12. Offline

    Rosinac

    I tried v4.4 of iConomy. And nothing happened the glitch still works is there anything i can do to fix this?
     
  13. Offline

    puyttre

    Also with diamond and other related items...
     
  14. Offline

    Jonbas

    You need to be more exact with your name. When you use the sell and buy commands it only compares to items already in the shop, but adding a new item uses the full list.

    Apple will match Apple
    apple will match Golden Apple and Apple
     
  15. Offline

    Killie01

    can there be a default price.txt
    because i am really bad with prices,
    maybe the one from the screenshot?
     
  16. Offline

    puyttre

    Oh, Im stupid. Thanks :)
     
  17. Offline

    Jonbas

    I don't think that there will be any one standard for this, but I'd be happy to share what I do with my own server.

    I decided to use gold as a standard for setting the value of the currency, and then tried to base the costs of other things off of that. So the first shop I setup was for selling gold and diamonds. I set this shop to have unlimited money and unlimited stock.

    DefaultSwap:
    Gold Ingot buy: 1,500 sell: 1,500
    Diamond buy: 10,000 sell: 4,500

    Then I setup a second store for buying and selling a few basic building materials.

    Smooth Stone buy 15:1 sell 10:1
    Cobblestone buy 2:1 sell 1:1
    Dirt buy 2:1 sell 1:1
    Sand buy 7:1 sell 5:1
    Glass buy 25:1 sell 20:1
    Wood buy 25:1 sell 20:1
    Coal buy 12:1 sell 10:1

    By request from users I added a few luxury items that can't be found since we don't have nether or don't occur naturally.

    Grass buy 30,000:1
    Glowstone Block buy 6,000:1
    Netherrack buy 6,000:1
    Soul Sand buy 6,000:1
    Lava Bucket buy 1,000:1 sell 800:1
    Redstone Ore buy 200:1 sell 180:1
    Lapis Lazuli buy 200:1 sell 150:1
    Leaves buy 200:1 sell 180:1

    And then I also made arrows cheap because they are fun to play with but stupidly expensive to make.

    Arrow buy 400:64

    My goal with all of this was to sell the minimum amounts on my server through the general store. I wanted most prices to be set by the users in their own shops.

    What I tried to support through the server stores was to make it possible for people to play the game in the way they liked and then be able to sell that to the server for money. Then they can use that money to buy what they need for building or adventuring.

    Here are links to my server shop files:

    GeneralStore.shop
    TheGranary.shop
    DefaultSwap.shop
     
  18. Offline

    Darkenvy

    Found a bug. Buying items when an inventory is full will hang the server. This took forever to find out btw but happens every time.

    http://pastebin.com/YEtinnQ3
     
  19. Offline

    Jonbas

    Can you give me any more details on what exactly you are doing to be able to cause this? I have been looking for this and haven't been able to re-produce it yet.

    Is every slot of your inventory full, or is every slot full of stacks of 64? What exactly is the command that you are using to buy the items? What version of Craftbukkit, LocalShops, iConomy, and permissions are you using?
     
  20. Offline

    Nijikokun

    Few suggestions from my players (Yeah I use it):
    • Make it compatible with data values.
    • Allow and update feature based on index values (id), create an array -> each slot in array = id -> update [id] [sell|buy] [amount] [etc]
    • Same for remove / set, that way you don't have to use long erroneous names and its easier to check the id of the list if you show the id# in /shop list - If you want a reference, check out Mobiile to see what i'm talking about :p
     
  21. I've discovered a pretty decent sized error.
    If a user purchases 1 item from a shop, and then goes to buy 64, they are charged for all 65, but only get 64 total (the shop will fill up the first stack, but not create a new stack).
    Also, i've had random reports of users buying something, and it says "You have just purchased 0 of item for #### (whatever the total was)". I haven't isolated what is doing this yet, but i'm working on it.

    Ok... this is completely screwey now..

    I have users who are buying things, dont have enough money, and they lose a LOT of money (eg, if it cost 150,000, they are losing 120,000 of their 149,000). I have found no correlation to the amount of money they lose, and the amount they purchase for

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 10, 2016
  22. Offline

    Phantom Index

    Can there be a MySQL feature and a setting to allow a certain amount of shops that can be made by one player?
     
  23. Offline

    Darkenvy

    Buying items when the player's inventory is full. I also tried buying over the limit that an inventory can hold when my inventory was empty. Lol niji, you would ><
     
  24. [email protected]Jonbas
    Now, i just started the server, and LocalShops puts out:

    Code:
     [INFO] LocalShops version null: is disabled!
    \
    and then it loads some of the shops, and then it randomly puts out this message:
    Code:
    [SEVERE] null loading LocalShops v1.15b (Is it up to date?)
    
    We have 11 shops. It only loads 4 of them. (i can find no pattern in which shops its loads/doesn't load)

    Also, when i attempt to do /shop reload (or other random /shop commands), it gives this:
    Code:
    [SEVERE] null
    org.bukkit.command.CommandException: Unhandled exception executing command 'shop' in plugin LocalShops v1.15b
    
    Nothing has changed on the server.

    We are running CB 556, and iConomy 4.5.5 (elektra), and LocalShops 1.15b.
     
  25. Offline

    Drev

    This is why bugs can be hard to fix:

    User X
    Author
    User X
    :eek:

    Excellent feedback.

    On a more positive note, great plugin!
     
  26. Offline

    Geoff Winans

    Code:
    21:06:51 [SEVERE] null
    org.bukkit.command.CommandException: Unhandled exception executing command 'shop' in plugin LocalShops v1.15b
            at org.bukkit.command.PluginCommand.execute(PluginCommand.java:37)
            at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:80)
            at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:229)
            at net.minecraft.server.NetServerHandler.c(NetServerHandler.java:645)
            at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:608)
            at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:602)
            at net.minecraft.server.Packet3Chat.a(SourceFile:24)
            at net.minecraft.server.NetworkManager.a(SourceFile:230)
            at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:76)
            at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
            at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:357)
            at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:272)
            at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)
    Caused by: java.lang.NullPointerException
            at net.centerleft.localshops.ShopData.LoadShops(ShopData.java:263)
            at net.centerleft.localshops.LocalShops.onEnable(LocalShops.java:130)
            at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:118)
            at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:451)
            at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:217)
            at net.centerleft.localshops.LocalShops.onCommand(LocalShops.java:178)
            at org.bukkit.command.PluginCommand.execute(PluginCommand.java:35)
            ... 12 more
    
    No new plugins, no config changes. Abruptly stopped working after the last automated restart.

    /shop shows help, but the shops don't "exist".
     
  27. Offline

    Jonbas

    Thanks for all the feedback everyone. Sorry I can't work on any of it for a couple days. I'm getting all my wisdom teeth pulled tomorrow, so I'll get back when I can.

    Thank you for understanding.
     
  28. Offline

    Darkenvy

    I know I wasn't being specific, but I posted my console and was as specific as I could be (which sadly wasn't that specific). The server doesn't crash but hangs so Im guessing there is an overflow; Perhaps check the free inv space and decline the transaction if room isnt present.

    Also note that the console I postbinned wasnt related to the plugin :S. There is no error posted in console, just waiting. My players cannot play within the server but Dynmap and CraftIRC will still post messages to console and within the plugins themselves but none will appear in game like normal. Also sending commands through console wont post anything so I must force stop the program or terminate the current screen session.

    EDIT: It doesn't matter if the whole inventory is stacks of 64 or if the inventory is full of random junk.

    Hope this was more helpful.
     
  29. Offline

    Olof Larsson

    Your plugin is awesome :)
    Good luck with the teeth :O
     
  30. Offline

    Kotoa

    Hey, nice plugin! Is there any way which I can make it auto list the items the shop is selling upon entering?
     
  31. Offline

    Fearil

    @Jonbas
    I hope your wisdom tooth-pulling goes as well as mine did... I had pretty conical /\ roots, so they came right out and I was eating solid food that night. Pretty a-typical, but I hope yours goes well anyhow.

    I haven't updated my copy of LocalShops in a couple weeks, and it seems to run stable. Still, I'm going to update it to the current version and I'll let you know if theres any difficulty.
     

Share This Page