Solved IllegalArgumentsException

Ok, so, I've been working on a plugin recently. I ran into this problem though still haven't figured out what's wrong? It's currently giving me the error that "n must be positive." Thing is, there is no "n" variable nor would/is it negative.

This is what the stacktrace leads me to:

Code:java

public Player randomBluePlayer() {
        Player picked = tManager.blue.get(r.nextInt(tManager.blue.size()));
 
        return picked;
    }
 
    public Player randomRedPlayer() {
        Player picked = tManager.red.get(r.nextInt(tManager.red.size()));
 
        return picked;
    }

 

WesJD n is the parameter in Random#nextInt()
This is part of the source for the nextInt method

Code:

if (n <= 0)
    throw new IllegalArgumentException("n must be positive");

So if your maps size is equal to 0 then the exception will be thrown.

 

Skionz Thing is, both map's size is equal to 1 or more...

 

WesJD Can your post the relevant classes?

 

Skionz

Code:java

kage me.Wes.bombattack;
 
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Random;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
 
public class TeamManager implements Listener {
 
    List<Player> red = new ArrayList<Player>();
    List<Player> blue = new ArrayList<Player>();
    private Random r = new Random();
 
    public void clearTeams() {
        red.clear();
        blue.clear();
        for(Player online : Bukkit.getOnlinePlayers()) {
            online.setPlayerListName(ChatColor.RED + online.getName());
        }
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        p.sendMessage(blue.size() + " - " +  red.size());
        if(red.size() > blue.size()) {
            blue.add(p);
            p.setPlayerListName(ChatColor.BLUE + p.getName());
        } else if(red.size() < blue.size()) {
            p.setPlayerListName(ChatColor.RED + p.getName());
            red.add(p);
        } else if(red.size() == blue.size()) {
            List<String> teams = Arrays.asList("RED", "BLUE");
 
            String team = teams.get(r.nextInt(teams.size()));
 
            if(team.equals("RED")) {
                red.add(p);
                p.setPlayerListName(ChatColor.RED + p.getName());
            } else if(team.equals("BLUE")) {
                p.setPlayerListName(ChatColor.BLUE + p.getName());
                blue.add(p);
            }
        }
    }
 
    @EventHandler
    public void onLeave(PlayerQuitEvent e) {
        Player p = e.getPlayer();
        if(red.contains(p.getName())) {
            red.remove(p.getName());
            p.setPlayerListName(ChatColor.GRAY + p.getName());
        } else if(blue.contains(p.getName())) {
            blue.remove(p.getName());
            p.setPlayerListName(ChatColor.GRAY +  p.getName());
        }
    }
}

 

WesJD

I would suggest adding debug statements to your code right before it executes that erroring line, to make certain that the teams are the size you're expecting.

 

mythbusterma
Will do.

EDIT: Hmm, gave me 0. Thing is, I made the debug messages on login too, and they gave me a correct value?

Edit 2: I think I know the exact problem, it's creating a new instance of tManager.