I cant Get it to work!

Hi there i am trying to make a plugin so a player can type /brb and it will brodcast "Playername will be right back" but when i export it to my test server and when i do /brb it just says to me /brb i dont know how to fix this here is my code :


package me.killerzz1.brb;

import org.bukkit.plugin.java.JavaPlugin;

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

public class Main extends JavaPlugin {

public void onEnable()
{
System.out.println("BRB Is Active");
}

public void onDisable()
{
System.out.println("BRB Is Not Active");
}


public boolean onCommand1(CommandSender sender, Command cmd, String label, String[] args) {
if(cmd.getName().equalsIgnoreCase("brb")){
if(!(sender instanceof Player))
{
if(!(sender instanceof org.bukkit.command.ConsoleCommandSender))
{
sender.sendMessage(ChatColor.RED + "Error: You can't do that from there!");
}else
{
if(args.length > 1)
{
for (int i = 0; i < args.length; i++) {
}
Bukkit.broadcastMessage(ChatColor.GREEN + "[AFK]" + ChatColor.GOLD + getName() + " " +"Will Be Right Back");

return true;
}

return false;
}

}
}
return false;
}
}

 

killerzz1
The method is onCommand not onCommand1

 

ok and is that what is making it do that ?

 

killerzz1
Yes.

 

ok i have done that and it is still just doing /brb when i do the command

 

killerzz1 I'm pretty sure you're getting problems from the if(!(sender instanceof org.bukkit.command.ConsoleCommandSender)) line. Try reworking that.

 

and how would you do that?

 

killerzz1
Will only execute if there is more than 1 argument. You do not have any function for if the argument is none.

 

ok so how would i make it so if a player types a command it does a broadcast ?

 

This should work:

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        if (label.equalsIgnoreCase("brb")) {
            if (sender instanceof Player) {
                Bukkit.broadcastMessage(ChatColor.GREEN + "[AFK]"
                        + ChatColor.GOLD + getName() + " "
                        + "Will Be Right Back");
 
                return true;
            } else if (sender instanceof org.bukkit.command.ConsoleCommandSender) {
                sender.sendMessage(ChatColor.RED
                        + "Error: You can't do that from there!");
 
                return true;
            }
        }
        return false;
    }

In all serious, you have a bunch of unneeded stuff in there. You mayyyy want to go learn some more Java. =p.

~Josh

 

Joshuaknight1998
killerzz1

You have alot missing in there -

1. So the Console is going to be AFK?

Code:java

if(!(sender instanceof Player)) {
sender.sendMessage("You must be a Player!");
return true;

2.

Code:java

if(label.equalsIgnoreCase("brb)) {

I think

Code:java

if(cmd.getName().equalsIgnoreCase("brb")) {

is better

3. You don't do

Code:java

 if(sender instanceof org.bukkit.command.ConsoleCommandSender) {

just do

Code:java

if(!(sender instanceof Player)) {

4. Where is your casting to a Player?

5.

Code:java

+ ChatColor.GOLD + getName()

- What getName - again, cast to a Player

Sorry if this seems a bit harsh

 

also you don't override any methods,

onEnable()
onDisable()
onCommand()

must be overriden, add the @Override annotation above them

 

well im new to java so you know