Solved Hub wont check array correctly HELP

when the checkForPlayer(player) is called it is suppost to see if the player is already inside of the arraylist and return false; but for some reason it returns false everytime even tho there is something in the array.

Code:java

package org.dbz.swordfighttour.Hub;
 
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.Plugin;
import org.dbz.swordfighttour.DataConfigFile.DataConfigFile;
 
public class Hub {
    private Plugin plugin;
    public Hub(Plugin plugin) {
        this.plugin = plugin;
    }
 
    public List<Player> players = new ArrayList<Player>();
    public HashMap<Player, ItemStack[]> hubinv = new HashMap<Player, ItemStack[]>();
    public HashMap<Player, ItemStack[]> hubarmor = new HashMap<Player, ItemStack[]>();
    public HashMap<Player, Location> hubloc = new HashMap<Player, Location>();
 
    public void setHubSpawn(Player player) {
        Location loc = player.getLocation();
 
        DataConfigFile dataconfigfile = new DataConfigFile(plugin);
        FileConfiguration s = dataconfigfile.getDataConfig();
 
        s.set("hub.data.x", loc.getX());
        s.set("hub.data.y", loc.getY());
        s.set("hub.data.z", loc.getZ());
        s.set("hub.data.pitch", loc.getPitch());
        s.set("hub.data.yaw", loc.getYaw());
        s.set("hub.data.world", loc.getWorld().getName());
        dataconfigfile.saveDataConfig();
    }
 
    public Location getHubSpawn() {
        DataConfigFile dataconfigfile = new DataConfigFile(plugin);
        FileConfiguration s = dataconfigfile.getDataConfig();
        Location l = new Location(
                Bukkit.getServer().getWorld(s.getString("hub.data.world")),
                s.getDouble("hub.data.x"),
                s.getDouble("hub.data.y"),
                s.getDouble("hub.data.z"),
                (float) s.getDouble("hub.data.pitch"),
                (float) s.getDouble("hub.data.yaw")
                );
        return l;
    }
 
    public void addPlayer(Player player) {
        Location loc = player.getLocation();
        ItemStack[] inv = player.getInventory().getContents();
        ItemStack[] armor = player.getInventory().getArmorContents();
 
        hubinv.put(player, inv);
        hubarmor.put(player, armor);
        hubloc.put(player, loc);
 
        players.add(player);
 
        player.teleport(getHubSpawn());
    }
 
    public void removePlayer(Player player) {
        players.remove(player);
        restorePlayer(player);
    }
 
 
    public void restorePlayer(Player player) {
        Location loc = hubloc.get(player);
        ItemStack[] inv = hubinv.get(player);
        ItemStack[] armor = hubarmor.get(player);
 
        hubloc.remove(player);
        hubinv.remove(player);
        hubarmor.remove(player);
 
        player.teleport(loc);
        player.getInventory().setContents(inv);
        player.getInventory().setArmorContents(armor);
    }
 
    public boolean checkForPlayer(Player player) {
        if(players.contains(player)) {
            return true;
        } else {
        return false;
        }
    }
 
    public void toggleAction(Player player) {
        if(!(checkForPlayer(player))) {
            player.sendMessage("None Found");
            players.add(player);
        } else {
            player.sendMessage("Found");
            players.remove(player);
        }
        }
}

 

Don't store Player objects, it can cause memory leaks if not handled safely. Store their UUID or username.

Then in checkPlayer():
return players.contains(player.getName());

 

DividedByZero

You might also want to consider using Sets (specifically HashSet) of the player's names as a measure against duplicate entries.

 

i have tried this with uuid and the contains method isnt working.
im doing if(players.contains(player.getUniqueId()) {
return true;
} else {
return false;
}

and it always return false;

 

DividedByZero
check if it contains the player's UUID as a string:

Code:java

if(players.contains(player.getUniqueId().toString())) {
return true;
} else {
return false;
}

 

FabeGabeMC that wont work. Just tried it still returns true every single time

 

DividedByZero
Then try checking for the username, since UUID's haven't come into play yet. (name change)

 

UUIDs work fine, and it won't break how hashmaps work either.
DividedByZero now it always returns true instead of false?

 

@FabeGaveMC the way that im checking for a player in the players ArrayList always returns true even when i print it in chat with toString() it ways its empty but when i run sendMessage( it says true

 

DividedByZero I've had that problem before.. I solved it by making the array static. doesn't quite make sense.. but that's what I did to make it work

 

travja ur awesome! Totally fixed it. Now works with ease. This is a very strange bug. Anyonr who could give me a reason why this occurs would be a great help!