Solved How I can get a ingredients of an Item to do uncraft?

Hello,

Could someone help me get the ingredients of an item.
Would you like to make a uncraft plugin.

 

what did you tried to acomplish this task already, maybe we can point out where it goes wrong

 

I have created this, but gets null:

Code:

    @SuppressWarnings("rawtypes")
    public static ItemStack[] uncraft(ItemStack item)
    {
        net.minecraft.server.v1_4_6.ItemStack itemstackc = CraftItemStack.asNMSCopy(item);
       
        List list = CraftingManager.getInstance().getRecipes();
       
        Object recipe_tmp;
        Object ingredient_tmp;
        IRecipe recipe;
        net.minecraft.server.v1_4_6.ItemStack result;
       
        net.minecraft.server.v1_4_6.ItemStack back[] = new net.minecraft.server.v1_4_6.ItemStack[0];
       
        for (int i = 0; i < list.size(); i++)
        {
            recipe_tmp = list.get(i);
            if(!(recipe_tmp instanceof IRecipe))
                continue;
            recipe = (IRecipe) recipe_tmp;
           
            result = recipe.b() == null ? null : recipe.b().cloneItemStack();
           
            if((result == null) || (result.id != itemstackc.id) || (result.getData() != itemstackc.getData()))
                continue;
           
            if(recipe instanceof ShapedRecipes)
            {
                try
                {
                    Field field = ShapedRecipes.class.getDeclaredField("items");
                    field.setAccessible(true);
                   
                    ingredient_tmp = field.get(recipe);
                   
                    if(!(ingredient_tmp instanceof net.minecraft.server.v1_4_6.ItemStack[]))
                        break;
                   
                    net.minecraft.server.v1_4_6.ItemStack[] tmp3 = (net.minecraft.server.v1_4_6.ItemStack[]) ingredient_tmp;
                   
                    back = new net.minecraft.server.v1_4_6.ItemStack[tmp3.length];
                   
                    for (int j = 0; j < tmp3.length; j++)
                    {
                        back[j] = tmp3[j].cloneItemStack();
                    }
                } catch (Throwable t)
                {
                    t.printStackTrace();
                    break;
                }
            }
            else if(recipe instanceof ShapelessRecipes)
            {
                try
                {
                    Field field = ShapelessRecipes.class.getDeclaredField("ingredients");
                    field.setAccessible(true);
                   
                    ingredient_tmp = field.get(recipe);
                   
                    if(!(ingredient_tmp instanceof List))
                        break;
                   
                    Object obj[] = ((List) ingredient_tmp).toArray();
                   
                    back = new net.minecraft.server.v1_4_6.ItemStack[obj.length];
                   
                    for (int j = 0; j < obj.length; j++)
                    {
                        back[j] = ((net.minecraft.server.v1_4_6.ItemStack) obj[j]).cloneItemStack();
                    }
                } catch (Throwable t)
                {
                    t.printStackTrace();
                    break;
                }
            }
           
            for (int j = 0; j < back.length; j++)
            {
                if((back[j] != null) && (back[j].getData() < 0))
                {
                    back[j].setData(0);
                }
            }
           
        }
       
        ItemStack[] item_back = new ItemStack[back.length];
       
        for(int i = 0; i >= back.length; i++)
        {
            item_back[i] = CraftItemStack.asBukkitCopy(back[i]);
        }
       
        return item_back ;
    }

 

Something like this maybe (untested):

Code:java

private final none = new ItemStack(Material.AIR, 0);
 
public ItemStack[][] undoCrafting(ItemStack i)
{
    List<Recipe> recipes = Bukkit.getRecipesFor(i);
    if(recipes.size() < 0)
    {
        return new ItemStack[]
        {
            {none, none, none},
            {none, none, none},
            {none, none, none}
        };
    }
    Recipe first = recipes.get(0);
    ItemStack returns = new ItemStack[3][3];
    if(first instanceof ShapedRecipe)
    {
        ShapedRecipe sr = (ShapedRecipe)first;
        Map<Char, ItemStack> chart = sr.getIngredientsMap();
        String[] shape = sr.getShape();
        char[] columns;
        for(int i = 0; i < shape.length; i++)
        {
            columns = row.toCharArray();
            for(int j = 0; j < columns.length; j++)
            {
                ItemStack x = chart.get(columns[j]);
                returns[i][j] = (x != null ? x : none);
            }
        }
    }
    else if(first instanceof ShapelessRecipe)
    {
        ShapelessRecipe sr = (ShapelessRecipe)first;
        List<ItemStack> x = sr.getIngredientList();
        int index;
        for(int i = 0; i < 3; i++)
        {
            for(int j = 0; j < 3; j++)
            {
                index = 3*i+j;
                if(index >= x.size())
                {
                    returns[i][j] = none;
                }
                else
                {
                    returns[i][j] = x.get(index);
                }
            }
        }
    }
}[/i][/i][/i]

 

Thank you, I'll try.

I found some problem at this part:

What is: row.toCharArray();

Code:

        if(first instanceof ShapedRecipe)
        {
            ShapedRecipe sr = (ShapedRecipe)first;
            Map<Character, ItemStack> chart = sr.getIngredientMap();
            String[] shape = sr.getShape();
            char[] columns;
           
            for(int i = 0; i < shape.length; i++)
            {
                columns = row.toCharArray();
               
                for(int j = 0; j < columns.length; j++)
                {
                    ItemStack x = chart.get(columns[j]);
                    returns[i][j] = (x != null ? x : none);
                }
            }
        }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

it converts a String to a char array... So "Hello" would become {'H', 'e', 'l', 'l', 'o'}. I am sorry that my code is a bit incorrect, I was writing it in Notepad++ and changed somewhere in between from foreach to normal for loops

Code:java

if(first instanceof ShapedRecipe)
{
    ShapedRecipe sr = (ShapedRecipe)first;
    Map<Character, ItemStack> chart = sr.getIngredientMap();
    String[] shape = sr.getShape();
    char[] columns;
 
    for(int i = 0; i < shape.length; i++)
    {
        columns = shape[i ].toCharArray();
 
        for(int j = 0; j < columns.length; j++)
        {
            ItemStack x = chart.get(columns[j]);
            returns[i ][j] = (x != null ? x : none);
        }
    }
}

 

Thank you for the help, I created a new function based on their.

Here go:

Code:

public List<ItemStack> undoCrafting(ItemStack item)
    {
        List<Recipe> recipes = Bukkit.getRecipesFor(item);
        if(recipes.size() < 0)
        {
            return new ArrayList<ItemStack>();
        }
        Recipe first = recipes.get(0);
        List<ItemStack> returns = new ArrayList<ItemStack>();
        
        if(first instanceof ShapedRecipe)
        {
            ShapedRecipe sr = (ShapedRecipe) first;
            Map<Character, ItemStack> chart = sr.getIngredientMap();
            
            for (ItemStack is : chart.values())
            {
                returns.add(is);
            }
        }
        else if(first instanceof ShapelessRecipe)
        {
            ShapelessRecipe sr = (ShapelessRecipe) first;
            List<ItemStack> x = sr.getIngredientList();
            
            for (ItemStack is : x)
            {
                returns.add(is);
            }
        }
        
        return returns;
    }

 

Just note that your users won't get the same quantities

 

Yes, is not finished yet.

 

Here the final uncraft function:

Code:

    public static List<ItemStack> uncraft(ItemStack item)
    {
        List<ItemStack> returns = new ArrayList<ItemStack>();
        List<Recipe> recipes = Bukkit.getRecipesFor(item);
        
        if(recipes.size() <= 0)
            return returns;
        
        Recipe recipe = null;
        
        for (Recipe r : recipes)
        {
            if(r.getResult().isSimilar(item))
            {
                if(r.getResult().getAmount() != item.getAmount())
                    continue;
                
                recipe = r;
                break;
            }
        }
        
        if(recipe == null)
            return returns;
        
        if(recipe instanceof ShapedRecipe)
        {
            ShapedRecipe sr = (ShapedRecipe) recipe;
            Map<Character, ItemStack> chart = sr.getIngredientMap();
                        
            for (ItemStack is : chart.values())
            {
                if(is != null)
                    returns.add(is);
            }
        }
        else if(recipe instanceof ShapelessRecipe)
        {
            ShapelessRecipe sr = (ShapelessRecipe) recipe;
            List<ItemStack> x = sr.getIngredientList();
            
            for (ItemStack is : x)
            {
                if(is != null)
                    returns.add(is);
            }
        }
        
        return returns;
    }