Solved Help With Sign Manipulation

This is the code I have, the top part works fine and dandy but the interact event doesnt seem to be firing any help?

Code:

package me.boysnnoco.utils;
 
import me.boysnnoco.CheesyKits.Main;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class SignListener implements Listener {
    public Main plugin;
    public SignListener(Main instance) {
        plugin = instance;
    }
    @EventHandler
    public void onSignCreate(SignChangeEvent sign){
        //Player player = sign.getPlayer();
        if(sign.getLine(0).equalsIgnoreCase("warp")){
            sign.setLine(0, "");
            String test = sign.getLine(1);
            sign.setLine(1,ChatColor.BLUE +"Warp");
            sign.setLine(2,ChatColor.LIGHT_PURPLE+test);
            sign.setLine(3, "");
        }
    }
 
//Need Help Here
@EventHandler(ignoreCancelled =true) // Just in case it is getting cancelled somewhere else
    public void onSignClick(PlayerInteractEvent event){
        Player player = (Player)event.getPlayer();
        if(event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.LEFT_CLICK_BLOCK){
            if(event.getClickedBlock().getState() instanceof Sign){
                Sign sign = (Sign) event.getClickedBlock().getState();
                if(sign.getLine(1).equals(ChatColor.BLUE+"Warp")){
                    if(sign.getLine(2).equalsIgnoreCase(ChatColor.LIGHT_PURPLE+ "arena")){
                        player.teleport(new Location(player.getWorld(),0,10,0));
                    }else{
                        //Debug to see if sign.getLine(2) wasnt working
                        player.sendMessage("Not arena");
                    }
                }else{
                  //Debug to see if the text was warp
                    player.sendMessage("No warp!");
                }
            }else{
                //Debug to see if it was a sign
                player.sendMessage("Debug not sign");
            }
        }else{
            //Debug sure it was a right click (or left click)
            player.sendMessage("MUST RIGHTCLICK")
        }
    }
 
}

 

Have you tried putting in debug messages to check whether the event is actually being fired at all, and if so, what part of the code is being reached?
Are any errors showing up in the console?
Wild guess, but are you aware that lines of a sign are zero-indexed? The top line of a sign is line 0, but not line 1.

 

adam753 boysnnoco I feel like you are both missing the obvious. He does not have his events registered (or even an onEnable to register them in).

 

JRL1004
That isn't his main class. He stated in his post that some of his code worked, which wouldn't even be possible if this was his only class considering he doesn't even have an "extends JavaPlugin" at the top.

 

Thanks for telling me, jboy44, I wasn't aware of that.

boysnnoco Would changing

Code:java

if(event.getClickedBlock().getState() instanceof Sign){

to

Code:java

if(event.getClickedBlock().getType() == Material.WALL_SIGN || event.getClickedBlock().getType() == Material.SIGN_POST){

make a difference?

 

This is just a single class of mine, I have a main class where I register the events

I just tried this and it still didn't seem to make a differnce the event seems like it isnt getting fired :/

Code:java

@EventHandler(ignoreCancelled =true)
public void onSignClick(PlayerInteractEvent event){
Player player = (Player)event.getPlayer();
player.sendMessage("DEBUG FIRED");
if(event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.LEFT_CLICK_BLOCK){
if(event.getClickedBlock().getType().equals(Material.WALL_SIGN)){
Sign sign = (Sign) event.getClickedBlock().getState();
if(sign.getLine(1).equals(ChatColor.BLUE+"Warp")){
if(sign.getLine(2).equalsIgnoreCase(ChatColor.LIGHT_PURPLE+ "arena")){
player.teleport(new Location(player.getWorld(),0,10,0));
}else{
player.sendMessage("Not arena");
}
}else{
player.sendMessage("No warp!");
}
}else{
player.sendMessage("Debug not sign");
}
}else{
player.sendMessage("MUST RIGHTCLICK");
}
}

I added the debug and it seems as though the event isn't even firing there isn't any errors nothing o_o any help?

Here's my main class:

Code:java

package me.boysnnoco.CheesyKits;
 
import java.util.logging.Logger;
 
import me.boysnnoco.Commands.CommandAbsorber;
import me.boysnnoco.Commands.CommandArcher;
import me.boysnnoco.Commands.CommandFisherman;
import me.boysnnoco.Commands.CommandGrandpa;
import me.boysnnoco.Commands.CommandKanga;
import me.boysnnoco.Commands.CommandKit;
import me.boysnnoco.Commands.CommandPhantom;
import me.boysnnoco.Commands.CommandPing;
import me.boysnnoco.Commands.CommandPvp;
import me.boysnnoco.Commands.CommandRod;
import me.boysnnoco.Commands.CommandStomper;
import me.boysnnoco.Commands.CommandStrafer;
import me.boysnnoco.Commands.CommandViper;
import me.boysnnoco.Commands.CommandWitherman;
import me.boysnnoco.utils.EntityListeners;
import me.boysnnoco.utils.Lists;
import me.boysnnoco.utils.SignListener;
 
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
public Lists list;
public Main(){
list = new Lists(plugin);
}
public Main plugin;
public Logger logger = Logger.getLogger("Minecraft");
public String noPerm = "You do not have permission for this kit!";
public void onEnable(){
logger.info("CheesyKits has been enabled!");
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(new PlayerListeners(this), this);
pm.registerEvents(new InventoryListener(this), this);
pm.registerEvents(new EntityListeners(this), this);
//Event Class
pm.registerEvents(new SignListener(this), this);
registerCommands();
}
public void onDisable(){
logger.info("CheesyKits has been disabled!");
}
public static String getMessage(final String[] args, final int start){
final StringBuilder stringbuilder = new StringBuilder();
 
for(int i = start; i < args.length; i++){
if(i != start){
stringbuilder.append(" ");
}
stringbuilder.append(args[I]);[/I]
[I] }[/I]
[I] return stringbuilder.toString();[/I]
[I] }[/I]
[I] public void registerCommands(){[/I]
[I] getCommand("pvp").setExecutor(new CommandPvp(this));[/I]
[I] getCommand("kit").setExecutor(new CommandKit(this));[/I]
[I] getCommand("absorber").setExecutor(new CommandAbsorber(this));[/I]
[I] getCommand("archer").setExecutor(new CommandArcher(this));[/I]
[I] getCommand("fisherman").setExecutor(new CommandFisherman(this));[/I]
[I] getCommand("kangaroo").setExecutor(new CommandKanga(this));[/I]
[I] getCommand("grandpa").setExecutor(new CommandGrandpa(this));[/I]
[I] getCommand("ping").setExecutor(new CommandPing(this));[/I]
[I] getCommand("rod").setExecutor(new CommandRod(this));[/I]
[I] getCommand("stomper").setExecutor(new CommandStomper(this));[/I]
[I] getCommand("phantom").setExecutor(new CommandPhantom(this));[/I]
[I] getCommand("viper").setExecutor(new CommandViper(this));[/I]
[I] getCommand("witherman").setExecutor(new CommandWitherman(this));[/I]
[I] getCommand("strafer").setExecutor(new CommandStrafer(this));[/I]
[I] }[/I]
[I]}[/I]
[I][/I]

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

boysnnoco Are any of the debug messages you added being output?

 

JRL1004
That wouldn't prevent the event from not firing.
boysnnoco
Try to change this in your SignChangeEvent:

Code:java

sign.setLine(2,ChatColor.LIGHT_PURPLE+test);

To this:

Code:java

sign.setLine(2,ChatColor.LIGHT_PURPLE+ "arena");

I noticed it doesn't match this if statement in your InteractEvent:

Code:java

if(sign.getLine(2).equalsIgnoreCase(ChatColor.LIGHT_PURPLE+ "arena")){

 

ok ill try it

yay it worked!! Thanks so much!

 

boysnnoco
You're welcome! I'm glad it worked.
Make sure to mark the thread as "solved"!