Help needed

Well i use netbeans and it does not want to let me make my jar unless i have no error's.So here is my plugin

Code:

package frostpvp;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.inventory.ItemStack;
 
public class FrostPvp extends JavaPlugin implements Listener {
    /**
    *
    */
    @Override
    public void onDisable() {
        // TODO: Place any custom disable code here.
    }
 
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        event.getPlayer().sendMessage("Welcome to this Server Hope you have a good time, " + event.getPlayer().getDisplayName() + "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
    }
 
    /**
    *
    * @param sender
    * @param cmd
    * @param label
    * @param args
    * @return
    */
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
    if(cmd.getName().equalsIgnoreCase("archer")){ // If the player typed /archer then do the following...
        // doSomething
        return true;
    //If this has happened the function will return true.
        // If this hasn't happened the a value of false will be returned.
   
 
if (sender instanceof Player) {
  Player player = (Player) sender;
  player.sendMessage("ArcherCommand!");
  player.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD));
}
        }
        return false;
}
}

And this is where the error is

Code:

if (sender instanceof Player) {
  Player player = (Player) sender;
  player.sendMessage("ArcherCommand!");
  player.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD));
}

 

It doesn't seem like you know what you are doing. Clearly this isn't all your code because you added in commenting which would be used for JavaDocs, but there is nothing here that is document-worthy

 

Change:
player.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD));

to

player.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD, 1));

 

That did help but there is a error with

Code:

if (sender instanceof Player) {

 

No longer helping you if you can't import.

 

why wont you help me ??? this is my first plugin

 

Learn java. This is basic stuff.

 

I know java i just dont understand why its a unreachable statement

 

stuntguy3000 zombieman1000

The problem is not the itemstack, it's his brackets

 

Can you tell me where i messed up with my brackets i would mean a lot

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

TheGreenGamerHD
im not sure i messed up with my brackets if so will you mind showing me where

 

@zombieman1000

Code:

package frostpvp;
 
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.inventory.ItemStack;
 
public class FrostPvp extends JavaPlugin implements Listener {
    /**
    *
    */
    @Override
    public void onDisable() {
        // TODO: Place any custom disable code here.
    }
 
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        event.getPlayer().sendMessage("Welcome to this Server Hope you have a good time, " + event.getPlayer().getDisplayName() + "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
    }
 
    /**
    *
    * @param sender
    * @param cmd
    * @param label
    * @param args
    * @return
    */
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
    if(cmd.getName().equalsIgnoreCase("archer")){ // If the player typed /archer then do the following...
        if (sender instanceof Player) {
              Player player = (Player) sender;
              player.sendMessage("ArcherCommand!");
              player.getInventory().addItem(new ItemStack(Material.DIAMOND_SWORD,1 ));
                    }
                    return false;
                    }
                return false;
}
}

i only been learning java past few days but i think this might be it

 

zombieman1000 You just told someone you were going to make them a CTF plugin *facepalm* , yet... (Learn Java)

 

i know java il be doing the plugin.yml and some of the TAG API

 

zombieman1000 did that work???

 

going to try it now

works perfect thank's so much

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

np you had an extra } no idea what ther called like i said been doing java for 3 days as no one will ever do my plugin request so im learning java

also could you mark down as solved

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

just to tell you } are called braces