help me please

hey guys so to start off i would like to say that i did not make this code my friend dis but sadly hes on vacation for 2 moth i think it was and he cannot fix this for me so i asked him just to send me the code so i could try to fix but i couldnt xD so im here asking you guys if you could help me change this code into blocking player damage to other players not player damage to mobs

Code:

  @EventHandler(priority=EventPriority.LOWEST)
  public void onNoAutoclick(EntityDamageByEntityEvent e)
  {
    if (((e.getEntity() instanceof LivingEntity)) &&
      ((e.getDamager() instanceof Player)))
    {
      final LivingEntity p = (LivingEntity)e.getEntity();
      if (this.nodamage.contains(p)) {
        e.setDamage(0.0D);
      }
      e.setCancelled(true);
      this.nodamage.add(p);
      new BukkitRunnable()
      {
        public void run()
        {
          Listeners.this.nodamage.remove(p);
        }
      }.runTaskLater(plugin, 2L);
    }
  }

 

chunkaymonkay Check if the damager and the entity is a player. Then cancel it. And you don't need to use the nodamage collection. You can modify the noDamageTicks instead.

 

teej107 ok thanks

teej107 like this?
@EventHandler(priority=EventPriority.LOWEST)
public void onNoAutoclick(EntityDamageByEntityEvent e)
{
if((e.getDamager() instanceof Player)))
{
e.setDamage(0.0D);
}
e.setCancelled(true);
this.nodamage.add(p);
new BukkitRunnable()
{
public void run()
{
Listeners.this.nodamage.remove(p);
}
}.runTaskLater(plugin, 2L);
}
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

chunkaymonkay If I am reading this right, you might want to move the 'this.nodamage.add(p);' and the 'e.setCancelled(true);' into your if statement, or you are just blocking all damage.

 

That and you aren't checking if the entity is a player either.

 

@EventHandler(priority=EventPriority.LOWEST)
public void onNoAutoclick(EntityDamageByEntityEvent
{
if((e.getDamager() instanceof Player)))
e.setCancelled(true);
this.nodamage.add(p);

{
e.setDamage(0.0D);
}
new BukkitRunnable()
{
public void run()
{
Listeners.this.nodamage.remove(p);
}
}.runTaskLater(plugin, 2L);
}
}

@Gerov like this ^ or like this

@EventHandler(priority=EventPriority.LOWEST)
public void onNoAutoclick(EntityDamageByEntityEvent
e.setCancelled(true);
this.nodamage.add(p);
{
if((e.getDamager() instanceof Player)))

{
e.setDamage(0.0D);
}
new BukkitRunnable()
{
public void run()
{
Listeners.this.nodamage.remove(p);
}
}.runTaskLater(plugin, 2L);
}
}

 

chunkaymonkay No.
Please learn and understand Java before you start making plugins. Java is the language you are using when you develop plugins. Bukkit is just an API. It's a lot easier to learn Java first then learn an API rather than attempting to understand both simultaneously. You should always learn the language you are writing in.

 

chunkaymonkay Just another tip, when I first got into programming, I learnt an easier language, Lua, so I could get to know the basics of programming like Strings and booleans, and if statements and all that, before I got into harder more complex langauges like Java.

 

If you do still need help, I may have misunderstood, but you can do this?

Code:java

if(e.getDamager instanceof Player) {
e.setCancelled(true);

^ That may be wrong, got it off the top of my head.