[Help] Kit Signs

Hello, i would like to know how i can make signs with text on them for example [Melee] execute commands from my class

This is my code currently:

package me.DeluXeNationMC.DeluXeSigns;

import org.bukkit.ChatColor;
import org.bukkit.block.Sign;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.plugin.java.JavaPlugin;

public class Main extends JavaPlugin implements Listener{

@EventHandler
public void onSignChange(SignChangeEvent event) {
if (event.getLine(0).equalsIgnoreCase("[Melee]")) {
event.setLine(0, "§3[Melee]");
event.setLine(1, "§3Click here");
}
}
@EventHandler
public void onPlayerInteract(PlayerInteractEvent event) {
if (!(event.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
if (event.getClickedBlock().getState() instanceof Sign) {
Sign s = (Sign) event.getClickedBlock().getState();
if (s.getLine(0).equalsIgnoreCase("§3[Melee]")) {
event.getPlayer().sendMessage("[" + ChatColor.GOLD + "DeluXePvP" + "" + ChatColor.GRAY + "]" + " You Were Given The Melee Kit!");
//Give Melee Kit ..
}
}
}
}

 

Okay so you want to make a class that will give the kit, also in the onPlayerInteractEvent use this code

Code:java

Player player = (Player) player

As it's good practices and then when you send them the message instead of typeing

Code:java

event.getPlayer().sendMessage("This all the time you can type this");
player.sendMessage("This will save time :)");

So you want to give them the kit? On the interact event do the follow

Code:java

PlayerInventory pi = player.getInventory(); //Make sure you have added Player player = (Player) e.getPlayer for this to work otherwise use PlayerInventory pi = event.getPlayer().getInventory();
 
@EventHandler
public void onPlayerInteract(PlayerInteractEvent event) {
if (!(event.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
if (event.getClickedBlock().getState() instanceof Sign) {
Sign s = (Sign) event.getClickedBlock().getState();
if (s.getLine(0).equalsIgnoreCase("§3[Melee]")) {
event.getPlayer().sendMessage("[" + ChatColor.GOLD + "DeluXePvP" + "" + ChatColor.GRAY + "]" + " You Were Given The Melee Kit!");
 
PlayerInventory pi = player.getInventory();
 
pi.addItem(new ItemStack(Material.GOLD_SWORD, 1)); //This will give them 1 gold sword when they hit the sign
 

Note: Please use the Code syntax that is provided, it is not there for nothing

 

Code:java

//Melee Kit
    if(label.equalsIgnoreCase("Melee")){
    if(!(sender instanceof Player)){
    sender.sendMessage(ChatColor.RED + "[DeluXePvP] You Must Be A Player To Get The Melee Kit!");
    return true;
    }
    Player player = (Player) sender;
    Location location = player.getLocation();
    player.sendMessage("[" + ChatColor.GOLD + "DeluXePvP" + "" + ChatColor.GRAY + "]" + " You Were Given The Melee Kit!");
    player.playSound(location, Sound.ITEM_PICKUP, 1, 1);
    player.getInventory().clear();
    player.getActivePotionEffects().clear();
    player.getInventory().addItem(new ItemStack(Material.IRON_SWORD));
    ItemStack meleeBootsItemStack = new ItemStack(Material.IRON_BOOTS, 1); //Melee's Boots
    meleeBootsItemStack.addEnchantment(Enchantment.PROTECTION_EXPLOSIONS, 4);
    ItemStack meleeHelmetItemStack = new ItemStack(Material.IRON_HELMET, 1); //Melee's Helmet
    meleeHelmetItemStack.addEnchantment(Enchantment.PROTECTION_EXPLOSIONS, 4);
    player.getInventory().setHelmet(new ItemStack(meleeHelmetItemStack));
    player.getInventory().setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
    player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS));
    player.getInventory().setBoots(new ItemStack(meleeBootsItemStack));
    return true;
    }
    }

But I Dont Understand How I Execute This Code When The Player Right Clicks The Sign

Currently This Is My Code

Code:java

@EventHandler
    public void onSignChange(SignChangeEvent event){
    if (event.getLine(0).equalsIgnoreCase("[Melee]")) {
    event.setLine(0, "§3[Melee]");
    event.setLine(1, "§3Click here");
    }
    }
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
    if (!(event.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
    if (event.getClickedBlock().getState() instanceof Sign) {
    Sign s = (Sign) event.getClickedBlock().getState();
    if (s.getLine(0).equalsIgnoreCase("§3[Melee]")) {
    event.getPlayer().sendMessage("[" + ChatColor.GOLD + "DeluXePvP" + "" + ChatColor.GRAY + "]" + " You Were Given The Melee Kit!");
    }
    }
    }
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args){
    if(label.equalsIgnoreCase("Melee")){
    if(!(sender instanceof Player)){
    sender.sendMessage(ChatColor.RED + "[DeluXePvP] You Must Be A Player To Get The Melee Kit!");
    return true;
    }
    //Melee Kit
    if(label.equalsIgnoreCase("Melee")){
    if(!(sender instanceof Player)){
    sender.sendMessage(ChatColor.RED + "[DeluXePvP] You Must Be A Player To Get The Melee Kit!");
    return true;
    }
    Player player = (Player) sender;
    Location location = player.getLocation();
    player.sendMessage("[" + ChatColor.GOLD + "DeluXePvP" + "" + ChatColor.GRAY + "]" + " You Were Given The Melee Kit!");
    player.playSound(location, Sound.ITEM_PICKUP, 1, 1);
    player.getInventory().clear();
    player.getActivePotionEffects().clear();
    player.getInventory().addItem(new ItemStack(Material.IRON_SWORD));
    ItemStack meleeBootsItemStack = new ItemStack(Material.IRON_BOOTS, 1); //Melee's Boots
    meleeBootsItemStack.addEnchantment(Enchantment.PROTECTION_EXPLOSIONS, 4);
    ItemStack meleeHelmetItemStack = new ItemStack(Material.IRON_HELMET, 1); //Melee's Helmet
    meleeHelmetItemStack.addEnchantment(Enchantment.PROTECTION_EXPLOSIONS, 4);
    player.getInventory().setHelmet(new ItemStack(meleeHelmetItemStack));
    player.getInventory().setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
    player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS));
    player.getInventory().setBoots(new ItemStack(meleeBootsItemStack));
    return true;
    }
    }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

badboysteee98 Actually, when you only use it once, there's no need to make a variable out of it, and he only used it once. Plus the "use this code" line you suggested doesn't make any sense anyway. And you don't let him know about checking for nulls.

DeluXeNationMC Well you'd either copy the code, or you could look into dispatchCommand()

 

badboysteee98 declaring a player variable and then assign it to itself casted to its own type...that's good practice? Am I missing something?

 

I would not copy the code i am here to learn. I would just like you to point me in the right direction

 

DeluXeNationMC I meant copy it from the command that (I assume) you have already made.

 

Oh sorry about that, read it wrong
I copy/pasted the code:

Code:java

@EventHandler
    public void onSignChange(SignChangeEvent event){
    if (event.getLine(0).equalsIgnoreCase("[Melee]")) {
    event.setLine(0, "§3[Melee]");
    event.setLine(1, "§3Click here");
    }
    }
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
    if (!(event.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
    if (event.getClickedBlock().getState() instanceof Sign) {
    Sign s = (Sign) event.getClickedBlock().getState();
    if (s.getLine(0).equalsIgnoreCase("§3[Melee]")) {
    event.getPlayer().sendMessage("[" + ChatColor.GOLD + "DeluXePvP" + "" + ChatColor.GRAY + "]" + " You Were Given The Melee Kit!");
    Player player = (Player)event;
    Location location = player.getLocation();
    player.playSound(location, Sound.ITEM_PICKUP, 1, 1);
    player.getInventory().clear();
    player.getActivePotionEffects().clear();
    player.getInventory().addItem(new ItemStack(Material.IRON_SWORD));
    ItemStack meleeBootsItemStack = new ItemStack(Material.IRON_BOOTS, 1); //Melee's Boots
    meleeBootsItemStack.addEnchantment(Enchantment.PROTECTION_EXPLOSIONS, 4);
    ItemStack meleeHelmetItemStack = new ItemStack(Material.IRON_HELMET, 1); //Melee's Helmet
    meleeHelmetItemStack.addEnchantment(Enchantment.PROTECTION_EXPLOSIONS, 4);
    player.getInventory().setHelmet(new ItemStack(meleeHelmetItemStack));
    player.getInventory().setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
    player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS));
    player.getInventory().setBoots(new ItemStack(meleeBootsItemStack));
    }
    }
    }

But it only sends me a message [DeluXePvP] you were given the melee kit and displays an error in the console "Could not pass event playerinteractevent to deluxepvp eventexeption"

I guess it would be easier to use dispatchCommand()
but i have no clue on how to use it

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

DeluXeNationMC Normally it's best to give the full stack trace so that we can know exactly what the problem is Luckily I don't need it in this case.

PHP:

Player player = (Player)event;

Do you see what's wrong with trying to do this?

Rocoty He just really wanted to make it clear it was a Player.

 

I am casting the player to the event?

 

DeluXeNationMC You're casting the event to a player. An event isn't a player, so you get a problem. You meant to use event.getPlayer()

 

Surly you meant "Player player = event.getPlayer();"

 

TGRHavoc Without the cast.

 

Wow... thanks that was dumb of me....
it does not give any console errors anymore but it does not give me any item when i right click the sign.

 

DeluXeNationMC
Try adding some debug lines (Messages/Broadcasts) to see if the code is adding the items to the inventory or not.

 

It is getting fired it sends me a message [DeluXePvP] You Were Given The Melee Kit.

 

DeluXeNationMC
Player.updateInventory() might work..

 

Awesome ! it works i will keep the Player.updateInventory(); in mind from now on
Thank you so much everyone that helped!

 

DeluXeNationMC
No problem, Glad I could help.