Having trouble with a chat plugin

Hey, so I'm trying to develop a plugin for a sort of RP chat, and it is giving me an internal error. I think I know why this is happening but my question is can I fix it? is there another way to write this?

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
    if (cmd.getName().equalsIgnoreCase("s")) {}
        Player Sender = (Player) sender;
        Player Receiver = (Player) Sender.getNearbyEntities(10, 10, 10);
 
        if(args.length == 0)
            Sender.sendMessage(Color.RED + "Usage: /s <Message>");
 
        if(args.length > 0)
            Sender.sendMessage(Sender + ":" + args[0]);
            Receiver.sendMessage(Sender + ":" + args[0]);           
    return true;}}

Error being here: Player Receiver = (Player) Sender.getNearbyEntities(10, 10, 10);

 

Entities is plural, Player is not

 

I don't follow...

 

The getNearbyEntities method returns multiple entities, you are assuming there's only one player in the given radius. I would use a for-loop and then send the message.

 

Ah, I tried that one before but I couldn't get it to work

 

Post what you did and we could help you fix it.

 

Player receiver = null;
for (Entity en : Sender.getNearbyEntities(10,10,10)) {
if (en instanceof Player) {
receiver = (Player) en;
break;
}
}
if (Receiver != null) {
//receiver found
}

 

Thank you very much, both of you

 

Please don't spoonfeed! >.< It's the worst thing you can do when trying to really help someome else.

 

Only if they take the code and don't analyze it. It's all on them.

 

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
    if (cmd.getName().equalsIgnoreCase("s")) {}

Your if is empty, making it useless.

Code:text

 
        Player Sender = (Player) sender;

NEVER EVER cast if you aren't sure you can actually cast the object. If you're command is run from the console or from rcon, you're getting a ClassCastException here.
Use instanceof to check whether the sender is a player.

Also please use lowerCamelCase for variable names!

Code:text

 
        Player Receiver = (Player) Sender.getNearbyEntities(10, 10, 10);
 

Already said. Don't you use an IDE? That should have told you you're mistake. Also look at the docs: http://jd.bukkit.org

Code:text

 
        if(args.length == 0)
            Sender.sendMessage(Color.RED + "Usage: /s <Message>");
 

Great, you check whether all required arguments have been passed. But you dont return; the method if there weren't any arguments send, which will cause an ArrayIndexOutOfBoundsException later.

Code:text

 
        if(args.length > 0)
            Sender.sendMessage(Sender + ":" + args[0]);
 

just for your information: if a user inputs multiple words, they will be treated as multiple arguments. So if I type
/yourCommand Hi there!
You're getting two arguments. You'd probably want to send them all.

 

Yes, I am using Eclipse, for some reason it didn't show that as an error :/
also, what would I put for sending all arguments? I haven't come across that before

 

String msg = "";
for (String s : args) {
msg += s + " ";
}

Basically.

 

I think I understand this. Thank you