HashMap Help!

Hello everyone!
I am stuck on some HashMap work on my plugin,
I am trying to check if anyone has a value of 0 in the HashMap
if yes they will be kicked out of it!
btw this is in an event because I want it to subtract 1 from the player every time the event fires

Code:java

 if(map.containsKey(((Player) shooter).getName())) {
for(Entry<String, Integer> entry : map.entrySet()) {
if(entry.getValue().equals(0)) {
map.remove(entry.getKey());
}
}
map.put(((Player) shooter).getName(), map.get(((Player) shooter).getName()) - 1);
}

 

on the line:

Code:java

 map.put(((Player) shooter).getName(), Minebow.get(((Player) shooter).getName()) - 1);

wouldn't the kicked out player be in the map again?

 

Gingerbreadman you can't remove elements whilst iterating over the Map.

 

fireblast709 He doesn't iterate over the Map though, does he? He's iterating over the entry set.

 

AdamQpzm Almost the same thing He's going to have to use an iterator, instead.

 

I don't even think you need the for loop because hashmaps have key/value pairs. There will always be only one value associated with only that name. So just setting it again will wipe out the value.
(This is assuming I understand what you're trying to do with your code, let me know if I got the wrong idea.)

Code:java

if(map.containsKey(((Player) shooter).getName())) {
 
  if(map.get(((Player)shooter).getName()) == 0){
 
      map.put(((Player) shooter).getName(), Minebow.get(((Player) shooter).getName()) - 1);
 
  }
 
}

Also, you were using .equals to compare to a number, which you usually don't do (unless there's something in the Entry class that I don't get.

 

Abs0rbed Lolmewn AdamQpzm fireblast709 I am trying to do this
[Player, 10] - This is an example of someone in the Hashmap
I want it to check if that player [shooter] has more than 1 in the HashMap
Then if they do it will subtract one else they get removed from list

 

Gingerbreadman
So basically like this:

Code:

if(map.containsKey(player)){
    map.put(player, map.get(player) -1);
    if(map.get(player) == 0){
        map.remove(player);
    }
}

Or something?

 

That makes sense. You can just use a simple if-else to check what the value is, then perform changes accordingly

Code:java

if(map.containsKey(((Player) shooter).getName())) {
 
  if(map.get(((Player)shooter).getName()) < 0){
 
      map.put(((Player) shooter).getName(), Minebow.get(((Player) shooter).getName()) - 1);
 
  }else{
 
      map.remove(((Player)shooter).getName());
 
  }
 
}

 

Abs0rbed Lolmewn Thanks for the help!