Solved HashMap ContainsKey

I'm currently trying to determine whether or not a block which is broken by a player is within a HashMap containing both a Location and an Integer. Of course, the Location of the block is used. I've printed both HashCodes of the respected Locations being compared, and they were identical. It would appear I am missing something, so any and all help is greatly appreciated. There are no compiler errors, the if(blockRespawn.containsKey(loc)){ just never seems to pass.

The onCommand method places the block directly in front of the player which is not air in to the first Map "BlockRespawn" as a Location with the first argument parsed to an integer as the value for the key (and appears to work in game due to some current debug functionality). The specified location is later checked to see if that matches up with the block a player breaks.

Code:java

 public Map<Location,Integer> blockRespawn = new HashMap<Location,Integer>();
public Map<Location,Integer> blockQueue = new HashMap<Location,Integer>();
 
public void onEnable(){
getConfig().options().copyDefaults(true);
saveConfig();
getServer().getPluginManager().registerEvents(new Resources(), this);
getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable(){
 
public void run(){
//to be implemented
}
 
 
}
 
}, getConfig().getInt("delay"),getConfig().getInt("interval"));
 
}
 
public void onDisable(){
 
 
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
if(cmd.getName().equalsIgnoreCase("resourceset") && sender.hasPermission("antiochresources.setresource") && args.length > 0 && sender instanceof Player){
Player pl = (Player) sender;
 
Block target = pl.getTargetBlock(null, 1);
int health;
 
if(target.getType().equals(Material.AIR)){
sender.sendMessage(ChatColor.RED + "Block is invalid, try again.");
return false;
}
 
Location targetLoc = target.getLocation();
 
 
 
try{
health = Integer.parseInt(args[0]);
}catch (NumberFormatException nx) {
return false;
}
 
blockRespawn.put(targetLoc, health);
System.out.println(targetLoc.hashCode());
sender.sendMessage(ChatColor.GREEN + targetLoc.toString() + " added to the blockRespawn listing.");
sender.sendMessage(ChatColor.YELLOW + target.getType().toString());
 
return true;
}
 
 
return false;
}
 
@EventHandler
public void onBlockBreak(BlockBreakEvent b){
b.setCancelled(true);
Block bl = b.getBlock();
Location loc = bl.getLocation();
 
if(blockRespawn.containsKey(loc)){
bl.setType(Material.BEDROCK);
blockQueue.put(loc,blockRespawn.get(loc));
b.getPlayer().sendMessage(ChatColor.AQUA + loc.toString() + " added to blockQueue.");
}
 
bl.breakNaturally();
 
}
 
}
 

 

You should be using strings instead of the locations themselves as keys. The containsKey method first checks if the objects' hash codes are equal, and if that returns true, then checks if the objects themselves are equal (using their equals method, which would return false, unless you were using the exact same location object as before). You might want to use Location's toString method as the key.

 

That's not true. Location has an implementation of both hashcode and equals.

 

Thanks for pointing that out to me. I hadn't noticed. However, I would still recommend using strings as keys anyway, seeing as comparing worlds may not be reliable. I would try and see if using strings as keys fixes anything.

Edit: Ignore that link. I just noticed it's extremely outdated information. Regardless, I would still try using strings.

 

Hoot215 https://github.com/TheDgtl/CraftBukkit/commit/486d9c4afd4dcc32e2dcfc5bb2cc54ab8fb3ad36 Fixed a long time ago.

Fuzzwolf Are you registering your events for your main class? I see you registering them for your "Resources" class, but not for you JavaPlugin.

 

evilmidget38 Hoot215 Thanks for the help both of you, I actually figured out the solution but was not able to implement it until I got home. I needed to restrain the Maps to a static context so that it would belong to the class instead of an instance. It's been a while, heh...