Getting all the online players usernames

Hey everyone, I'm working on a social spy plugin. I'm trying to make it so if any online player types "/msg" it will show people with a permission node what they typed. But I can't figure out how to get all the online players usernames.

Here is my current code:

Code:java

package me.BrushPainter.SpyChat;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
 
public void onEnable() {
FileConfiguration config = getConfig();
 
config.addDefault("SpyChat.OP_Only", "true");
 
config.options().copyDefaults(true);
saveConfig();
 
getLogger().info("SpyChat Enabled");
 
this.getServer().getPluginManager().registerEvents(this, this);
}
 
public void onDisable() {
 
getLogger().info("SpyChat Disabled");
 
}
 
ArrayList<String> players = new ArrayList<String>();
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e){
Player player = e.getPlayer();
players.add(e.getPlayer().getName());
if(player.hasPermission("onjoin.autospy")) {
Bukkit.dispatchCommand(Bukkit.getConsoleSender(), "spychat " + player);
player.sendMessage(ChatColor.GOLD + "SpyChat enabled.");
 
}
}
 
public boolean onCommand(CommandSender sender, Command cmd, String Label, String[] args){
 
if (sender instanceof Player)
{
 
if (sender.hasPermission("brushpainter.spy"))
{
 
if (cmd.getName().equalsIgnoreCase("spychat"))
{
 
if (!players.contains(e.getPlayer().getName()))
 
players.getMessage().equalsIgnoreCase("/msg");
{
 
}
}
}
}
return false;
}
}

But on lines 62 and 64 I get errors:
62: e cannot be resolved
64: The method getMessage() is undefined for the type ArrayList<String>

EDIT: I know that the config does not do anything at this point, I just added it for now.

 

How to get all online usernames:

Code:java

for(Player online : bukkit.getServer().getOnlinePlayers()){
 
//use online.getName(); to return a name
 
}

 

Just note that the 'b' in the Bukkit class name should be capitalized.

 

Oops.

 

ColaCraft

Yes it does.

 

Aqua

Meh. My bad. Eclipse automatically capitalized it, wasn't paying attention.

 

ColaCraft amhokies Thanks guys, I still get an error "The method getMessage() is undefined for the type Player" on line 63:

Code:java

package me.BrushPainter.SpyChat;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
 
public void onEnable() {
FileConfiguration config = getConfig();
 
config.addDefault("SpyChat.OP_Only", "true");
 
config.options().copyDefaults(true);
saveConfig();
 
getLogger().info("SpyChat Enabled");
 
this.getServer().getPluginManager().registerEvents(this, this);
}
 
public void onDisable() {
 
getLogger().info("SpyChat Disabled");
 
}
 
ArrayList<String> players = new ArrayList<String>();
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent e){
    Player player = e.getPlayer();
    players.add(e.getPlayer().getName());
    if(player.hasPermission("onjoin.autospy")) {
        Bukkit.dispatchCommand(Bukkit.getConsoleSender(), "spy " + player + "");
        player.sendMessage(ChatColor.GOLD + "Socialspy enabled.");
 
    }
}
 
public boolean onCommand(CommandSender sender, Command cmd, String Label, String[] args){
 
    if (sender instanceof Player)
    {
 
      if (sender.hasPermission("brushpainter.spy"))
      {
 
      if (cmd.getName().equalsIgnoreCase("spy"))
      {
          for(Player online : Bukkit.getServer().getOnlinePlayers()){
 
              online.getMessage().equalsIgnoreCase("/msg");
 
 
            }
 
        }
}
}
    return false;
        }
}

 

BrushPainter

What you are doing right now (lines 61-66) does not accomplish anything. You can however, do something like this:

Code:java

public static ArrayList<String> playersSpying = new ArrayList<String>();
 
@EventHandler
public void commandPreprocess(PlayerCommandPreprocessEvent event) {
String msg = event.getMessage();
String[] split = msg.split(" ");
if (!split[0].startsWith("/"))
return;
String command = split[0];
if (command.equalsIgnoreCase("tell") || command.equalsIgnoreCase("msg")) {
StringBuilder sb = new StringBuilder();
for(int i = 1; i < split.length; i++){
sb.append(split[I]+" ");[/I]
[I] }[/I]
[I] String message = sb.toString().trim();[/I]
[I] for(String playerName : playersSpying){[/I]
[I] Player player = Bukkit.getPlayerExact(playerName);[/I]
[I] player.sendMessage("[Private Msg] "+ event.getPlayer().getName()+": "+message);[/I]
[I] }[/I]
[I] }[/I]
[I] }[/I]

[/I]
That basically checks if a command is /msg or /tell etc and then if it is, send the message to all the players who are in the arraylist playersSpying.

 

mrkirby153 Thank you sooo much man! I truly appreciate it.

 

BrushPainter

Does it work? I haven't tested it