getInventory() Help

I have been using the getInventory() method to check if it has an item with a certain display name and then removes one of those items on a onRightClick() event. It has a NullPointerException and I am not sure why here is my code

Code:java

 
public class EventListener extends JavaPlugin implements Listener
{
 
@EventHandler(priority = EventPriority.NORMAL) public void onPlayerUse(PlayerInteractEvent event) 
{
        Player p = event.getPlayer();
        {
            if (p.getItemInHand() != null) {
                if ((event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.RIGHT_CLICK_AIR) && itemCheck(p)) 
                {
               for(ItemStack i : p.getInventory().getContents())
               {
 
               if(i.hasItemMeta())
                   {
               ItemMeta a = i.getItemMeta();
               a.getDisplayName();
                   if(a.getDisplayName()==("Cougar-Magnem Ammo"))
                   {
                   p.sendMessage("Fire");
                   }
                   }
 
               }
                   p.getInventory();
                } else if (event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.RIGHT_CLICK_AIR) 
                {
                    //nothing
                }
            }
        }
    }
 
public boolean itemCheck(Player player)
{
    ItemStack i = player.getItemInHand();
    if(i == null)return false; // Fail the test if there is no item in hand
    if(!i.hasItemMeta())return false; // Fail the test if item does not have metadata
    ItemMeta im = i.getItemMeta();
    if(!im.hasDisplayName())return false; // Fail the test if the item doesn't have a display name
    String dn = im.getDisplayName();
    return dn.indexOf("Cougar-Magnem Ammo") == -1 && dn.indexOf("Cougar-Magnem") > -1;
}
}
 

Here is my StackTrace

Code:

Caused by: java.lang.NullPointerException
        at com.brendannoble.goldeneye.EventListener.onPlayerUse(EventListener.ja
va:27)
        at sun.reflect.GeneratedMethodAccessor11.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:425)
        ... 16 more
>

 

Maybe check if a.hasDisplayName() first.

 

Ok, thanks for the tip

That didn't seem to work here is my updated code (it still has the same stacktrace)

Code:java

 
public class EventListener extends JavaPlugin implements Listener
{
 
@EventHandler(priority = EventPriority.NORMAL) public void onPlayerUse(PlayerInteractEvent event) 
{
        Player p = event.getPlayer();
        {
            if (p.getItemInHand() != null) {
                if ((event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.RIGHT_CLICK_AIR) && itemCheck(p)) 
                {
               for(ItemStack i : p.getInventory().getContents())
               {
 
               if(i.hasItemMeta())
                   {
               ItemMeta a = i.getItemMeta();
               a.hasDisplayName();
               a.getDisplayName();
                   if(a.getDisplayName()==("Cougar-Magnem Ammo"))
                   {
                   p.sendMessage("Fire");
                   }
                   }
 
               }
                   p.getInventory();
                } else if (event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.RIGHT_CLICK_AIR) 
                {
                    //nothing
                }
            }
        }
    }
 
public boolean itemCheck(Player player)
{
    ItemStack i = player.getItemInHand();
    if(i == null)return false; // Fail the test if there is no item in hand
    if(!i.hasItemMeta())return false; // Fail the test if item does not have metadata
    ItemMeta im = i.getItemMeta();
    if(!im.hasDisplayName())return false; // Fail the test if the item doesn't have a display name
    String dn = im.getDisplayName();
    return dn.indexOf("Cougar-Magnem Ammo") == -1 && dn.indexOf("Cougar-Magnem") > -1;
}
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Replace

Code:java

} else if (event.getAction() == Action.RIGHT_CLICK_BLOCK || event.getAction() == Action.RIGHT_CLICK_AIR) 

with

Code:java

} else if (event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction.equals(Action.RIGHT_CLICK_AIR))

and see if that works

 

That isn't the problem the problem is at if(i.hasItemMeta(){}

 

that changed the ';' and ')' to remove the ';' after hasItemMeta()

 

You need a null check on each inventory item

for (ItemStack i : p.getInventory().getContents()){
if (i !=null ){
//carry on
}
}getInventory().getContents())

 

Ok thanks I will try that