Get the player from EntityDeathEvent

Code:

Code:java

 
@SuppressWarnings("static-access")
@EventHandler
public void PlayerKilledZombie(EntityDeathEvent event)
{
Entity entity = event.getEntity();
Player player = (Player) event.getEntity();
 
ItemStack[] isword = {new ItemStack(Material.IRON_SWORD)};
 
if(entity.getType().ZOMBIE != null){
if(event.getEntity().getKiller().equals(player)){
if(player.hasPermission("zday.isword.smitehp")){
if(player.getItemInHand().equals(isword) && player.getItemInHand().containsEnchantment(Enchantment.DAMAGE_UNDEAD)){
     player.setHealth(player.getHealth() + 2);
if(plugin.getConfig().getString("debug").equals("true")){
     player.sendMessage("You just killed a zombie.");
}
  }
}
}else{
player.sendMessage("" + event.getEntity().getKiller());
}
}
}
 

My error is:

Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_6_R2.entity.C
raftBat cannot be cast to org.bukkit.entity.Player
at com.zombie.test.ZombieSpawn.PlayerKilledZombie(ZombieSpawn.java:75)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:425)
... 24 more

 

What line is the error on? Also, post your whole EventHandler method so we can see what each of your variables are.

 

adde
event.getKiller() returns he killer. No need for getting the entities killer

 

"ply" is event.getDamager();

Wops, sorry, didn't see that I used entity instead of event, that's why I got confused.

 

why are you using EntityDamageByEntityEvent? use EntityDeathEvent

 

Someone? Bump...

 

check if the entity is not a player before you assume it is. that will give errors.

 

Well, how would I do this?

 

well that is pretty basic stuff though, quick and easy: if(!event.getEntity() instanceof Player) return;

 

Okey, now what?
Should I keep my player variable as it is and see if it works after I added the check?

 

If its not an instance of a plater, just end the bracket and then make an else statement with event.getKiller()

 

That didn't work :/

edit:
check first post, edited it.

 

well now you changed the event... what is it that you want to accomplish exactly?

 

Lol I forgot to change the thread title.

I want to give 2 hp to the player when they kill a zombie with the required stuff, it worked but printed errors, then I tried to change the code to not get any error and now it doesn't work at all.

 

aha. then do event.getKiller and check if the killer is a player, then do your stuff

 

Can you post your current code now, Adde? (If you remember me)

 

It is at the top.

 

Re-wrote it for you, didn't test it, though

Code:java

    @EventHandler
    public void PlayerKilledZombie(EntityDeathEvent event){
        Entity entity = (Entity)event.getEntity();
        if(entity.getLastDamageCause().getCause() != DamageCause.CUSTOM || entity.getLastDamageCause() instanceof Entity){
            Entity ent = (Entity) entity.getLastDamageCause();
            if(ent instanceof LivingEntity || ent instanceof Player){
                Player player = (Player)entity.getLastDamageCause();
                ItemStack isword = new ItemStack(Material.IRON_SWORD);
                if(entity instanceof Zombie){
                    if(player.hasPermission("zday.isword.smitehp")){
                        if(player.getItemInHand() == isword && player.getItemInHand().containsEnchantment(Enchantment.DAMAGE_UNDEAD)){
                            player.setHealth(player.getHealth() + 2);
                            if(plugin.getConfig().getBoolean("debug")){
                                player.sendMessage("Killed a zombie");
                            }
                        }
                    }
                }
            } else Bukkit.getLogger().log(Level.INFO, entity.getLastDamageCause().getEntity().toString());
        }
    }

Reckon that's fixed to xTrollxDudex 's liking!

 

kreashenz
The last damage casue isnt always and entity :3
(event.getLastDamageCause().getEntity())
What if the killer was /kill <player>?

 

xTrollxDudex Smart thinking, mate.

 

Its mediocre....

PHP:

//entity death event
//whoops, need to check the javadocs again! Its event.getEntity().getKiller()
if(event.getEntity().getKiller() instanceof Player && event.getEntity() instanceof Zombie){

Player killer = (Player) event.getEntity().getKiller();
ItemStack item = new ItemStack(Material.IRON_SWORD);
ItemStack inhand = killer.getItemInHand();

if(killer.hasPermission("zday.issword.smitehp") && inhand.equals(item) && inhand.containsEnchantment(Enchantment.DAMAGE_UNDEAD) && plugin.getConfig().getBoolean("debug")){

killer.setHealth(killer.getHealth() + 2);
killer.sendMessage("Killed a Zombie");

}}

 

Didn't work.
No error but doesn't print the message or giving me 2 hearts, also tried to remove the getConfig thingy.

 

adde
Either:
You didn't register correctly, didn't make the listener correctly
Didn't op yourself or give permissions
Didn't move some brackets around

 

xTrollxDudex adde
I discovered that getKiller has a problem with projectiles. Namely that the killer is the arrow or potion, not the player. This needs much more IF statements to account for player arrows and potions.

 

Zethariel
Interesting! I'll look into that.

 

1. Yes, I did register as I did get an error last time so the listener "worked". I have other methods in same class that works.
2. I did OP me.
3. I did move brackets, putting them in if statements each of them but you did &&

 

xTrollxDudex Thus my killer instanceof Player

 

The entire code you need:

Code:java

    @EventHandler
    public void onDeath(EntityDeathEvent event){
        if(event.getEntity().getKiller() instanceof Arrow){
            Arrow arrow = (Arrow) event.getEntity().getKiller();
            if(arrow.getShooter() instanceof Player && event.getEntity() instanceof Zombie){
                giveHealth(arrow.getShooter());
            }
        }else if(event.getEntity().getKiller() instanceof Player && event.getEntity() instanceof Zombie){
            giveHealth(event.getEntity().getKiller());
        }
    }
 
    public void giveHealth(LivingEntity player){
        ((Player)player).setMaxHealth(player.getMaxHealth()+2);
    }

well almost, except the health and permission part

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Nvm. Sccch.