Error with constructor?

I'm not sure what's the error here, though I'm getting spammed in my console with object/constructor errors. In my mind I don't see what's wrong..?

Stacktrace(Only put one.. showing them being spammed is useless):

Code:

at me.Wes.VillageSnipe.GameManager.<init>(GameManager.java:25) ~[?:?]
at me.Wes.VillageSnipe.Scoreboards.<init>(Scoreboards.java:23) ~[?:?]

Line 25 of GameManager:

Code:java

Scoreboards Scoreboards = new Scoreboards();

Line 23 of Scoreboards:

Code:java

GameManager GameManager = new GameManager();

Thanks in advance.

 

WesJD
I think you created a loop.
Whenever you create an instance of GameManager it will create an instance of Scoreboards which creates an instance of GameManager which creates an Instance of Scoreboards etc.

Maybe do Scoreboards(GameManager manager) instead.

 

mrCookieSlime
As in...

Code:java

Scoreboards Scoreboards = new Scoreboards(GameManager GameManager);

?
Or am I over thinking it?

 

WesJD
... I mean that you better want to add a GameManager argument to your constructor so you use an existing instance rather than creating a new one.

 

He means put your GameManager instance as the parameter for the constructor.

 

Skionz
Could you give me an example? I'm not quite getting it..

 

Code:

Scoreboards scoreboard = new Scoreboards(yourGameManagerInstance);

Personally I have never used scoreboards before and I am just following what mrCookieSlime has said.

 

Skionz
Though what would my instance be? Plugin...?

 

Your instance of the GameManager class

 

What ever you want it to be. It is your code and not mine.

 

teej107 Skionz
Then basically I'm doing what is above. Just gives me an error in Eclipse? This is what I have now:

Code:java

GameManager manager;
Scoreboards Scoreboards = new Scoreboards(manager);

 

WesJD First off you probably shouldn't capitalize the first letter of variable. Second of all you will probably have to initialize manager. Third you need to tell us what the error says.

EDIT: And what is the "Scoreboards" class? Is it built in because I couldn't find it on the javadocs.

 

Skionz
The Scoreboards class is a class in my package.

 

WesJD Let me take a guess at your error. It's because the constructor of Scoreboards doesn't accept GameManager in its constructor parameters. Is this right?

 

teej107
Yup.

 

WesJD So you got it fixed then?

 

Did you make this class? If so shouldn't you know how to use it? If not give us a link to whatever your using.

 

teej107
Nope.

Skionz
I did create it. It's a class creating scoreboards. I'm in need to access it due to methods I need.

 

WesJD Is it a class that you made?

 

WesJD

Still doesn't mean that it should be capitalized.

What's the issue you have?

 

teej107
Yes, I'm editing a variable within the class to update a player's score.

 

For future reference, please provide the full stacktrace.

 

WesJD Well I think you gotten your answer on how to fix the error.

 

mythbusterma
When creating the instances they create each other, making a loop that breaks the plugin.

 

WesJD

So don't do that.

 

WesJD I thought you fixed that right? And now you are having problems with sending an Object instance through a parameter.

 

mythbusterma
I'd rather not use statics.

 

WesJD

I'd prefer you didn't either. I meant don't create cyclical constructors.

 

mythbusterma
Both classes need to access each other. Am I just being dumb right now? lol

 

WesJD Not to sound harsh but yes!