Solved EntityDeathListener

Hello, I am trying to use this entity death listener, however it just does not work. Any idea why?

Code:java

package com.kmccmk9.ZombieSiege;
 
import java.sql.ResultSet;
 
import org.bukkit.Server;
import org.bukkit.entity.Creature;
import org.bukkit.entity.LivingEntity;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
 
public class entityListener implements Listener {
    //Global Vars
    LivingEntity chicken;
    Server server2;
 
    public entityListener(Server server,LivingEntity chick) {
        chicken = chick;
        server2 = server;
    }
    public void onEntityDeath(EntityDeathEvent event)
    {
        // Who died?
        System.out.println("Someone died");
        LivingEntity deadentity = event.getEntity();
        System.out.println(deadentity + " is dead");
    }
}
 

 

One of the first things that pops out to me is that you are missing @EventHandler above your onEntityDeath function. Try that, and see if it works better.

 

Thank you! That worked so well. Don't know how I missed that. Also, would you know why a comparison of if (deadentity==chicken) would not work? Is it because one is a livingentity and one is a deadentity?

 

dont compare Objects with ==. Use equals.
http://stackoverflow.com/questions/7520432/java-vs-equals-confusion

 

From what I can see, they are both of the LivingEntity type. Only thing I can assume is that chicken is not being set. and so it's checking if deadentity==null, which it most likely won't be.

AmShaegar:

Not exactly. He is checking to see if the two set entities are the same entity, so he can use ==.

 

Basically all I want to do is check if my spawned entity was killed.

 

kmccmk9

Well then you need to handle setting the LivingEntity chicken when you spawn it. I don't see that happening. If you initialized it in another class, you may need to make it public (and possibly also static).

 

Okay I did that here in my main class, which does work:

Code:

chicken = world.spawnCreature(tower, CreatureType.CHICKEN);

The chicken is a global variable and I pass it to the listener like so:

Code:

        entityListener eListener = new entityListener(server, chicken);
        Bukkit.getServer().getPluginManager().registerEvents(eListener , this);

 

kmccmk9:

I've looked up and down the code, not exactly sure where it's going wrong. Does it change/fix it when you use .equals? If not, I'll write up a quick test class and see if I get different results. Much easier to debug when actually running the code =P

 

Unfortunately it does not, it seems to have no effect. One thing I noticed though, is that when I first start the world, if a entity dies (like from sun) it throws an error dealing with the if statement. Is it possible that once it receives this error it won't work there on? I have had a plugin do that to me once before.

Much agree btw

 

The only reason the listener would stop working is if there was a fatal crash (aka server death). Instead, it would just keep throwing errors for each offending event that correlated to it. I'll keep looking at it. Have to go somewhere in an hour or so. Hopefully can whip up a test class for it quick enough.

 

Ok great, I appreciate it!

 

kmccmk9

Alright, so... after doing some quick testing, I'm not sure what's going wrong with your plugin. For me, it works perfectly fine...

Code:

Code:

if(deadentity==chicken)
        {
            System.out.println("bye bye chicken =(");
        }

Log:

Code:

17:10:27 [INFO] Someone died
17:10:27 [INFO] CraftChicken is dead
17:10:27 [INFO] bye bye chicken =(

The only thing I can think is that spawnCreature, CreatureType are deprecated. I changed them all to Entity types from LivingEntity, and did spawnEntity(tower, EntityType.CHICKEN). Maybe try that and see?

 

Thanks for the response, but if I do this, I have no way of targeting another entity right?
EDIT: This code makes the zombie target, but the death no longer works. Would it be help if I posted more of my code?

Code:

Entity zombie = world.spawnEntity(to, EntityType.PIG_ZOMBIE);
                            ((Creature) zombie).setTarget((LivingEntity) chicken);

 

kmccmk9:

Really? It works perfectly for me:

Code:

        chicken = world.spawnEntity(tower, EntityType.CHICKEN);
        Entity zombie = world.spawnEntity(tower, EntityType.PIG_ZOMBIE);
        ((Creature) zombie).setTarget((LivingEntity) chicken);
 
 
14:15:44 [INFO] ERROR372: Reload complete.
14:15:44 [INFO] Someone died
14:15:44 [INFO] CraftChicken is dead
14:15:44 [INFO] bye bye chicken =(

The pig zombie targets the chicken, and when the chicken dies, it displays that the chicken did in fact die, with the appropriate message (bye bye chicken =( )

 

I have no idea what's wrong with my code then. Its exactly the same. Mine sets the target but won't display the kill message. I guess here is my listener:

Code:java

package com.kmccmk9.ZombieSiege;
 
import java.sql.ResultSet;
 
import org.bukkit.ChatColor;
import org.bukkit.Server;
import org.bukkit.entity.Creature;
import org.bukkit.entity.Entity;
import org.bukkit.entity.LivingEntity;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
 
public class entityListener implements Listener {
//Global Vars
Entity chicken;
Server server2;
 
public entityListener(Server server,Entity chick) {
chicken = chick;
server2 = server;
}
@EventHandler
public void onEntityDeath(EntityDeathEvent event)
{
Entity deadentity = event.getEntity();
if (deadentity == chicken)
{
server2.broadcastMessage(ChatColor.RED + "You have failed! The tower has beenn lost!");
}
else {
//nothing
}
}
}
 

EDIT: I can post my main if that would help too.