Engineer Class help CTF

Hey, i was wondering if anyone could help me with this Custom class for the CTF plugin. I have already started it, and have the turret to where it will work, then destroy itself when the owner dies or when it runs out of ammo. Please let me know if i have developed any bad habits here or if anything would make this cause memory leaks. Here is the source:

Show Spoiler Hide Spoiler

Code:java

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
 
import net.askarian.MisterErwin.CTF.API.CtFClass;
 
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.block.BlockFace;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Bat;
import org.bukkit.entity.Entity;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.HandlerList;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.BlockPlaceEvent;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.util.Vector;
 
public class Engineer extends CtFClass implements Listener {
    private String version = "1.0";
    private String name = "Engineer";
    private String description = "Engineer class";
    private String command = "engineer";
    int ThreadID;
    Turret turret;
    Arrow arrow;
    int threaded;
    int nplayerleg;
    Location loc;
    private List<String> authors = new ArrayList();
    private HashMap<Integer, String> turrets = new HashMap();
 
    public void disable() {
        BlockPlaceEvent.getHandlerList();
        HandlerList.unregisterAll(this);
    }
 
    public void enable() {
        this.authors.add("RedstoneEditor");
 
        this.plugin.getServer().getPluginManager()
                .registerEvents(this, this.plugin);
    }
 
    public List<String> getAuthors() {
        return this.authors;
    }
 
    public String getCommand() {
        return this.command;
    }
 
    public String getDescription() {
        return this.description;
    }
 
    public String getName() {
        return this.name;
    }
 
    public String getVersion() {
        return this.version;
    }
 
    public boolean givekit(Player p) {
        PlayerInventory inv = p.getInventory();
 
        ItemStack item = new ItemStack(302, 1);
        inv.setHelmet(item);
 
        item = new ItemStack(311, 1);
        inv.setChestplate(item);
 
        item = new ItemStack(312, 1);
        inv.setLeggings(item);
 
        item = new ItemStack(305, 1);
        inv.setBoots(item);
 
        item = new ItemStack(Material.DISPENSER, 1);
        inv.addItem(new ItemStack[] { item });
        item.removeEnchantment(Enchantment.DAMAGE_ALL);
        item.removeEnchantment(Enchantment.KNOCKBACK);
 
        item = new ItemStack(364, 4);
        inv.addItem(new ItemStack[] { item });
 
        return true;
    }
 
    public boolean saytime(Player p, int time) {
        p.setLevel(time);
        return true;
    }
 
    @EventHandler
    public void playerDeath(PlayerDeathEvent event) {
        if (event.getEntity() instanceof Player) {
            Player p = (Player) event.getEntity();
            if (plugin.tm.getPClass(p) == getCommand()) {
                turret.destroy(turret.getLocation());
            }
        }
    }
 
    @EventHandler(priority = EventPriority.HIGH)
    public void onPlayerInteract(PlayerInteractEvent event) {
        if ((event.getAction() != Action.LEFT_CLICK_BLOCK)
                && (event.getAction() != Action.LEFT_CLICK_AIR)) {
            return;
        }
        if (event.getPlayer().getInventory().getItemInHand().getType() == Material.DISPENSER) {
            Turret turret = new Turret(this, event.getPlayer().getName(),
                    this.turrets.size() + 1, event.getClickedBlock()
                            .getLocation());
            this.turret = turret;
            turret.build(turret.getLocation());
            this.turrets.put(turret.getId(), event.getPlayer().getName());
            turret.fire();
        }
    }
 
    class Turret {
        String owner;
        int ammo = 64;
        int id;
        Location loc;
 
        public Turret(Engineer paramEngineer, String o, int id, Location loc) {
            this.owner = o;
            this.id = id;
            this.loc = loc;
        }
 
        public void build(Location loc) {
            loc.getBlock().getRelative(BlockFace.UP).setType(Material.FENCE);
            loc.getBlock().getRelative(BlockFace.UP, 2)
                    .setType(Material.DISPENSER);
        }
 
        public void destroy(Location loc) {
            loc.getBlock().getRelative(BlockFace.UP).setType(Material.AIR);
            loc.getBlock().getRelative(BlockFace.UP, 2).setType(Material.AIR);
            turrets.remove(getId());
            plugin.getServer().getScheduler().cancelTask(ThreadID);
            ThreadID = 0;
        }
 
        private void fire() {
            if (turrets.containsKey(getId())) {
 
                final Location l = getNextBlockUp();
 
                final Bat bat = (Bat) l.getWorld().spawnEntity(
                        l.add(0.0D, 1.0D, 0.0D), EntityType.BAT);
 
                plugin.getServer().getScheduler()
                        .scheduleSyncRepeatingTask(plugin, new Runnable() {
 
                            public void run() {
                                if (turret.ammo > 0) {
                                    int id = getId();
                                    List<Entity> lEnt = bat.getNearbyEntities(
                                            10.0D, 10.0D, 10.0D);
                                    for (Entity ent : lEnt) {
                                        if ((ent instanceof Player)) {
                                            Player p = (Player) ent;
 
                                            int h = 1;
 
                                            if (p.getLocation().distance(
                                                    bat.getLocation()) >= 8.0D) {
                                                h = 2;
                                            }
                                            if (p.isFlying()) {
                                                h = 1;
                                            }
 
                                            Vector v1 = l.toVector();
                                            Vector v2 = p.getLocation()
                                                    .add(0.0D, h, 0.0D)
                                                    .toVector();
 
                                            Vector st = v1.subtract(v2)
                                                    .normalize();
                                            st.setX(st.getX() * -1.0D);
                                            st.setY(st.getY() * -1.0D);
                                            st.setZ(st.getZ() * -1.0D);
                                            if (plugin.tm.getTeam((Player) ent) != plugin.tm
                                                    .getTeam(getOwner())) {
                                                Arrow sb = (Arrow) bat
                                                        .launchProjectile(Arrow.class);
                                                sb.setVelocity(st);
                                                ammo--;
                                                System.out.println("Ammo: "
                                                        + ammo);
                                            }
                                            bat.remove();
                                        }
                                    }
                                } else if (ammo <= 0) {
                                    plugin.getServer().getScheduler()
                                            .cancelTask(ThreadID);
                                    ThreadID = 0;
                                    destroy(getLocation());
                                }
                            }
                        }, 1L, 12L);
            }
        }
 
        public int getId() {
            return this.id;
        }
 
        public String getOwner() {
            return this.owner;
        }
 
        public Location getLocation() {
            return this.loc;
        }
 
        public Location getNextBlockUp() {
            return getLocation().getBlock().getRelative(BlockFace.UP, 3)
                    .getLocation();
        }
    }
}

 

Maybe put the Turret in its own class, and create a class for the runnable? It's getting quite difficult to read...

 

The plugin won't allow multiple classes per "class".

 

renaud444
You don't have to put a class in a class, you can create a new class file and put it there.

 

The plugin api WONT let you. It causes errors

It said something about "If you have more than one class file, Multiply them." I am wondering what that means.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Create a file for each class.

 

I know that the pluginn requires that each java class be in one file!

 

Well, I don't know that plugin, and I don't know the API, so I can't help you there. Maybe ask on that plugin's forum?

 

The plugin creator is on vacation with school

 

renaud444
Plugin issues aside,

Code:java

 
private String version = "1.0";
private String name = "Engineer";
private String description = "Engineer class";
private String command = "engineer";
// snip
private List<String> authors = new ArrayList();
private HashMap<Integer, String> turrets = new HashMap(); 
 

In your class header, you should consider making some of these variables final. For example, Your "version" variable won't be changing at runtime, and neither is your name, description, or possibly command. It makes your code much easier to maintain because you will prevent access to variables that shouldn't be granted access to.

Again, make authors and turrets final as well. These have methods that allow you to modify the method, and there should be no need to redeclare either of them.

 

Thanks :3

 

And multiply classes worked also before - (e.g. ninja)