Displaying an Image On A Map

I want to make a command that when you are holding a map, it sets an image on it. Like a .png or .jpg file. How do you do this? Thanks.

 

1:You need to Listen to the MapInitializeEvent
2.Remove all the Map renderers (use a for loop)
3. Add a new MapRenderer.

 

I need an example please, and I don't want to remove all of the map renderers. Just the one on the map the player is holding. NathanWolf

 

He just meant remove all the map renderers attached to that one map before you add your own (each map id gets its own set of renderers).

The tricky part here is you need to save off the ids of your special maps so you can hook the renderers back up on reload.

I'm still working out some bugs in my own code, but feel free to use it- this link is "live" so as I update the code it will update:

https://github.com/elBukkit/MagicPl...om/elmakers/mine/bukkit/utilities/URLMap.java

This class is completely self-contained. To use it, just call URLMap.load(yourPluginInstance); on enable.. for some reason you need to delay it a bit, like this:

Code:java

 Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
public void run() {
URLMap.resetAll();
URLMap.load(plugin);
}
}, 20);

The resetAll() is probably not necessary, I just have that in there to handle reloads in the case that you've edited the urlmaps.yml file manually (like deleted a map), so this is a "clean" reload.

I guess if you use this class it's probably best to rename it, or at least put it in your own package. The reason is it's a static class (I should probably make it a singleton instead), so if two plugins were using the same class they'd be fighting over who is responsible for the maps. I may refactor it to be a singleton eventually

The main bug I'm trying to squash is that, sometimes, when creating a new instance of an existing map, they all blank out until reload.

The class has some functions to get around this, you can programmatically force a single map reload whenever you create a map, but that's really inefficient, the idea is it should only retrieve the image and render it once, then all maps use that renderer... but something's wrong there and I haven't had a chance to fix it

Of course you're also more than welcome to just cannabalize that code to your liking

EDIT: Heh, I happened to notice this thread before you fixed the tag... in case it seemed like I replied to that super fast

 

MapCanvas#drawImage(java.awt.Image) is your friend.
It makes drawing an Image fairly easy.

To get a Image object from an file: ImageIO#read(File).

How you handle the whole map stuff is up to you.

 

NathanWolf Syd
Thanks. So, do I just use a MapInitializeEvent, get all the map renderers on a map, clear them, and just make a new renderer, and then call the event in my command? Could I have an example please?

 

Cirno

 

How does that help me at all if he isn't even online? I would like this solved this year.

 

He will come online eventually. Also, he was the only who created this plugin http://dev.bukkit.org/bukkit-plugins/imgmap/

 

I would prefer this problem solved as soon as possible. And not depend on someone offline, even though Cirno is a boss.

 

http://wiki.sk89q.com/wiki/Bukkit_map_API

 

I believe that is outdated because it uses the old register events format and the GitHub page that is there comes from two years ago. Can I have a better example than that?

 

Why would that be outdated ? Nothing in the BukkitAPI has changed so that wont work anymore. I'm going to give it a try myself and I'll report back in a second.

 

I still don't like using things that come from a year or more ago.

 

BungeeTheCookie You can still read it and use it as an information source.

 

Show Spoiler Hide Spoiler

Code:java

 
public class TestRenderer extends MapRenderer {
    @Override
    public void render(MapView mapView, MapCanvas mapCanvas, Player player) {
        BufferedImage img;
        try {
 
            img = ImageIO.read(new File(Bukkit.getWorldContainer(),"test.png"));
        } catch (IOException e) {
            e.printStackTrace();
            return;
        }
        mapView.setScale(MapView.Scale.NORMAL);
        mapCanvas.drawImage(5,5,img);
    }
 
}
 

There you go, that's what I used to create that.

 

BungeeTheCookie

You can use the code I gave you outright. It does exactly what you want. Or look at it if you want examples.

I don't know what the map initialize event is for, but I don't use it and it doesn't seem necessary.

 

BungeeTheCookie
How I would try to solve the problem "command that shows an image on the sender's map":

1. Create a own, contextual, MapRenderer implementation to display the image
(You may need the name of the player, the image is displayed to, and the actual image/file)
2. When someone executes the command, check if he is a player, holds a map and has permissions
3. If everything is fine with the command, add a new instance of the custom MapRenderer to the map, the player is currently holding.
(Server#getMap(short id) and Player#getItemInHand().getDurability() will help you to get the MapView).
4. Implement some kind of control mechanism to remove the MapRenderer when it's not needed anymore.

This only works if a later added renderer got an higher priority. I havn't tested it, but after a look in CB source it should work this way.

In the end you would have a pretty neat solution. When someone executes the command one the sender will see the image, even if 100 other people look at the same map.
Also, when another player uses the command on the same map, it will not interfere with the first executor.


Maps are just awsome, I think I should do even more with them.

PS: sk89q's wiki entry to maps IS severly outdated. Almost nothing there is useable anymore.

 

spoonfeed time:

Code:java

package net.yukkuricraft.tenko.render;
 
import java.awt.image.BufferedImage;
import java.io.IOException;
import java.lang.ref.SoftReference;
import java.net.URL;
 
import javax.imageio.ImageIO;
 
import net.yukkuricraft.tenko.ImgMap;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.map.MapCanvas;
import org.bukkit.map.MapRenderer;
import org.bukkit.map.MapView;
 
public class ImageRenderer extends MapRenderer {
 
    // So fancy.
    private SoftReference<BufferedImage> cacheImage;
    private boolean hasRendered = false;
 
    public ImageRenderer(String url) throws IOException {
        this.cacheImage = new SoftReference<>(this.getImage(url));
    }
 
    @SuppressWarnings("deprecation")
    @Override
    public void render(MapView view, MapCanvas canvas, Player player){
        if(this.hasRendered){
            return;
        }
 
        if(this.cacheImage.get() != null){
            canvas.drawImage(0, 0, this.cacheImage.get());
            this.hasRendered = true;
        }else{
            player.sendMessage(ChatColor.RED + "Attempted to render the image, but the cached image was null!");
            ImgMap.logMessage(ChatColor.RED + "While rendering image map ID #" + view.getId() + ", cacheImage was garbage collected.");
            this.hasRendered = true;
        }
    }
 
    public BufferedImage getImage(String url) throws IOException{
        boolean useCache = ImageIO.getUseCache();
 
        // Temporarily disable cache, if it isn't already,
        // so we can get the latest image.
        ImageIO.setUseCache(false);
 
        BufferedImage image = ImageIO.read(new URL(url));
        RenderUtils.resizeImage(image);
 
        // Renable it with the old value.
        ImageIO.setUseCache(useCache);
 
        return image;
    }
 
}
 

Code:java

                        MapView view = Bukkit.getMap(plyr.getItemInHand().getDurability());
                        Iterator<MapRenderer> iter = view.getRenderers().iterator();
                        while(iter.hasNext()){
                            view.removeRenderer(iter.next());
                        }
 
                        try{
                            ImageRenderer renderer = new ImageRenderer(args[0]);
                            view.addRenderer(renderer);
                            cs.sendMessage(ChatColor.AQUA + "[ImgMap] Rendering " + args[0] + "!");
                        }catch (IOException e){
                            cs.sendMessage(ChatColor.RED + "[ImgMap] An error occured! Is the URL correct?");
                            e.printStackTrace();
                        }

All of this was taken from the latest private build of ImgMap.

 

Cirno Whats the import for RenderUtils?

 

It just resizes it; you can easily use Google for that...

 

http://stackoverflow.com/questions/18550284/java-resize-image-from-an-url

Just so any one knows, that suggestion there works great.

Cirno I am having one issue tho. Its only changing the image of the same map! Not the one im holding. I have it copied/pasted just like you have it there with the exception of the resizeimage method I added in.

Code:java

package net.charter.orion_pax.OasisExtras.Commands;
 
import java.io.IOException;
import java.util.Iterator;
 
import net.charter.orion_pax.OasisExtras.ImageRenderer;
import net.charter.orion_pax.OasisExtras.OasisExtras;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.map.MapRenderer;
import org.bukkit.map.MapView;
 
public class MapCommand implements CommandExecutor {
 
    private OasisExtras plugin;
    public MapCommand(OasisExtras plugin) {
        this.plugin = plugin;
    }
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        Player player = (Player) sender;
        if(args.length==1){
            MapView view = Bukkit.getMap(player.getItemInHand().getDurability());
            Iterator<MapRenderer> iter = view.getRenderers().iterator();
            while(iter.hasNext()){
                view.removeRenderer(iter.next());
            }
 
            try{
                ImageRenderer renderer = new ImageRenderer(args[0]);
                view.addRenderer(renderer);
                player.sendMessage(ChatColor.AQUA + "[ImgMap] Rendering " + args[0] + "!");
            }catch (IOException e){
                player.sendMessage(ChatColor.RED + "[ImgMap] An error occured! Is the URL correct?");
            }
            return true;
        }
        return false;
    }
 
}

Code:java

package net.charter.orion_pax.OasisExtras;
 
import java.awt.Dimension;
import java.awt.Graphics2D;
import java.awt.image.BufferedImage;
import java.io.IOException;
import java.lang.ref.SoftReference;
import java.net.URL;
 
import javax.imageio.ImageIO;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.map.MapCanvas;
import org.bukkit.map.MapRenderer;
import org.bukkit.map.MapView;
 
public class ImageRenderer extends MapRenderer {
 
    // So fancy.
    private SoftReference<BufferedImage> cacheImage;
    private boolean hasRendered = false;
 
    public ImageRenderer(String url) throws IOException {
        this.cacheImage = new SoftReference<BufferedImage>(this.getImage(url));
    }
 
    @SuppressWarnings("deprecation")
    @Override
    public void render(MapView view, MapCanvas canvas, Player player){
        if(this.hasRendered){
            return;
        }
 
        if(this.cacheImage.get() != null){
            canvas.drawImage(0, 0, this.cacheImage.get());
            this.hasRendered = true;
        }else{
            player.sendMessage(ChatColor.RED + "Attempted to render the image, but the cached image was null!");
            this.hasRendered = true;
        }
    }
 
    public BufferedImage getImage(String url) throws IOException{
        boolean useCache = ImageIO.getUseCache();
 
        // Temporarily disable cache, if it isn't already,
        // so we can get the latest image.
        ImageIO.setUseCache(false);
 
        BufferedImage image = resize(new URL(url), new Dimension(128,128));
        // TODO find import for RenderUtils
        //RenderUtils.resizeImage(image);
 
        // Renable it with the old value.
        ImageIO.setUseCache(useCache);
 
        return image;
    }
 
    public BufferedImage resize(final URL url, final Dimension size) throws IOException{
        final BufferedImage image = ImageIO.read(url);
        final BufferedImage resized = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_ARGB);
        final Graphics2D g = resized.createGraphics();
        g.drawImage(image, 0, 0, size.width, size.height, null);
        g.dispose();
        return resized;
    }
 
}
 
 
 

 

Can you println() the durability of the item in hand? May be because it's the same durability.

 

I did dupe it with creative and not crafted it. So that might be why!