Deny snowball throwing

Hey guys, I'm trying to make the projectile launch event cancel if a player is holding a snowball. So if they're holding any other item it won't cancel the snowball, only if they're holding it, the event will be cancelled. Here is my code so far, but it doesn't work:

Code:java

package me.BrushPainter.DenySnowballs;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.ProjectileLaunchEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
 
    public void onEnable() {
 
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
 
        getLogger().info("DenySnowballs Enabled");
 
    }
 
    public void onDisable() {
 
        getLogger().info("DenySnowballs Disabled");
 
    }
 
    @EventHandler
    public void onThrow(ProjectileLaunchEvent e) {
 
        Entity entity = e.getEntity();
 
        if(((Player) entity).getItemInHand().getType() == Material.SNOW_BALL) {
 
            if(e.getEntity() instanceof Snowball) {
 
                e.setCancelled(true);
 
            }
        }
    }
}

 

BrushPainter just do if e.getEntity() instanceof Snowball...
remove the line if (((Player) entity).getItemInHand()
http://jd.bukkit.org/rb/doxygen/d2/...event_1_1entity_1_1ProjectileLaunchEvent.html

 

Do some checks first. See if the two if structures are returning true in the onThrow method. Make sure those are working correctly first. This way you can narrow down which part of your code isn't working.

 

You could use the player interact event as well, since there is a few issues with that(I think).

On line 34 you cast entity to a player, however snowmen can throw snowballs as well which might cause issues. You could add something like this first:

Code:java

if(entity instanceof Player) {

And, do you know where your code doesn't work/stops running.

 

KyleParks Not sure, but it loads, just when I try throwing a snowball it works..

The Fancy Whale Ok well I did that, but now it doesn't check if the player is holding a snowball.. I need that to work.

Code:java

    @EventHandler
    public void onThrow(ProjectileLaunchEvent e) {
 
        Entity entity = e.getEntity();
 
        if(entity instanceof Player) {
 
            if(e.getEntity() instanceof Snowball) {
 
                e.setCancelled(true);
 
            }
        }
    }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Why does it matter if they are holding a snowball? If a snowball is thrown I'm guessing they are holding a snowball right?

 

The Fancy Whale No because I need it for my paintball plugin, the guns are horse armor so they shoot snowballs...

 

Okay well if you want to get the player do:

Code:java

Snowball s = e.getEntity();
Player shooter = s.getShooter();
 
if (shooter.getItemInHand().getType() == Material.SNOWBALL)
{
e.setCancelled(true);
}