Solved Custom /msg plugin - Internal error upon typing only /msg. Please help!

Hey bukkit folks,

I am trying to make my own custom /msg plugin (well I already have, but I'm trying to fix it up now.)

Upon typing /msg or the alias /m, you see an internal-error in game. Why is this code not working? It should say "Usage: blah blah" like it does in the code.

Thanks in advance!

Code:java

int i;
    if ((commandLabel.equalsIgnoreCase("m")) || (commandLabel.equals("msg")))
    {
      Player r = Bukkit.getServer().getPlayer(args[0]);
      if (args.length == 0)
      {
        p.sendMessage(ChatColor.GOLD + "[ArcaneMessage]" + ChatColor.WHITE + " Usage: /msg <player> <message>");
        return true;
    }
      else if (args.length == 1)
      {
        p.sendMessage(ChatColor.GOLD + "[ArcaneMessage]" + ChatColor.WHITE + " You must enter a message!");
      }
      else if (r != null)
      {
        String message = "";
        for (i = 1; i < args.length; i++) {
          message = message + args[i] + " ";
        }
        p.sendMessage(ChatColor.GOLD + "[To: " + r.getName() + "] " + ChatColor.GRAY + message);
        r.sendMessage(ChatColor.GOLD + "[From: " + p.getName() + "] " + ChatColor.GRAY + message);[/i]

 

You don't check if args.length == 0 until after you've already tried to access args[0]. If the condition is true you've already errored out, if it's false nothing happens. You have to put the check before you access args.

 

SpaceManiac pardon my ignorance, but how do I do that? I moved the if args.length == 0 all around the code and it didn't do anything for me.

 

redcanoe give us the stacktrace

 

Move Player r = Bukkit.getServer().getPlayer(args[0]); AFTER you know the length is not 0, you can even put it outse the if-else, so you don't need to do it in args==1 and r!=null

Code:java

if (args.length == 0)
{ p.sendMessage(ChatColor.GOLD + "[ArcaneMessage]" + ChatColor.WHITE + " Usage: /msg <player> <message>");
return true;
}
Player r = Bukkit.getServer().getPlayer(args[0]);
if (args.length == 1)
{ p.sendMessage(ChatColor.GOLD + "[ArcaneMessage]" + ChatColor.WHITE + " You must enter a message!");
}

 

redcanoe, Here is my custom "/msg"

Code:java

        Player player = (Player) sender;
        if (cmd.getName().equalsIgnoreCase("msg")) {
            if (args.length < 2) {
                player.sendMessage("§cUsage: /msg (Player) (Msg)");
                return true;
            }
            if (Main.chatList.contains(player.getName())){
                player.sendMessage("§cYou can't use '/msg' while muted.");
                return true;
                }
            String pName = args[0];
            @SuppressWarnings("deprecation")
            Player target = Bukkit.getPlayer(pName);
            if (target == null) {
                player.sendMessage("§cPlayer §4" + args[0]
                        + " §cwas not found.");
                return true;
            } else {
                String message = "";
                for (int i = 1; i < args.length; i++) {
                    message = message + (i > 1 ? " " : "") + args[i];
 
                }
                player.sendMessage("§9[MSG] To: §f" + target.getName() + "§9: §7" + message);
                target.sendMessage("§e[MSG] From: §f" + player.getName() + "§e: §7" + message);
                return true;
            }
        }
        return false;
    }
}[/i]

Feel free to edit it to how you wan't it to look.

 

Konato_K, exactly what I needed, a little bit of hand holding.

Thanks a lot!