Solved Custom event problem?

So here's what I have:

Code:java

    @EventHandler(priority = EventPriority.LOWEST)
    public void firstJoinDetection(PlayerLoginEvent event) {
        // Define our variables.
        Player player = event.getPlayer();
 
        // Call the first join event.
        if (!player.hasPlayedBefore()) {
            System.out.println(player);
            FirstJoinEvent fjp = new FirstJoinEvent(player);
            plugin.getServer().getPluginManager().callEvent(fjp);
            return;
        }

As you see on line 8 there, I print the player, which works fine resulting in:

Code:

CraftPlayer{name=chaseoes}

And then it calls my custom event, this is what I have for that:

Code:java

package me.chaseoes.firstjoinplus;
 
import org.bukkit.entity.Player;
import org.bukkit.event.Event;
import org.bukkit.event.HandlerList;
 
public class FirstJoinEvent extends Event {
    private static final HandlerList handlers = new HandlerList();
    public Player p;
 
    public FirstJoinEvent(Player player) {
        player = p;
    }
 
    public HandlerList getHandlers() {
        return handlers;
    }
 
    public static HandlerList getHandlerList() {
        return handlers;
    }
 
    public Player getPlayer() {
        return p;
    }
}

Then I listen to my custom event:

Code:java

    @EventHandler
    public void onFirstJoin(FirstJoinEvent event) {
        System.out.println(event.getPlayer());
    }

However, from that code, the player is returning null (proven by that debugging where I print the player). I'm passing a non-null player to my custom event, but I get it back as null? Am I missing something here?

Thanks!

 

Code:

public Player p;
 
public FirstJoinEvent(Player player) {
    player = p;
}

because you do it the wrong way around. Currently you assign 'player' (which is the one you pass in) to 'p' which is currently null, resulting in both variables being null. Hence, do it the other way around.

 

Oh, wow.. thanks!

 

to prevent this kind of bugs in the future, mark al the variables inside your class as final whits are not indented to chance during the objects life spam

 

doesn't matter as he's assigning it in the constructor, only if he'd mark the parameter as final. using the 'this' operator would help a lot more.