Commands with Args

I am making a plugin and I want to add commands with a base command with arguments.

Here is what i want
/sprotect (Basecommand)
/sprotect example
/sprotect example1

Heres my code

Code:

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
           
            Player p = (Player) sender;
        if(args.length == 0) {
            if(cmd.getName().equalsIgnoreCase("sprotect")) {
                p.sendMessage(ChatColor.GREEN + "/sp enablebreak" + ChatColor.AQUA + " Enables block breaking protection");
                p.sendMessage(ChatColor.GREEN + "/sp enableplace" + ChatColor.AQUA + " Enables block placing protection");
                p.sendMessage(ChatColor.GREEN + "/sp disablebreak" + ChatColor.AQUA + " Disables block breaking protection");
                p.sendMessage(ChatColor.GREEN + "/sp disableplace" + ChatColor.AQUA + " Disables block placing protection");
                p.sendMessage(ChatColor.GREEN + "/sp reload" + ChatColor.AQUA + " Reloads the plugin. Do this after using any /sp enable commands.");
            }
      else {
                if(args.length == 1) {
           
                    if(args[1] == "enablebreak") {
                        if(!p.hasPermission("simpleprotect.enablebreak") || p.hasPermission("simpleprotect.*")) {
                            p.sendMessage(ChatColor.DARK_RED + "You do not have permission to enable break protection.");
                        } else {
                            p.sendMessage(ChatColor.AQUA + "Block Break protection has been " + ChatColor.GREEN + "enabled" + ChatColor.AQUA + ".");
                            getConfig().set("BreakProtect", true);
                        }
                    }
                }
           
                    if(args[0] == "enableplace") {
                        if(!p.hasPermission("simpleprotect.enableplace") || p.hasPermission("simpleprotect.*")) {
                            p.sendMessage(ChatColor.DARK_RED + "You do not have permission to enable place protection.");
                        } else {
                            p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.GREEN + "enabled" + ChatColor.AQUA + ".");
                            getConfig().set("PlaceProtect", true);
                        }
                    }
                   
                    if(args[0] == "disablebreak") {
                        if(!p.hasPermission("simpleprotect.disablebreak") || p.hasPermission("simpleprotect.*")) {
                            p.sendMessage(ChatColor.DARK_RED + "You do not have permission to disable break protection.");
                        } else {
                            p.sendMessage(ChatColor.AQUA + "Block Break protection has been " + ChatColor.RED + "disabled" + ChatColor.AQUA + ".");
                            getConfig().set("BreakProtect", false);
                        }
                    }
                   
                    if(args[0] == "disableplace") {
                        if(!p.hasPermission("simpleprotect.disableplace") || p.hasPermission("simpleprotect.*")) {
                            p.sendMessage(ChatColor.DARK_RED + "You do not have permission to disable place protection.");
                        } else {
                            p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.RED + "disabled" + ChatColor.AQUA + ".");
                            getConfig().set("PlaceProtect", false);
                        }
                    }
           
                    if(args[0] == "reload") {
                        if(!p.hasPermission("simpleprotect.reload") || p.hasPermission("simpleprotect.*")) {
                            p.sendMessage(ChatColor.DARK_RED + "You do not have permission to reload SimpleProtection");
                        } else {
                            instance.reloadConfig();
                            instance.saveConfig();
                        }
                    }
        return false;
        }
        return false;
        }
        return false;
    }

So as you can see /sprotect sends you all of the help menu. That part works. But /sprotect enablebreak, /sprotect enableplace, etc doesn't work.

Please help!

 

Paste plugin.yml?

 

Code:

main: me.BetaNyan.SimpleProtection.Main
version: 1.0
name: SimpleProtection
 
commands:
    sprotect:

 

Try:

Code:

     
name: SimpleProtection
version: 1.0
author: BetaNyan
main: me.BetaNyan.SimpleProtection.Main
description: Your description!
 
commands:
    sprotect:   
        usage: /<command>
        description: Description!
                   
          

 

Whenever I do /sprotect or /sprotect <args> it just shows the help menu and or it says /sprotect <args>

 

BetaNyan
In the plugin.yml remove the usage part.
All of these have to be else if

Code:java

if(args[0] == "enableplace") {
if(!p.hasPermission("simpleprotect.enableplace") || p.hasPermission("simpleprotect.*")) {
p.sendMessage(ChatColor.DARK_RED + "You do not have permission to enable place protection.");
} else {
p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.GREEN + "enabled" + ChatColor.AQUA + ".");
getConfig().set("PlaceProtect", true);
}
}
 
else if(args[0] == "disablebreak") {
if(!p.hasPermission("simpleprotect.disablebreak") || p.hasPermission("simpleprotect.*")) {
p.sendMessage(ChatColor.DARK_RED + "You do not have permission to disable break protection.");
} else {
p.sendMessage(ChatColor.AQUA + "Block Break protection has been " + ChatColor.RED + "disabled" + ChatColor.AQUA + ".");
getConfig().set("BreakProtect", false);
}
}
 
else if(args[0] == "disableplace") {
if(!p.hasPermission("simpleprotect.disableplace") || p.hasPermission("simpleprotect.*")) {
p.sendMessage(ChatColor.DARK_RED + "You do not have permission to disable place protection.");
} else {
p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.RED + "disabled" + ChatColor.AQUA + ".");
getConfig().set("PlaceProtect", false);
}
}
 
else if(args[0] == "reload") {
if(!p.hasPermission("simpleprotect.reload") || p.hasPermission("simpleprotect.*")) {
p.sendMessage(ChatColor.DARK_RED + "You do not have permission to reload SimpleProtection");
} else {
instance.reloadConfig();
instance.saveConfig();
}
}

So it would be

else if(args[0] == "disableplace") {
The onyl one if just if(args[0] would be enableplace

 

Didn't work! Heres my code

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
            Player p = (Player) sender;
        if(args.length == 0) {
            if(cmd.getName().equalsIgnoreCase("sprotect")) {
                p.sendMessage(ChatColor.GREEN + "/sp enablebreak" + ChatColor.AQUA + " Enables block breaking protection");
                p.sendMessage(ChatColor.GREEN + "/sp enableplace" + ChatColor.AQUA + " Enables block placing protection");
                p.sendMessage(ChatColor.GREEN + "/sp disablebreak" + ChatColor.AQUA + " Disables block breaking protection");
                p.sendMessage(ChatColor.GREEN + "/sp disableplace" + ChatColor.AQUA + " Disables block placing protection");
                p.sendMessage(ChatColor.GREEN + "/sp reload" + ChatColor.AQUA + " Reloads the plugin. Do this after using any /sp enable commands.");
            }
      else if(args.length == 1) {
 
                    if(args[0] == "enableplace") {
                        if(!p.hasPermission("simpleprotect.enableplace") || p.hasPermission("simpleprotect.*")) {
                        p.sendMessage(ChatColor.DARK_RED + "You do not have permission to enable place protection.");
                        } else {
                        p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.GREEN + "enabled" + ChatColor.AQUA + ".");
                        getConfig().set("PlaceProtect", true);
                        }
                        }
 
                    else if(args[0] == "enableplace") {
                        if(!p.hasPermission("simpleprotect.enableplace") || p.hasPermission("simpleprotect.*")) {
                        p.sendMessage(ChatColor.DARK_RED + "You do not have permission to enable place protection.");
                        } else {
                        p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.GREEN + "enabled" + ChatColor.AQUA + ".");
                        getConfig().set("PlaceProtect", true);
                        }
                        }
 
                        else if(args[0] == "disablebreak") {
                        if(!p.hasPermission("simpleprotect.disablebreak") || p.hasPermission("simpleprotect.*")) {
                        p.sendMessage(ChatColor.DARK_RED + "You do not have permission to disable break protection.");
                        } else {
                        p.sendMessage(ChatColor.AQUA + "Block Break protection has been " + ChatColor.RED + "disabled" + ChatColor.AQUA + ".");
                        getConfig().set("BreakProtect", false);
                        }
                        }
 
                        else if(args[0] == "disableplace") {
                        if(!p.hasPermission("simpleprotect.disableplace") || p.hasPermission("simpleprotect.*")) {
                        p.sendMessage(ChatColor.DARK_RED + "You do not have permission to disable place protection.");
                        } else {
                        p.sendMessage(ChatColor.AQUA + "Block Place protection has been " + ChatColor.RED + "disabled" + ChatColor.AQUA + ".");
                        getConfig().set("PlaceProtect", false);
                        }
                        }
 
                        else if(args[0] == "reload") {
                        if(!p.hasPermission("simpleprotect.reload") || p.hasPermission("simpleprotect.*")) {
                        p.sendMessage(ChatColor.DARK_RED + "You do not have permission to reload SimpleProtection");
                        } else {
                        instance.reloadConfig();
                        instance.saveConfig();
                        }
                        }
                }
      }
        return false;
    }
}

 

BetaNyan
Is there any stracktrace?
What exactly doesn't work?
Try:
else if (args[0].equalsIgnoreCase("stuffhere"))
Add the equalsIgnoreCase
Try removing this line:
else if(args.length == 1) {

 

don't use == with strings.

BetaNyan

Do it like this.

Code:java

if(cmd.getName().equalsIgnoreCase("MainCommand.")) {
    if(args.lenth == 0) {
        //do whatever.
    }else if(args.lenth == 1){
        if(args[0].equalsIgnoreCase("arg1")) {
            //do arg1.
            return;
        }else if(args[0].equalsIgnoreCase("arg2")) {
            //do arg2.
 
            // you get the idea.
        }
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

BetaNyan
Look at your if logic.

if args length is 0 -
-if command is /sprotect
--run code
if args length is 1
-if args[0] is X
--run code

You should check if the command is /sprotect, then the args.

If I used /abcdefghijklmnopqrstuvwxyz enableplace, the code would run.
Also, you have the enableplace argument twice ... makes no sense. Proofread your code man, it's not that difficult.

Also, you are unsafely casting sender to player. If you try to run the command from command block or console, you will get an internal server error.

 

Or just use a

HTML:

switch() {
//yourcasehere
}

Statement.

 

es359 That's also incorrect. Your brackets are misplaced. Read your code again and update the post accordingly

(Didn't see your switch post, I mean Post #10)

 

Um... no?

 

es359
****, I can't read I suppose. My bad . Man, I'm on a stupid post spree today

 

AoH_Ruthless Lol You had me scared for a second. I panicked and put it in eclipse just to make sure. XD

 

es359
Yeah know, I thought the else if (args[0].equalsIgnoreCase("arg2")) {} actually said else if (args.length == 2) {}

Like I said, I clearly can't read

Anyways lets not make fun of me too much longer (we have to keep the topic on track, right? )

 

Sorry, didn't see your last post lol.


Usually, I don't like doing it like that, because, it can confuse people do the the elseifs() right after the statement.

I try to space them out, or just use the switch() statement with args[0]. (It's easer to read. I think anyway lol.)


EDIT: I was using Sublime 2 texteditor at the time, so it doesn't have any of the actual java syntax in it.

Updated code. BetaNyan. Like AoH_Ruthless said, Make sure to properly check your commands arguments, and your logic. Or it will backfire on you. Also, I recommend you add a safe to your player cast, so you don't get that nasty console error.

Code:java

 
        if(cmd.getName().equalsIgnoreCase("MainCommand.")) {
            if(args.length == 0) {
                //do whatever.
            }else if(args.length == 1){
                if(args[0].equalsIgnoreCase("arg1")) {
                    //do arg1.
                    return true;
                }else if(args[0].equalsIgnoreCase("arg2")) {
                    //do arg2.
 
                    // you get the idea.
                }
            }
        }
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

es359
Instead of lots of embedded ifs, else ifs, and elses, I just return at the end of each body.

Code:java

 
if (args.length == 1) {
if (args[0].equalsIgnoreCase("a")) {
// code
return true;
}
if ... {
// code
return true;
}
}
 
if (args.length == 0 {
// code
return true;
}
 

But I guess it is to each his own.
Technically, that is slightly less efficient than else if and I guess is a bad practice, but I think it looks better.

However, you are also correct. Switch statements are optimized by the compiler, providing more efficiency and maybe even a bit of eloquence in your code

 

Might be the java course I'm taking lol... Instructor tends to favor nested elseif() statements. AoH_Ruthless

 

es359
I would not say elseif() statements are bad. They have a wide variety of purposes and it's good that your Java course is teaching them (hopefully properly).

Case statements are more preferable when there is a long chain of if statements. Let me explain:

With a chain of say, 5 if statements, you compiler basically is forced to check each one in a row until a match is found. If statements can also have tons of things to check. You could have to check if string s is equal to AoH_Ruthless, boolean a == boolean b, etc. Switch statements force you to only check one thing at a time.

But else ifs are obviously more dynamic, because they allow you to check multiple things at once, albeit giving up a few nanoseconds of speed.