Solved Command not recognized?

I am relatively new to java(and modding), so bear with me. I am trying to create a plugin named Medic! (without ! in most instances as for some reason nothing likes that) and I am working on a revive command right now. The command is /mrev and it only recognizes it like that, not with a player like I want it to (ex /mrev Duskite to revive Duskite).


Here is my main class -

Code:

package com.gmail.mlpmusicvids;
 
import java.util.logging.Logger;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class main extends JavaPlugin{
    public Logger logger = Logger.getLogger("Minecraft");
    public static main plugin;
 
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() +  " Has Been Disabled!");
    }
   
    @SuppressWarnings("unused")
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled!");
        PluginManager pm = getServer().getPluginManager();
    }
}

And here is the class supposed to take over for the revive command(I have one for extinguish commands and one for heal commands too, just not started on them) -

Code:

package com.gmail.mlpmusicvids;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class revive implements CommandExecutor{
    @SuppressWarnings("unused")
    private main plugin;
   
    public revive(main plugin){
        this.plugin = plugin;
    }
 
    @SuppressWarnings("unused")
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
       
        if(cmd.getName().equalsIgnoreCase("mrevive")){
            if(!(sender instanceof Player)){
                return true;
            }
       
            Player p = (Player) sender;
       
            if(args[0].length() == 1) {
                p.sendMessage(ChatColor.RED + "You need more arguements than that.");
            }
            if(args[0].length() == 2 && p.hasPermission("medic.revive")) {
                Player player = Bukkit.getServer().getPlayer(args[1]);
               
                if(player == null || !player.isOnline()){
                    p.sendMessage(ChatColor.RED + "" + player + " is not online.");
                }
               
                if(!player.isDead()){
                    p.sendMessage(ChatColor.RED + "The player " + player + " is not dead.");
                }
                Location playerlc = player.getLocation();
               
                player.setHealth(20);
                player.sendMessage(ChatColor.GREEN + "Player " + p + " has revived you.");
            }
        }
        return false;
    }
}

And my plugin.yml -

Code:

name: Medic
version: 0.1.0
description: Plugin to allow for medics.
author: Duskite
 
main: com.gmail.mlpmusicvids.main
 
commands:
  mrevive:
    decription: Revives players where they stand.
    aliases: mrev OR
    permission: medic.revive
    usage: Systax error, did you mean /mrev PlayerName?

I don;t get any messages of errors from the actual command class, only from the plugin.yml lines. It seems like there is nothing linking the main to the revive class, but as I am still a total noob, I have no idea for sure. If more information about the errors is needed, I will provide.

 

This line will set "mref OR" as an alias for the command. If you want to define more than one, put them in square brackets, like so:
[mrev, secondAlias, thirdAlias]
Additionally, you should do a check in your onCommand to see if the label equals the command or the alias.

EDIT: Also, do what this guy said. \/ Missed that entirely.

 

Duskite
Hey! I see you aren't setting the executor of your command... Well in addition to having them defined under your commands: node in your plugin.yml, you need to set the executor for them.

Code:java

@Override
public void onEnable() {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled!");
    PluginManager pm = getServer().getPluginManager();
    registerCommands();
}
 
private void registerCommands() {
    getCommand("mrev").setExecutor(new revive(this));
}

 

Also get rid of the this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled!");
It is not needed! Bukkit automatically does this for you.

 

Unless he wants the version in it... Bukkit doesn't log a message with the name and the version, so it's not bad if he wants the version

 

JUST started my server and found this line from one of my plugins. I know that I did not log this line.
01:30:12 [INFO] [Zephyrus] Enabling Zephyrus v0.4.1
It says the name and the version.

 

Hmm you're absolutely right! Odd how I forgot (it's been all the code over testing time I've been doing)

 

I actually do have a 01:30:12 [INFO] [Zephyrus] Zephyrus v0.4.1 by minnymin3 Enabled! cuz I have a bunch of stuff that does stuff in onEnable and ya it hooks into other plugins

 

I kinda want that in case I decide to do something with it later, but thanks for that info.

As for that, I never knew about that, so I will go test that right away.

Edit: Every command (/mrev and /mrevive) returned null, when they should send errors that there wasn't enough arguments. I added the return true; to every ending in the revive.java class, so I don't know what is null right now.

 

args.length not args[0].length?

 

Thanks, but now I see it requires two names, when I just wanted it to specify the player to revive. Gotta figure this one out now. At least this provides experience to learn and hopefully never make these stupid mistakes again.

So far, it seems to be working, other than the fact that when a mistake is made, both the plugin.yml and my code yells at the player. I am trying to get rid of the plugin.yml, and instead changed the error message to

Code:

@SuppressWarnings("unused")
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
     
        if(cmd.getName().equalsIgnoreCase("mrevive") || cmd.getName().equalsIgnoreCase("mrev")){
            if(!(sender instanceof Player)){
                return true;
            }
            String command = (String) cmd.getName();
            Player p = (Player) sender;
     
            if(args.length == 0) {
                p.sendMessage(ChatColor.RED + "You need more arguements than that, did you mean /" + command + " Player?");
            }

(This being the revive command code up until the first false)
I am trying to make the code recognize whether the player typed /mrev or /mrevive and then change the error presented to them so it is less confusing. However, in the message (the command part) it just typed mrevive, no matter if the player typed mrev or mrevive. It makes no sense to me, as I set the string to be similar to the if statement that checks for mrev or mrevive. (And yes, the mrev is part of the aliases in the plugin.yml, so it should recognize both.)

Still don't know what is wrong with this latest error (post above).

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Wait, what? Please structure your question. Put the things you want in points, put the errors you get in points. Otherwise for me, it's just tl;dr

 

Okay then:

Error:
- Player types /mrev, instead of returning "You need more arguements, try /(whichever alias they used) player", it types "... try /mrevive player"

Want:
- I want it to recognize what alias was used, and use it inside the error notice, to show the player it was a correct alias.

This is the piece of code I have to recognize what they typed,

Code:

String command = (String) cmd.getName();
            Player p = (Player) sender;

taking the cmd.getName(); from the if that recognizes a command, thinking it would output the same string for my command string.

Code:

if(cmd.getName().equalsIgnoreCase("mrevive") || cmd.getName().equalsIgnoreCase("mrev")){

 

If you want it to recognize which command was sent, don't do "if it's this command or this command move on and do this-" because it won't seperate the execution of code per command it'll just do the code within the if statement for both commands.

Code:java

if(cmd.getName().equalsIgnoreCase("mrev") {
    // do some more checks then the end result
} else if(cmd.getName().equalsIgnoreCase("mrevive") {
    // do some more checks then the end result
}

 

Was kinda hoping to only change the response if the arguments are wrong, duplicating the code just to change one word seems a bit.. much? I don't know if that's the only way, though it seems like there should be an easier way.

 

It's not a bit much, considering you want to check for two different commands. Having the same execution code would make having two commands useless and at that point you're wanting an alias.

If you want command aliases go to your plugin.yml, under where you specified your command add:

Code:yaml

 
aliases: my_alias
# OR for multiple
aliases: [my_alias, my_second_alias, my_third_alias]
 

 

I have it there, it's just I wanted the code to detect what is typed so as the response
p.sendMessage(ChatColor.RED + "You need more arguements than that, did you mean /" + command + " Player?");
would detect what alias was used, and use it to confirm the player had, in fact, used a correct alias but it was used wrong.

 

You can alternatively use label instead of command.getName() as it will detect aliases the way you want I believe.

Code:java

if(label.equalsIgnoreCase("mrev") {
// do some more checks then the end result
} else if(label.equalsIgnoreCase("mrevive") {
// do some more checks then the end result
}

You can then send messages using:

Code:java

 
p.sendMessage(ChatColor.RED + "You need more arguments than that, did you mean /" + label + " player?");
 

It will correctly send the used alias the player sent.

 

Thank you! Now, to figure out how to respawn a player on command...

 

Duskite
When a player dies, get their location, and put it into a map or wherever you want to store their death location. Then when a player revives someone, it gives them X health and teleports them to their death location. Now, you can get more creative with animations, sounds, reagents and possibly giving them all items or only certain items back when revived. Good luck!

 

Been trying that, giving them health 20 and teleporting them to their previous location, but it just gets them stuck in the respawn menu, with the respawn button not working. Now, my tester was across the ocean, so latency might be bugging it up. I'll try again with someone close to me.

The code that that deals with it is:

Code:

@Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
   
        if(cmd.getName().equalsIgnoreCase("mrevive") || cmd.getName().equalsIgnoreCase("mrev")){
            if(!(sender instanceof Player)){
                return true;
            }
            Player p = (Player) sender;
   
            if(args.length == 0) {
                p.sendMessage(ChatColor.RED + "You need more arguements than that, did you mean /" + label + " Player?");
            }
            if(args.length == 1 && p.hasPermission("medic.revive")) {
                Player player = Bukkit.getServer().getPlayer(args[0]);
           
                if(player == null || !player.isOnline()){
                    p.sendMessage(ChatColor.RED + "" + player + " is not online.");
                    return true;
                }
           
                else if(!player.isDead()){
                    p.sendMessage(ChatColor.RED + "The player " + player + " is not dead.");
                    return true;
                }
           
                else{
                    Location playerlc = player.getLocation();
                  player.setHealth(20);
                    player.teleport(playerlc);
                    player.sendMessage(ChatColor.GREEN + "Player " + p + " has revived you.");
                  return true;
              }
            }
        }
        return false;
    }

Way down at the last else.

As you see in the else if right about that, it checks if player is not dead and if they aren't, it produces a message.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Duskite
Okay well first you want to check if the player is dead:

Code:java

 
if(player.isDead()) {
    // force spawn them
} else {
    // else simply teleport them and do all the other stuff
}

A post from this thread shown by fireblast709 on how to use packet #205 to force respawn a player (I believe).

Code:java

@EventHandler
public void onDeath(PlayerDeathEvent e)
{
    String tv = Bukkit.getVersion();
    int index = tv.indexOf("(MC: ")+5;
    int end = tv.indexOf(")", index);
    String version = tv.substring(index, end);
    try
    {
        Class packet = Class.forName("net.minecraft.server.v"+version.replace(".", "_") +".Packet205ClientCommand");
        Object name = packet.getConstructor(new Class[0]).newInstance(new Object[0]);
        Field a = packet.getDeclaredField("a");
        a.setAccessible(true);
        a.set(name, 1);
        Object nmsPlayer = Class.forName("org.bukkit.craftbukkit.v"+version.replace(".", "_")+".entity.CraftPlayer").getMethod("getHandle", new Class[0]).invoke(e.getEntity(), new Object[0]);
        Field con = Class.forName("net.minecraft.server.v"+version.replace(".", "_") +".EntityPlayer").getDeclaredField("playerConnection");
        con.setAccessible(true);
        Object handle = con.get(nmsPlayer);
        packet.getDeclaredMethod("handle", Class.forName("net.minecraft.server.v"+version.replace(".", "_") +".Connection")).invoke(name, handle);
    }
    catch(Exception ex)
    {
        ex.printStackTrace();
    }
}

 

This is just going to be if they're dead, so I think I weeded out the players who arn't dead so this will only run on a dead player, someone who isn't respawned yet. I will check out that thread.