Solved Command lists itself rather than run what it is supposed to.

Hello,
My plugin will not properly do what it is supposed to when the command is given. Rather than do what is supposed to it just lists the command on my chat. Can anyone help?

Code:

Code:

package com.gmail.eliteninja42;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.material.Command;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class SmartSmelt extends JavaPlugin {
    public final Logger logger = Logger.getLogger("Minecraft");
    public static SmartSmelt plugin;
   
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Has Been Disabled!");
    }
   
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled!");
    }
   
    public boolean onCommand(CommandSender sender, Command cmd, String command, String[] args){
        Player player = (Player) sender;
       
        if (command.equalsIgnoreCase("smelt")){
            if (player.getItemInHand().getType() == Material.IRON_ORE){
                ItemStack iron = player.getInventory().getItemInHand();
                int amount = iron.getAmount();
                ItemStack smelt = new ItemStack(Material.IRON_INGOT, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Iron Ore has been smelted!");
               
            }else if (player.getItemInHand().getType() == Material.GOLD_ORE){
                ItemStack gold = player.getInventory().getItemInHand();
                int amount = gold.getAmount();
                ItemStack smelt = new ItemStack(Material.GOLD_INGOT, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Gold Ore has been smelted!");
               
            }else if (player.getItemInHand().getType() == Material.DIAMOND_ORE){
                ItemStack diamond = player.getInventory().getItemInHand();
                int amount = diamond.getAmount();
                ItemStack smelt = new ItemStack(Material.DIAMOND, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Diamond Ore has been smelted!");
               
            }else if (player.getItemInHand().getType() == Material.REDSTONE_ORE){
                ItemStack redstone = player.getInventory().getItemInHand();
                int amount = redstone.getAmount();
                ItemStack smelt = new ItemStack(Material.REDSTONE, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Redstone Ore has been smelted!");
               
        }else if (player.getItemInHand().getType() == Material.COAL_ORE){
            ItemStack coal = player.getInventory().getItemInHand();
            int amount = coal.getAmount();
            ItemStack smelt = new ItemStack(Material.COAL, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Coal Ore has been smelted!");
           
        }else if(player.getItemInHand().getType() == Material.EMERALD_ORE){
            ItemStack emerald = player.getInventory().getItemInHand();
            int amount = emerald.getAmount();
            ItemStack smelt = new ItemStack(Material.EMERALD, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Emerald Ore has been smelted!");
           
        }else if(player.getItemInHand().getType() == Material.QUARTZ_ORE){
            ItemStack quartz = player.getInventory().getItemInHand();
            int amount = quartz.getAmount();
            ItemStack smelt = new ItemStack(Material.QUARTZ, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Quartz Ore has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.RAW_BEEF){
            ItemStack beef = player.getInventory().getItemInHand();
            int amount = beef.getAmount();
            ItemStack smelt = new ItemStack(Material.COOKED_BEEF, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Beef has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.RAW_CHICKEN){
            ItemStack chicken = player.getInventory().getItemInHand();
            int amount = chicken.getAmount();
            ItemStack smelt = new ItemStack(Material.COOKED_CHICKEN, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Chicken has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.LAPIS_ORE){
            ItemStack lapis = player.getInventory().getItemInHand();
            int amount = lapis.getAmount();
            ItemStack smelt = new ItemStack(Material.INK_SACK, amount, (byte)4);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Lapis Lazuli Ore has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.PORK){
            ItemStack pork = player.getInventory().getItemInHand();
            int amount = pork.getAmount();
            ItemStack smelt = new ItemStack(Material.GRILLED_PORK, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Pork has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.RAW_FISH){
            ItemStack fish = player.getInventory().getItemInHand();
            int amount = fish.getAmount();
            ItemStack smelt = new ItemStack(Material.COOKED_FISH, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Fish has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.POTATO){
            ItemStack potato = player.getInventory().getItemInHand();
            int amount = potato.getAmount();
            ItemStack smelt = new ItemStack(Material.BAKED_POTATO, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Potato has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.WOOD){
            ItemStack wood = player.getInventory().getItemInHand();
            int amount = wood.getAmount();
            ItemStack smelt = new ItemStack(Material.COAL, amount, (short)1);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Wood has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.CACTUS){
            ItemStack cactus = player.getInventory().getItemInHand();
            int amount = cactus.getAmount();
            ItemStack smelt = new ItemStack(Material.INK_SACK, amount, (byte)2);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Cactus has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.SAND){
            ItemStack sand = player.getInventory().getItemInHand();
            int amount = sand.getAmount();
            ItemStack smelt = new ItemStack(Material.GLASS, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Sand has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.COBBLESTONE){
            ItemStack cobblestone = player.getInventory().getItemInHand();
            int amount = cobblestone.getAmount();
            ItemStack smelt = new ItemStack(Material.STONE, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Cobblestone has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.CLAY_BALL){
            ItemStack clay = player.getInventory().getItemInHand();
            int amount = clay.getAmount();
            ItemStack smelt = new ItemStack(Material.BRICK, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Clay has been smelted!");
   
        }else if (player.getItemInHand().getType() == Material.NETHERRACK){
            ItemStack nether = player.getInventory().getItemInHand();
            int amount = nether.getAmount();
            ItemStack smelt = new ItemStack(Material.NETHER_BRICK, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Netherrack has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.CLAY){
            ItemStack beef = player.getInventory().getItemInHand();
            int amount = beef.getAmount();
            ItemStack smelt = new ItemStack(Material.HARD_CLAY, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Clay Block has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.AIR){
            player.sendMessage(ChatColor.GREEN + "Your hand appears to be empty!");
        }
            {
           
        return true;
    }
        }
        return true;
    }
}
   
           
       
       
 
 

 

Have you already updated your plugin.yml file?

 

EmilMcDuck This is my plugin.yml

Code:

name: SmartSmelt
main: com.gmail.eliteninja42.SmartSmelt
version: 1.0
author: EliteNinja42
  commands:
    smelt:
      description: Smelts the ore/food in a player's hand at the time of when the command was given.
      usage: /smelt
      permission: SmartSmelt.smelt
      permission-message: Your character does not contain the qualities to execute this command.
    permissions:
      SmartSmelt.smelt:
          description: Smelts the ore/food in a player's hand at the time of when the command was given.
          default: op

 

so you enter /smelt in chat but nothing happn except the console says Player used server command /smelt
is that right?

 

When i enter /smelt it says /smelt in the chat and the console says that I used /smelt yes

 

When you run a command on return false in your onCommand method the usage message will be displayed.

Code:

      usage: /smelt

Are you sure that this code you showed us exactly behaves like this? Because I cannot find any return false; in your code.

 

AmShaegar Yes, I changed it to return true because earlier it would say /smelt wasn't a command; did I fix that issue incorrectly?

 

return true/false only decides, if the command was run successfully so if the usage message should be displayed or not. If it says, unknown command, then you've got an error in your plugin.yml which you obviously fixed at the same time.

Apart from that, your code should work.

 

AmShaegar I changed it back to return false and when I running it on a server it wouldn't load and said invalid plugin.yml. So would this be an error in the plugin.yml?

AmShaegar So you would say this is a plugin.yml error?

Does anyone know the issue?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Please learn how do edit, save and export files properly. How can there be a plugin.yml error if you did not change anything? Look at the error and fix it or post it.

 

AmShaegar I do believe I exported it properly

Code:

name: SmartSmelt
version: 1.0
description: Smelts the ore/food in a player's hand instantly.
main: com.gmail.eliteninja42.SmartSmelt
author: EliteNinja42
commands:
  smelt:
  description: Smelts the ore/food in a player's hand instantly.
  permission: SmartSmelt.smelt
  permission-message: Your character does not contain the qualities to execute this command.
  usage: /smelt
  smelthelp:
  description: Lists the SmartSmelt commands
  usage: /smelthelp
  permissions:
  SmartSmelt.smelt:
      description: Smelts the ore/food in a player's hand instantly.
      default: op

Code:

package com.gmail.eliteninja42;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.material.Command;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class SmartSmelt extends JavaPlugin {
    public final Logger logger = Logger.getLogger("Minecraft");
    public static SmartSmelt plugin;
   
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Has Been Disabled!");
    }
   
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled!");
    }
   
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
       
        if (commandLabel.equalsIgnoreCase("smelthelp")){
            player.sendMessage(ChatColor.GREEN + "Type /smelt while holding an ore or food to smelt it instantly!");
        }
       
        if (commandLabel.equalsIgnoreCase("smelt")){
            if (player.getItemInHand().getType() == Material.IRON_ORE){
                ItemStack iron = player.getInventory().getItemInHand();
                int amount = iron.getAmount();
                ItemStack smelt = new ItemStack(Material.IRON_INGOT, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Iron Ore has been smelted!");
               
            }else if (player.getItemInHand().getType() == Material.GOLD_ORE){
                ItemStack gold = player.getInventory().getItemInHand();
                int amount = gold.getAmount();
                ItemStack smelt = new ItemStack(Material.GOLD_INGOT, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Gold Ore has been smelted!");
               
            }else if (player.getItemInHand().getType() == Material.DIAMOND_ORE){
                ItemStack diamond = player.getInventory().getItemInHand();
                int amount = diamond.getAmount();
                ItemStack smelt = new ItemStack(Material.DIAMOND, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Diamond Ore has been smelted!");
               
            }else if (player.getItemInHand().getType() == Material.REDSTONE_ORE){
                ItemStack redstone = player.getInventory().getItemInHand();
                int amount = redstone.getAmount();
                ItemStack smelt = new ItemStack(Material.REDSTONE, amount);
                player.getInventory().setItemInHand(smelt);
                player.sendMessage(ChatColor.GREEN + "Your Redstone Ore has been smelted!");
               
        }else if (player.getItemInHand().getType() == Material.COAL_ORE){
            ItemStack coal = player.getInventory().getItemInHand();
            int amount = coal.getAmount();
            ItemStack smelt = new ItemStack(Material.COAL, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Coal Ore has been smelted!");
           
        }else if(player.getItemInHand().getType() == Material.EMERALD_ORE){
            ItemStack emerald = player.getInventory().getItemInHand();
            int amount = emerald.getAmount();
            ItemStack smelt = new ItemStack(Material.EMERALD, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Emerald Ore has been smelted!");
           
        }else if(player.getItemInHand().getType() == Material.QUARTZ_ORE){
            ItemStack quartz = player.getInventory().getItemInHand();
            int amount = quartz.getAmount();
            ItemStack smelt = new ItemStack(Material.QUARTZ, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Quartz Ore has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.RAW_BEEF){
            ItemStack beef = player.getInventory().getItemInHand();
            int amount = beef.getAmount();
            ItemStack smelt = new ItemStack(Material.COOKED_BEEF, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Beef has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.RAW_CHICKEN){
            ItemStack chicken = player.getInventory().getItemInHand();
            int amount = chicken.getAmount();
            ItemStack smelt = new ItemStack(Material.COOKED_CHICKEN, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Chicken has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.LAPIS_ORE){
            ItemStack lapis = player.getInventory().getItemInHand();
            int amount = lapis.getAmount();
            ItemStack smelt = new ItemStack(Material.INK_SACK, amount, (byte)4);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Lapis Lazuli Ore has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.PORK){
            ItemStack pork = player.getInventory().getItemInHand();
            int amount = pork.getAmount();
            ItemStack smelt = new ItemStack(Material.GRILLED_PORK, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Pork has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.RAW_FISH){
            ItemStack fish = player.getInventory().getItemInHand();
            int amount = fish.getAmount();
            ItemStack smelt = new ItemStack(Material.COOKED_FISH, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Raw Fish has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.POTATO){
            ItemStack potato = player.getInventory().getItemInHand();
            int amount = potato.getAmount();
            ItemStack smelt = new ItemStack(Material.BAKED_POTATO, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Potato has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.WOOD){
            ItemStack wood = player.getInventory().getItemInHand();
            int amount = wood.getAmount();
            ItemStack smelt = new ItemStack(Material.COAL, amount, (short)1);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Wood has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.CACTUS){
            ItemStack cactus = player.getInventory().getItemInHand();
            int amount = cactus.getAmount();
            ItemStack smelt = new ItemStack(Material.INK_SACK, amount, (byte)2);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Cactus has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.SAND){
            ItemStack sand = player.getInventory().getItemInHand();
            int amount = sand.getAmount();
            ItemStack smelt = new ItemStack(Material.GLASS, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Sand has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.COBBLESTONE){
            ItemStack cobblestone = player.getInventory().getItemInHand();
            int amount = cobblestone.getAmount();
            ItemStack smelt = new ItemStack(Material.STONE, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Cobblestone has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.CLAY_BALL){
            ItemStack clay = player.getInventory().getItemInHand();
            int amount = clay.getAmount();
            ItemStack smelt = new ItemStack(Material.BRICK, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Clay has been smelted!");
   
        }else if (player.getItemInHand().getType() == Material.NETHERRACK){
            ItemStack nether = player.getInventory().getItemInHand();
            int amount = nether.getAmount();
            ItemStack smelt = new ItemStack(Material.NETHER_BRICK, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Netherrack has been smelted!");
       
        }else if (player.getItemInHand().getType() == Material.CLAY){
            ItemStack beef = player.getInventory().getItemInHand();
            int amount = beef.getAmount();
            ItemStack smelt = new ItemStack(Material.HARD_CLAY, amount);
            player.getInventory().setItemInHand(smelt);
            player.sendMessage(ChatColor.GREEN + "Your Clay Block has been smelted!");
           
        }else if (player.getItemInHand().getType() == Material.AIR){
            player.sendMessage(ChatColor.GREEN + "Your hand appears to be empty!");
        }else
            player.sendMessage(ChatColor.GREEN + "You can not smelt this item!");
        }
        return false;
    }
}
   
           
       
       
 
 

 

And wich error do you get?

 

AmShaegar I fixed that.. but now the command still isn't working, if i type /smelt it will show the usage.

 

Obviously, you onCommand always returns false which means the usage message from your plugin.yml is always displayed.

Please test your command with iron ore. Works absolutely fine.

 

AmShaegar So if you do return false; it will always show the usage?

AmShaegar Did you test this plugin? When I tried it again on iron ore nothing happened except the listing of the usage again.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

That's what the return type is for, yes. true: success, no further action. false: something went wrong, display usage message.

I did not test your whole code but I copied the iron ore part in my testplugin to see if there are any non-obvious errors. There were none.

Edit: Tested your whole code and it's still working fine(at least for iron ore). Apperently, you are not able to properly export your plugin.

 

AmShaegar So something is incorrect in my commands? I'm making this harder than it should be aren't I...

AmShaegar ... oh... can you reference me to a site to show me how to properly export then?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

If you managed to do it once, you will be able to do it a second time. Just be sure, you include the fixed plugin.yml and replace any old version of your plugin and restart the server.

Btw: I really hope, your current plugin.yml does not look like the one, you posted above.

YAML Indentaion

 

if i was you i would probably use a switch statement if there's that many items.

 

AmShaegar I am certain I am exporting it properly and it still will not work.


I was going to use a switch statement but I just went with if statements instead.

 

Could you upload your plugin somewhere? I want to check that. Just the jar file, you put into your plugins directory

 

AmShaegar could I perhaps email it to you?

 

I wont post my mail in a public forum. Uplaod it somewhere and send me the link. If you need, private.

 

AmShaegar <Edit by Moderator: Redacted mediafire url>

 

Why is it a zip file?

 

AmShaegar It is

 

Pro tip: Do not hide known file extensions in windows.

http://support.microsoft.com/kb/865219

 

AmShaegar I followed the link and the instructions but on my computer it's not a zip

 

There we go: You imported the command block instead of Command

Code:

import org.bukkit.material.Command;

That's why your onCommand does not override the onCommand method and is never called. Change the import to:

Code:

import org.bukkit.command.Command;

 

AmShaegar It works now! Thanks! I greatly appreciate your help!