Problem/Bug Command Executor plugin just spits back command usage

Discussion in 'Bukkit Help' started by Deaven, Jul 18, 2016.

Thread Status:
Not open for further replies.
  1. Offline

    Deaven

    i have a problem with my i'm not sure whats the deal

    here's my main class
    Code:
    package me.deaven.essentials;
    
    import org.bukkit.plugin.java.JavaPlugin;
    
    import me.deaven.essentials.commands.*;
    
    
    public class main extends JavaPlugin {
      
        public void onEnable() {
          
            getCommand("ci").setExecutor(new ci());
            getCommand("tp").setExecutor(new Teleport());
          
        }
        }
    
    heres the Teleport class
    Code:
    package me.deaven.essentials.commands;
    
    import org.bukkit.Bukkit;
    import org.bukkit.ChatColor;
    import org.bukkit.command.Command;
    import org.bukkit.command.CommandExecutor;
    import org.bukkit.command.CommandSender;
    import org.bukkit.entity.Player;
    
    public class Teleport implements CommandExecutor {
    
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
           
            if(!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.RED + "console is bad");
                if(args.length == 0) {
                    sender.sendMessage(ChatColor.RED + "Error: No Player Was Specified");
                }
                 return false;
            }
            Player p = (Player) sender; {
            }
            @SuppressWarnings("deprecation")
            Player target = Bukkit.getServer().getPlayer(args[0]); {
                if(target == null) {
                    p.sendMessage(ChatColor.RED + "Error: That Player Could Not Be Found");
                }
            }
            if(p.hasPermission("essentials.tp")) {
            p.teleport(target.getLocation());
                p.sendMessage(ChatColor.LIGHT_PURPLE + "You Teleported To" + ChatColor.DARK_PURPLE + " " + target.getName());
                }else{
                    p.sendMessage(ChatColor.RED + "No Permission To Exacute This Command");
                    return true;
                }
           
           
           
            return true;
        }
    }
    
    and lastly is Tphere class
    Code:
    package me.deaven.essentials.commands;
    
    import org.bukkit.Bukkit;
    import org.bukkit.ChatColor;
    import org.bukkit.command.Command;
    import org.bukkit.command.CommandExecutor;
    import org.bukkit.command.CommandSender;
    import org.bukkit.entity.Player;
    
    public class Tphere implements CommandExecutor {
    
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
           
            if(!(sender instanceof Player)) {
                sender.sendMessage("Only Players can use this command");
                return false;
            }
            Player p = (Player) sender; {
            }
            @SuppressWarnings("deprecation")
            Player target = Bukkit.getServer().getPlayer(args[0]); {
                if(target == null) {
                    p.sendMessage(ChatColor.RED + "Error: Player Not Found");
                }
                if(!(p.hasPermission("staff.tphere")));
                p.sendMessage(ChatColor.RED + "No Permission To Exacute This Command");
            }
            if(args.length == 0) {
                p.sendMessage(ChatColor.RED + "Error: Player Not Specified");
            }
            if(p.hasPermission("staff.tphere")) {
                target.teleport(p.getLocation());
                p.sendMessage(ChatColor.DARK_PURPLE + target.getName() + ChatColor.LIGHT_PURPLE + " Was Teleported To You" );
                target.sendMessage(ChatColor.LIGHT_PURPLE + "You Were Teleported To " + ChatColor.DARK_PURPLE + p.getName());
            }else{
                p.sendMessage(ChatColor.RED + "No Permission To Exacute This Command");
                return true;
            }
           
           
           
           
           
           
           
           
            return true;
        }
    }
    
     
    Last edited: Jul 18, 2016
  2. Offline

    thapengwin

    Code:
    Player p = (Player) sender; {
            }
    Why do you have brackets after semicolons? Same goes for this:
    Code:
    Player target = Bukkit.getServer().getPlayer(args[0]); {
    It's all over your code. How does this even compile?
     
    I Al Istannen likes this.
  3. Offline

    I Al Istannen

    @thapengwin
    In this case they just are an unused code block. You can spam brackets all over your code, as long as they are properly closed (and don't move variables or methods out of scope if they are referenced). "{}" is safe (I think) everywhere.

    But I totally agree, this really shouldn't be done. It just clutters it too much.
     
Thread Status:
Not open for further replies.

Share This Page