Coins| Its that time again...

Alrighty guys, so if any of you remember about 5 months ago I was trying to code a coins plugin and absolutely had no knowledge in java no I have a decent amount of knowledge, and only have 2 questions. Ok first off i show code: this is the coins

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // Check if sender is a player first
        if (sender instanceof Player) {
            // Cast sender to Player
            Player player = (Player) sender;
            // Check if the command was "tokens"
            if (cmd.getName().equalsIgnoreCase("coins")) {
                // Check if no arguments are given
                if (args.length == 0) {
                    // Return current owned tokens
                    player.sendMessage(ChatColor.GREEN + "Your current credits: " + ChatColor.GOLD + Api.getMoney(player));
                    return true;
                // Check if 1 argument is given
                } else if (args.length == 1) {
                    // Argument 1 is the name
                    String name = args[0];
                    // Get the player with the given name from server
                    Player target = Bukkit.getServer().getPlayer(name);
                    // Check if player is online
                    if (target != null) {
                        // Get the tokens of the player
                        player.sendMessage(target.getDisplayName() + "'s current credits: " + Api.getMoney(target));
                        return true;
                    // The player with the given name is not online that means target == null
                    } else {
                        // Return that the player is currently not online
                        player.sendMessage(ChatColor.RED +  "The player " + ChatColor.WHITE + name + " is currently not online!");
                        return true;
                    }
                // Check if 2 arguments are given
                } else if (args.length == 2) {
                    player.sendMessage(ChatColor.RED + "You have to specify the amount of money!");
                    return true;
                // Check if 3 arguments are given
                } else if (args.length >= 3) {
                    // Try and catch here, because parsing could always return an invalid result and therefore an error
                    try {
                        // Parse an integer from argument 3
                        int amount = Integer.parseInt(args[2]);
                        // Check if the amount is not negative
                        if (amount > 0) {
                            // Check if the player has enough money
                            if (Api.getMoney(player) >= amount) {
                                // Argument 2 is the name
                                String name = args[1];
                                // Get the player with the given name from the server
                                Player target = Bukkit.getServer().getPlayer(name);
                                // Check if the player is online
                                if (target != null) {
                                    // Check if the sub-command "give" was used
                                    if (args[0].equalsIgnoreCase("give")) {
 
                                        // Take money from the player and give money to the target and send both a notification message
                                        Api.takeMoney(player, amount);
                                        Api.giveMoney(target, amount);
                                        player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " credits!");
                                        target.sendMessage("You received " + amount + " credits from " + player.getName() + "!");
 
 
                                        return true;
                                    // Check if the sub-command "take" was used
                                    } else if (args[0].equalsIgnoreCase("take")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("token.take") || player.isOp()) {
                                            // Take money from the target and give money to the player and send both a notification message
                                            Api.giveMoney(player, amount);
                                            Api.takeMoney(target, amount);
                                            player.sendMessage("You took" + amount + " credits from " + player.getName() + "!");
                                            target.sendMessage(player.getName() + " took " + amount + " credits from you!");
                                            return true;
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage(ChatColor.RED + "You're missing the permission to take credits from other!");
                                            return true;
                                        }
                                    }
                                // The player with the given name is not online that means target == null
                                } else {
                                    // Return that the player is currently not online
                                    player.sendMessage(ChatColor.RED + "The player " + ChatColor.WHITE + name + " is currently not online!");
                                    return true;
                                }
                            // The player has not enough money
                            } else {
                                // Return that the player does not have enough money
                                player.sendMessage(ChatColor.RED + "You don't have enough credits(s)! You're missing: " + (amount-Api.getMoney(player)) + " credit(s).");
                                return true;
                            }
                        // The player typed in a negative amount or 0
                        } else {
                            // Return that the amount has to be higher than 0
                            player.sendMessage(ChatColor.RED + "The credit amount has to be higher than 0!");
                            return true;
                        }
                    // The player typed in an invalid money amount
                    } catch (Exception ex) {
                        // Return that the money amount is invalid
                        player.sendMessage(ChatColor.RED + "Invalid credit amount!");
                        return true;
                    }
                }
            }
        }
        return false;
 
    }  

API: Heart and soul of the whole plugin

Code:java

public class Api {
static SettingsManager settings = SettingsManager.getInstance();     
 
        public static String getId(Player p){
return p.getUniqueId().toString();
        }
        private static Map<String, Integer> moneyMap;
 
    /* Private access methods */
 
    /**
    * Gets the map with all loaded player money values.
    * @return Map<String, Integer> moneyMap
    */
    private static Map<String, Integer> getMoneyMap() {
        // Checks if the money map exists
        if (moneyMap == null) {
            // Creates a new HashMap, because there is no existing money map
            setMoneyMap(new HashMap<String, Integer>());
        }
 
        return moneyMap;
    }
 
    /**
    * Sets and replaces the current map with all player money values.
    * @param Map<String, Integer> moneyMap
    */
    private static void setMoneyMap(Map<String, Integer> map) {
        moneyMap = map;
    }
 
    /* Direct access methods */
 
    /**
    * Gets the money of a specific player by his name.<br>
    * If the player is already in the money map it will get the players money out of the map.<br>
    * If the player is not in the money map it will load his money map from the FileConfiguration.<br>
    * <p>
    * Returns 0 if an error occurred or no saved money value was found.
    * @param String name
    * @return Integer money
    */
    public static int getMoney(String name) {
        // Checks if the name is already inside the money map
        if (getMoneyMap().containsKey(name)) {
            // Returns the money of the found player
            return getMoneyMap().get(name);
        // No entry was found
        } else {
            // Try and catch, because the FileConfiguration could be invalid or null
            try {
                // Checks if the FileConfiguration contains the given name
                if (settings.getData().getKeys(false).contains(name)) {
                    // Checks if the name section contains a "Tokens" section
                    if (settings.getData().getConfigurationSection(name).getKeys(false).contains("Tokens")) {
                        // Get the tokens as integer from the FileConfiguration
                        int tokens = settings.getData().getInt(name+".Tokens");
                        // Sets and therefore creates an entry with the given name and tokens inside the money map
                        setMoney(name, tokens);
                        return tokens;
                    // No "Tokens" section was found and therefore no tokens values is existent
                    } else {
                        // Sets and creates an entry with the given name and 0 tokens inside the money map
                        setMoney(name, 0);
                        // Creates the "Tokens" section inside the FileConfiguration
                        settings.getData().set(name+".Tokens", 0);
                        return 0;
                    }
                // No section with the given name was found
                } else {
                    // Sets and creates an entry with the given name and 0 tokens inside the money map
                    setMoney(name, 0);
                    // Creates the name and "Tokens" sections inside the FileConfiguration
                    settings.getData().set(name+".Tokens", 0);
                    return 0;
                }
            // Something went very wrong and the FileConfiguration or something else created an error
            } catch (Exception ex) {
                // Print error into console for debug reasons
                ex.printStackTrace();
                System.out.println("Invalid config data!");
                // Return 0 as last option
                return 0;
            }
        }
    }
 
    /**
    * Gets the money of a specific player.<br>
    * If the player is already in the money map it will get the players money out of the map.<br>
    * If the player is not in the money map it will load his money from the FileConfiguration and then put it into the money map.<br>
    * <p>
    * Returns 0 if an error occurred or no saved money value for the player was found inside the FileConfiguration.
    * @param Player player
    * @return Integer money
    */
    public static int getMoney(Player player) {
        return getMoney(getId(player));
    }
 
    /**
    * Sets the money of a specific player by his name.
    * @param String name
    * @param Integer amount
    */
    public static void setMoney(String name, int amount) {
        getMoneyMap().put(name, amount);
    }
 
    /**
    * Sets the money of a specific player.
    * @param Player player
    * @param Integer amount
    */
    public static void setMoney(Player player, int amount) {
        setMoney(getId(player), amount);
 
    }
 
    /* Simple access methods */
 
    /**
    * Gives the specified player with the given name the given amount of money.
    * <p>
    * Automatically caps the money at Integer.MAX_VALUE.
    * @param String name
    * @param Integer amount
    */
    public static void giveMoney(String name, int amount) {
        int money = getMoney(name) + amount;
        setMoney(name, (money <= Integer.MAX_VALUE ? money : Integer.MAX_VALUE));
    }
 
    /**
    * Gives the specified player the given amount of money.
    * <p>
    * Automatically caps the money at Integer.MAX_VALUE.
    * @param Player player
    * @param Integer amount
    */
    public static void giveMoney(Player player, int amount) {
        int money = getMoney(getId(player)) + amount;
        setMoney(getId(player), (money <= Integer.MAX_VALUE ? money : Integer.MAX_VALUE));
    }
 
    /**
    * Takes from the specified player with the given name the given amount of money.
    * <p>
    * Automatically caps the money at 0.
    * @param String name
    * @param Integer amount
    */
    public static void takeMoney(String name, int amount) {
        int money = getMoney(name) - amount;
        setMoney(name, (money >= 0 ? money : 0));
    }
 
    /**
    * Takes from the specified player the given amount of money.
    * <p>
    * Automatically caps the money at 0.
    * @param Player player
    * @param Integer amount
    */
    public static void takeMoney(Player player, int amount) {
        int money = getMoney(getId(player)) - amount;
        setMoney(getId(player), (money >= 0 ? money : 0));
    }
public static void saveMoneyValues() {
    for (String name : getMoneyMap().keySet()) {
        settings.getData().set(name+".Tokens", getMoney(name));
    }
}

Settings manager:

Code:java

  public class SettingsManager {
 
        private SettingsManager() { }
 
        static SettingsManager instance = new SettingsManager();
 
        public static SettingsManager getInstance() {
                return instance;
        }
 
        Plugin p;
 
        FileConfiguration config;
        File cfile;
 
        FileConfiguration data;
        File dfile;
 
        public void setup(Plugin p) {
                cfile = new File(p.getDataFolder(), "config.yml");
                config = p.getConfig();
                //config.options().copyDefaults(true);
                //saveConfig();
 
                if (!p.getDataFolder().exists()) {
                        p.getDataFolder().mkdir();
                }
 
                dfile = new File(p.getDataFolder(), "money.yml");
 
                if (!dfile.exists()) {
                        try {
                                dfile.createNewFile();
                        }
                        catch (IOException e) {
                                Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not create money.yml!");
                        }
                }
 
                data = YamlConfiguration.loadConfiguration(dfile);
        }
 
        public FileConfiguration getData() {
                return data;
        }
 
        public void saveData() {
                try {
                        data.save(dfile);
                }
                catch (IOException e) {
                        Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not save money.yml!");
                }
        }
 
        public void reloadData() {
                data = YamlConfiguration.loadConfiguration(dfile);
        }
 
        public FileConfiguration getConfig() {
                return config;
        }
 
        public void saveConfig() {
                try {
                        config.save(cfile);
                }
                catch (IOException e) {
                        Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not save config.yml!");
                }
        }
 
        public void reloadConfig() {
                config = YamlConfiguration.loadConfiguration(cfile);
        }
 
        public PluginDescriptionFile getDesc() {
                return p.getDescription();
        }
 

NOW: two questions
1. Im horrible at configs, so I need help saving the players money to a config, so he can keep his money after logging off

2. How can I make a admin command to give myself coins without having the right amount

ERROR: I cant see to get /take to work, for some reason in order to take coins from someone I have to have the same amount that I want to take

 

XgXXSnipz
Use MySQL, its really not hard. and is faster (I think) but if you know how to use it. when he joins you get the coins from the database (if he contains in the database) then put the coins into a HashMap -> we do that because we don't need to connect to the database every transaction with your coins. and when you do a transaction or you take money get the uuid of that player in the HashMap update their coins. and when they leave then update his coins from the HashMap in the Database

And about the /take please send us the error from the console

 

I have a MySQL version of this that I can send you. I'm to lazy to even read the problem lol

 

Skionz send please xD

 

XgXXSnipz Give me a few hours I'm at school atm lol

 

Skionz o ok

 

XgXXSnipz Your first class's code is curving A LOT.

 

Funergy

In what instance is any SQL server faster for this application, I challenge you to find me benchmarks stating that this is faster than the equivilant code in YAML.

XgXXSnipz

Use YAML, it's faster and easier to work with. There's nothing wrong with using YAML for this.

 

XgXXSnipz
I agree with mythbusterma, there is no point of storing this data to a database unless you plan to display it with stats on a website or sync them across multiple servers, YAML will be your best bet. If you don't want to create a custom config file, you can just use the default config.yml that is part of the API. Yaml is 10x easier to work with IMO for a situation like this.

 

mythbusterma People told me that. let me check my threads.