Clock plugin problem!

Well, You see I coded this Hide players plugin, basically where you right click with some dye and it hides all players, it works but the thing is, is that you can only disable it. Any help? anyways here's my code:

Code:java

package me.QuipCream.HidePlayers;
 
import java.util.ArrayList;
 
import java.util.List;
 
 
 
import org.bukkit.Bukkit;
 
import org.bukkit.ChatColor;
 
import org.bukkit.Material;
 
import org.bukkit.entity.Player;
 
import org.bukkit.event.EventHandler;
 
import org.bukkit.event.Listener;
 
import org.bukkit.event.block.Action;
 
import org.bukkit.event.inventory.InventoryClickEvent;
 
import org.bukkit.event.player.PlayerInteractEvent;
 
import org.bukkit.event.player.PlayerJoinEvent;
 
import org.bukkit.event.player.PlayerQuitEvent;
 
import org.bukkit.inventory.ItemStack;
 
import org.bukkit.inventory.PlayerInventory;
 
import org.bukkit.inventory.meta.ItemMeta;
 
import org.bukkit.plugin.java.JavaPlugin;
 
 
 
public class HidePlayers extends JavaPlugin implements Listener {
 
 
 
public ArrayList<String> cooldown = new ArrayList<>();
 
//List for hiding players
 
ArrayList<String> players = new ArrayList<String>();
 
 
 
public void onEnable() {
 
getServer().getPluginManager().registerEvents(this, this);
 
}
 
 
 
public void onInventoryClick(InventoryClickEvent event) {
 
event.setCancelled(true);
 
}
 
 
 
//Removing player from list
 
public void onQuitEvent(PlayerQuitEvent event) {
 
Player player = event.getPlayer();
 
players.remove(player.getName());
 
}
 
 
 
//Adding people to the list and giving them spawn items
 
@EventHandler
 
public void onPlayerJoin(PlayerJoinEvent event) {
 
Player player = event.getPlayer();
 
PlayerInventory inv = player.getInventory();
 
players.add(player.getName());
 
 
 
ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
 
ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
 
enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
 
List<String> enableList = new ArrayList<String>();
 
enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
 
enableMeta.setLore(enableList);
 
enable.setItemMeta(enableMeta);
 
 
 
// Just here for testing
 
inv.setItem(8, enable);
 
}
 
 
 
//Visibility Dye
 
@EventHandler
 
public void onPlayerClickEvent(PlayerInteractEvent event) {
 
 
 
final Player player = event.getPlayer();
 
 
 
ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
 
ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
 
enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
 
List<String> enableList = new ArrayList<String>();
 
enableList.add(ChatColor.WHITE + "Right click disable player visability");
 
enableMeta.setLore(enableList);
 
enable.setItemMeta(enableMeta);
 
 
 
ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
 
ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
 
disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
 
List<String> disableList = new ArrayList<String>();
 
disableList.add(ChatColor.WHITE + "Right click to enable player visability");
 
disableMeta.setLore(disableList);
 
disable.setItemMeta(disableMeta);
 
 
 
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Players >> Enabled")){
 
if (cooldown.contains(player)) {
 
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "Please wait " + ChatColor.YELLOW +"5 seconds " + ChatColor.GRAY + "to toggled players visibility: " + ChatColor.GREEN + "On");
 
event.setCancelled(true);
 
} else {
 
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
 
if(this.players.contains(event.getPlayer().getName())){
 
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
 
if(player.canSee(targetPlayers)){
 
player.hidePlayer(targetPlayers);
 
} else{
 
event.setCancelled(true);
 
}
 
this.players.add(player.getName());
 
}
 
player.getInventory().removeItem(enable);
 
player.setItemInHand(disable);
 
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "You have toggled players visibility: " + ChatColor.GREEN + "On");
 
cooldown.add(player.getName());
 
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
 
public void run() {
 
cooldown.remove(player.getName());
 
}
 
}, 100);
 
return;
 
}
 
}
 
}
 
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED + "Players >> Disabled")){
 
if (cooldown.contains(player)) {
 
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "Please wait " + ChatColor.YELLOW +"5 seconds " + ChatColor.GRAY + "to toggled players visibility: " + ChatColor.RED + "Off");
 
event.setCancelled(true);
 
} else {
 
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
 
if(this.players.contains(event.getPlayer().getName())){
 
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
 
if(player.canSee(targetPlayers)){
 
event.setCancelled(true);
 
} else {
 
player.showPlayer(targetPlayers);
 
}
 
this.players.remove(player.getName());
 
}
 
}
 
player.getInventory().removeItem(disable);
 
player.setItemInHand(enable);
 
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "You have toggled players visibility: " + ChatColor.RED + "Off");
 
cooldown.add(player.getName());
 
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
 
public void run() {
 
cooldown.remove(player.getName());
 
}
 
 
}, 100);
 
return;
}
 
}
 
}
}
 
}
 
 
 
}
 
 
 
 

 

I don't think I fully understood you, but you don't have a @EventHandler on your QuitEvent.

 

MrInspector

Decompile my plugin hideHub v.3.0.0 with e.g gd-gui . That will help you.

 

I don't understand?

I know how to make clock hide plugins, they're fairly easy, if you were talking to me.

 

Well...
There's quite a few errors here.

Let's start with your spacing.
Your code is very hard to read because everything is at the beginning of the line, and is double spaced?

Also,
You're missing quite a few @EventHandler s, your methods and statements aren't closed properly, and your syntax is incorrect. You shouldn't define ArrayLists inside Events, it makes the code look sloppy.
On line 171 and 183, you have two " } else { " statements. One should be an " } else if { " if you want three possible outcomes.

Your syntax on line 229 is incorrect as well; it should read "if (blablablaifstatementhere == morethingshere) && morethingshere { "

On line 233, your for loop's syntax is far from correct.

Please learn how to organize your code and close your statements, then come ask for some help. A lot of issues would be solved if you cleaned up the code.

Also, is there a stack trace or anything?
Thanks.

One more thing, are you very new to Bukkit and/or Java? If so, please start with some simpler projects.